Build ErsatzTV Image / CI image pin matches docker/ci (pull_request) Successful in 5s
Build ErsatzTV Image / Docs update reminder (pull_request) Successful in 9s
Build ErsatzTV Image / decisions.md append-only (pull_request) Successful in 7s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 7m23s
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 7s
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 7s
Build ErsatzTV Image / Functional E2E (curl contracts) (pull_request) Successful in 15m20s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 18m18s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
A successful fetch returning zero items made existing.Except([]) flag the ENTIRE library FileNotFound in one scan — feeding EmptyTrashHandler's permanent delete and emptying every affected collection (dead channels). Add a shared MediaServerReconciliationGuard that skips (and logs a Warning) the sweep when incoming==0 while items exist, wired into the three library-level sweeps (Television shows / Movie / OtherVideo). An empty incoming set is indistinguishable at scan time from a mid-restore / emptied-upstream error (both report a zero total), so this deliberately overrides #476's degenerate "last item removed => empty incoming => flag" case. #476's cascade still fires for partial deletions (survivors present); its characterization test moves from an empty incoming to a survivor+removed partial-deletion case. Tests: policy table (MediaServerReconciliationGuardTests) + per-scanner integration proving the wiring (empty incoming + non-empty existing flags/reindexes nothing). Proven non-vacuous by neutralizing the guard. Nested TV season/episode sweeps left unguarded (bounded blast radius); ratio-threshold + projection-failure detection deferred to a follow-up. docs/decisions.md updated. Fixes #477 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
510 lines
18 KiB
C#
510 lines
18 KiB
C#
using System.Collections.Immutable;
|
|
using System.IO.Abstractions;
|
|
using ErsatzTV.Core;
|
|
using ErsatzTV.Core.Domain;
|
|
using ErsatzTV.Core.Domain.MediaServer;
|
|
using ErsatzTV.Core.Errors;
|
|
using ErsatzTV.Core.Extensions;
|
|
using ErsatzTV.Core.Interfaces.Repositories;
|
|
using ErsatzTV.Core.Metadata;
|
|
using ErsatzTV.Scanner.Core.Interfaces;
|
|
using ErsatzTV.Scanner.Core.Interfaces.Metadata;
|
|
using Microsoft.Extensions.Logging;
|
|
|
|
namespace ErsatzTV.Scanner.Core.Metadata;
|
|
|
|
public abstract class MediaServerOtherVideoLibraryScanner<TConnectionParameters, TLibrary, TOtherVideo, TEtag>
|
|
where TConnectionParameters : MediaServerConnectionParameters
|
|
where TLibrary : Library
|
|
where TOtherVideo : OtherVideo
|
|
where TEtag : MediaServerItemEtag
|
|
{
|
|
private readonly ILocalChaptersProvider _localChaptersProvider;
|
|
private readonly IScannerProxy _scannerProxy;
|
|
private readonly IFileSystem _fileSystem;
|
|
private readonly ILogger _logger;
|
|
private readonly IMetadataRepository _metadataRepository;
|
|
|
|
protected MediaServerOtherVideoLibraryScanner(
|
|
IScannerProxy scannerProxy,
|
|
IFileSystem fileSystem,
|
|
ILocalChaptersProvider localChaptersProvider,
|
|
IMetadataRepository metadataRepository,
|
|
ILogger logger)
|
|
{
|
|
_scannerProxy = scannerProxy;
|
|
_fileSystem = fileSystem;
|
|
_localChaptersProvider = localChaptersProvider;
|
|
_metadataRepository = metadataRepository;
|
|
_logger = logger;
|
|
}
|
|
|
|
protected virtual bool ServerSupportsRemoteStreaming => false;
|
|
protected virtual bool ServerReturnsStatisticsWithMetadata => false;
|
|
|
|
protected async Task<Either<BaseError, Unit>> ScanLibrary(
|
|
IMediaServerOtherVideoRepository<TLibrary, TOtherVideo, TEtag> otherVideoRepository,
|
|
TConnectionParameters connectionParameters,
|
|
TLibrary library,
|
|
Func<TOtherVideo, string> getLocalPath,
|
|
bool deepScan,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
try
|
|
{
|
|
return await ScanLibrary(
|
|
otherVideoRepository,
|
|
connectionParameters,
|
|
library,
|
|
getLocalPath,
|
|
GetOtherVideoLibraryItems(connectionParameters, library),
|
|
deepScan,
|
|
cancellationToken);
|
|
}
|
|
catch (Exception ex) when (ex is TaskCanceledException or OperationCanceledException)
|
|
{
|
|
return new ScanCanceled();
|
|
}
|
|
}
|
|
|
|
private async Task<Either<BaseError, Unit>> ScanLibrary(
|
|
IMediaServerOtherVideoRepository<TLibrary, TOtherVideo, TEtag> otherVideoRepository,
|
|
TConnectionParameters connectionParameters,
|
|
TLibrary library,
|
|
Func<TOtherVideo, string> getLocalPath,
|
|
IAsyncEnumerable<Tuple<TOtherVideo, int>> otherVideoEntries,
|
|
bool deepScan,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
var incomingItemIds = new List<string>();
|
|
var existingOtherVideos = (await otherVideoRepository.GetExistingOtherVideos(library))
|
|
.ToImmutableDictionary(e => e.MediaServerItemId, e => e);
|
|
|
|
await foreach ((TOtherVideo incoming, int totalOtherVideoCount) in otherVideoEntries.WithCancellation(
|
|
cancellationToken))
|
|
{
|
|
if (cancellationToken.IsCancellationRequested)
|
|
{
|
|
return new ScanCanceled();
|
|
}
|
|
|
|
incomingItemIds.Add(MediaServerItemId(incoming));
|
|
|
|
decimal percentCompletion = Math.Clamp((decimal)incomingItemIds.Count / totalOtherVideoCount, 0, 1);
|
|
if (!await _scannerProxy.UpdateProgress(percentCompletion, cancellationToken))
|
|
{
|
|
return new ScanCanceled();
|
|
}
|
|
|
|
string localPath = getLocalPath(incoming);
|
|
|
|
if (!await ShouldScanItem(
|
|
otherVideoRepository,
|
|
library,
|
|
existingOtherVideos,
|
|
incoming,
|
|
localPath,
|
|
deepScan))
|
|
{
|
|
continue;
|
|
}
|
|
|
|
Either<BaseError, MediaItemScanResult<TOtherVideo>> maybeOtherVideo;
|
|
|
|
if (ServerReturnsStatisticsWithMetadata)
|
|
{
|
|
maybeOtherVideo = await otherVideoRepository
|
|
.GetOrAdd(library, incoming, deepScan, cancellationToken)
|
|
.MapT(result =>
|
|
{
|
|
result.LocalPath = localPath;
|
|
return result;
|
|
})
|
|
.BindT(existing => UpdateMetadataAndStatistics(
|
|
connectionParameters,
|
|
library,
|
|
existing,
|
|
incoming,
|
|
deepScan,
|
|
cancellationToken))
|
|
.BindT(existing => UpdateChapters(existing, cancellationToken));
|
|
}
|
|
else
|
|
{
|
|
maybeOtherVideo = await otherVideoRepository
|
|
.GetOrAdd(library, incoming, deepScan, cancellationToken)
|
|
.MapT(result =>
|
|
{
|
|
result.LocalPath = localPath;
|
|
return result;
|
|
})
|
|
.BindT(existing => UpdateMetadata(
|
|
connectionParameters,
|
|
library,
|
|
existing,
|
|
incoming,
|
|
deepScan,
|
|
None,
|
|
cancellationToken))
|
|
.BindT(existing => UpdateStatistics(
|
|
connectionParameters,
|
|
library,
|
|
existing,
|
|
incoming,
|
|
deepScan,
|
|
None))
|
|
.BindT(existing => UpdateSubtitles(existing, cancellationToken))
|
|
.BindT(existing => UpdateChapters(existing, cancellationToken));
|
|
}
|
|
|
|
if (maybeOtherVideo.IsLeft)
|
|
{
|
|
foreach (BaseError error in maybeOtherVideo.LeftToSeq())
|
|
{
|
|
_logger.LogWarning(
|
|
"Error processing other video {Title}: {Error}",
|
|
incoming.OtherVideoMetadata.Head().Title,
|
|
error.Value);
|
|
}
|
|
|
|
continue;
|
|
}
|
|
|
|
foreach (MediaItemScanResult<TOtherVideo> result in maybeOtherVideo.RightToSeq())
|
|
{
|
|
await otherVideoRepository.SetEtag(result.Item, MediaServerEtag(incoming));
|
|
|
|
if (_fileSystem.File.Exists(result.LocalPath))
|
|
{
|
|
Option<int> flagResult = await otherVideoRepository.FlagNormal(library, result.Item);
|
|
if (flagResult.IsSome)
|
|
{
|
|
result.IsUpdated = true;
|
|
}
|
|
}
|
|
else if (ServerSupportsRemoteStreaming)
|
|
{
|
|
Option<int> flagResult = await otherVideoRepository.FlagRemoteOnly(library, result.Item);
|
|
if (flagResult.IsSome)
|
|
{
|
|
result.IsUpdated = true;
|
|
}
|
|
}
|
|
else
|
|
{
|
|
Option<int> flagResult = await otherVideoRepository.FlagUnavailable(library, result.Item);
|
|
if (flagResult.IsSome)
|
|
{
|
|
result.IsUpdated = true;
|
|
}
|
|
}
|
|
|
|
if (result.IsAdded || result.IsUpdated)
|
|
{
|
|
if (!await _scannerProxy.ReindexMediaItems([result.Item.Id], cancellationToken))
|
|
{
|
|
_logger.LogWarning("Failed to reindex media items from scanner process");
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// trash OtherVideo that are no longer present on the media server
|
|
if (MediaServerReconciliationGuard.ShouldFlagMissing(
|
|
_logger, library.Name, incomingItemIds.Count, existingOtherVideos.Count))
|
|
{
|
|
var fileNotFoundItemIds = existingOtherVideos.Keys.Except(incomingItemIds).ToList();
|
|
List<int> ids = await otherVideoRepository.FlagFileNotFound(library, fileNotFoundItemIds);
|
|
if (!await _scannerProxy.ReindexMediaItems(ids.ToArray(), cancellationToken))
|
|
{
|
|
_logger.LogWarning("Failed to reindex media items from scanner process");
|
|
}
|
|
}
|
|
|
|
return Unit.Default;
|
|
}
|
|
|
|
protected abstract string MediaServerItemId(TOtherVideo otherVideo);
|
|
protected abstract string MediaServerEtag(TOtherVideo otherVideo);
|
|
|
|
protected abstract IAsyncEnumerable<Tuple<TOtherVideo, int>> GetOtherVideoLibraryItems(
|
|
TConnectionParameters connectionParameters,
|
|
TLibrary library);
|
|
|
|
protected abstract Task<Option<OtherVideoMetadata>> GetFullMetadata(
|
|
TConnectionParameters connectionParameters,
|
|
TLibrary library,
|
|
MediaItemScanResult<TOtherVideo> result,
|
|
TOtherVideo incoming,
|
|
bool deepScan);
|
|
|
|
protected virtual Task<Option<MediaVersion>> GetMediaServerStatistics(
|
|
TConnectionParameters connectionParameters,
|
|
TLibrary library,
|
|
MediaItemScanResult<TOtherVideo> result,
|
|
TOtherVideo incoming) => Task.FromResult(Option<MediaVersion>.None);
|
|
|
|
protected abstract Task<Option<Tuple<OtherVideoMetadata, MediaVersion>>> GetFullMetadataAndStatistics(
|
|
TConnectionParameters connectionParameters,
|
|
TLibrary library,
|
|
MediaItemScanResult<TOtherVideo> result,
|
|
TOtherVideo incoming);
|
|
|
|
protected abstract Task<Either<BaseError, MediaItemScanResult<TOtherVideo>>> UpdateMetadata(
|
|
MediaItemScanResult<TOtherVideo> result,
|
|
OtherVideoMetadata fullMetadata,
|
|
CancellationToken cancellationToken);
|
|
|
|
private async Task<bool> ShouldScanItem(
|
|
IMediaServerOtherVideoRepository<TLibrary, TOtherVideo, TEtag> otherVideoRepository,
|
|
TLibrary library,
|
|
ImmutableDictionary<string, TEtag> existingOtherVideos,
|
|
TOtherVideo incoming,
|
|
string localPath,
|
|
bool deepScan)
|
|
{
|
|
// deep scan will always pull every OtherVideo
|
|
if (deepScan)
|
|
{
|
|
return true;
|
|
}
|
|
|
|
string existingEtag = string.Empty;
|
|
MediaItemState existingState = MediaItemState.Normal;
|
|
if (existingOtherVideos.TryGetValue(MediaServerItemId(incoming), out TEtag? existingEntry))
|
|
{
|
|
existingEtag = existingEntry.Etag;
|
|
existingState = existingEntry.State;
|
|
}
|
|
|
|
if (existingState is MediaItemState.Unavailable or MediaItemState.FileNotFound &&
|
|
existingEtag == MediaServerEtag(incoming))
|
|
{
|
|
// skip scanning unavailable/file not found items that are unchanged and still don't exist locally
|
|
if (!_fileSystem.File.Exists(localPath) && !ServerSupportsRemoteStreaming)
|
|
{
|
|
return false;
|
|
}
|
|
}
|
|
else if (existingEtag == MediaServerEtag(incoming))
|
|
{
|
|
// item is unchanged, but file does not exist
|
|
// don't scan, but mark as unavailable
|
|
if (!_fileSystem.File.Exists(localPath))
|
|
{
|
|
if (ServerSupportsRemoteStreaming)
|
|
{
|
|
if (existingState is not MediaItemState.RemoteOnly)
|
|
{
|
|
foreach (int id in await otherVideoRepository.FlagRemoteOnly(library, incoming))
|
|
{
|
|
if (!await _scannerProxy.ReindexMediaItems([id], CancellationToken.None))
|
|
{
|
|
_logger.LogWarning("Failed to reindex media items from scanner process");
|
|
}
|
|
}
|
|
}
|
|
}
|
|
else
|
|
{
|
|
if (existingState is not MediaItemState.Unavailable)
|
|
{
|
|
foreach (int id in await otherVideoRepository.FlagUnavailable(library, incoming))
|
|
{
|
|
if (!await _scannerProxy.ReindexMediaItems([id], CancellationToken.None))
|
|
{
|
|
_logger.LogWarning("Failed to reindex media items from scanner process");
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
if (existingEntry is null)
|
|
{
|
|
_logger.LogDebug("INSERT: new other video {OtherVideo}", incoming.OtherVideoMetadata.Head().Title);
|
|
}
|
|
else
|
|
{
|
|
_logger.LogDebug(
|
|
"UPDATE: Etag has changed for other video {OtherVideo}",
|
|
incoming.OtherVideoMetadata.Head().Title);
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
private async Task<Either<BaseError, MediaItemScanResult<TOtherVideo>>> UpdateMetadataAndStatistics(
|
|
TConnectionParameters connectionParameters,
|
|
TLibrary library,
|
|
MediaItemScanResult<TOtherVideo> result,
|
|
TOtherVideo incoming,
|
|
bool deepScan,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
Option<Tuple<OtherVideoMetadata, MediaVersion>> maybeMetadataAndStatistics = await GetFullMetadataAndStatistics(
|
|
connectionParameters,
|
|
library,
|
|
result,
|
|
incoming);
|
|
|
|
foreach ((OtherVideoMetadata fullMetadata, MediaVersion mediaVersion) in maybeMetadataAndStatistics)
|
|
{
|
|
Either<BaseError, MediaItemScanResult<TOtherVideo>> metadataResult = await UpdateMetadata(
|
|
connectionParameters,
|
|
library,
|
|
result,
|
|
incoming,
|
|
deepScan,
|
|
fullMetadata,
|
|
cancellationToken);
|
|
|
|
foreach (BaseError error in metadataResult.LeftToSeq())
|
|
{
|
|
return error;
|
|
}
|
|
|
|
foreach (MediaItemScanResult<TOtherVideo> r in metadataResult.RightToSeq())
|
|
{
|
|
result = r;
|
|
}
|
|
|
|
Either<BaseError, MediaItemScanResult<TOtherVideo>> statisticsResult = await UpdateStatistics(
|
|
connectionParameters,
|
|
library,
|
|
result,
|
|
incoming,
|
|
deepScan,
|
|
mediaVersion);
|
|
|
|
foreach (BaseError error in statisticsResult.LeftToSeq())
|
|
{
|
|
return error;
|
|
}
|
|
|
|
foreach (MediaItemScanResult<TOtherVideo> r in metadataResult.RightToSeq())
|
|
{
|
|
result = r;
|
|
}
|
|
}
|
|
|
|
return result;
|
|
}
|
|
|
|
private async Task<Either<BaseError, MediaItemScanResult<TOtherVideo>>> UpdateMetadata(
|
|
TConnectionParameters connectionParameters,
|
|
TLibrary library,
|
|
MediaItemScanResult<TOtherVideo> result,
|
|
TOtherVideo incoming,
|
|
bool deepScan,
|
|
Option<OtherVideoMetadata> maybeFullMetadata,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
if (maybeFullMetadata.IsNone)
|
|
{
|
|
maybeFullMetadata = await GetFullMetadata(connectionParameters, library, result, incoming, deepScan);
|
|
}
|
|
|
|
foreach (OtherVideoMetadata fullMetadata in maybeFullMetadata)
|
|
{
|
|
// TODO: move some of this code into this scanner
|
|
// will have to merge JF, Emby, Plex logic
|
|
return await UpdateMetadata(result, fullMetadata, cancellationToken);
|
|
}
|
|
|
|
return result;
|
|
}
|
|
|
|
private async Task<Either<BaseError, MediaItemScanResult<TOtherVideo>>> UpdateStatistics(
|
|
TConnectionParameters connectionParameters,
|
|
TLibrary library,
|
|
MediaItemScanResult<TOtherVideo> result,
|
|
TOtherVideo incoming,
|
|
bool deepScan,
|
|
Option<MediaVersion> maybeMediaVersion)
|
|
{
|
|
TOtherVideo existing = result.Item;
|
|
|
|
if (deepScan || result.IsAdded || MediaServerEtag(existing) != MediaServerEtag(incoming) ||
|
|
existing.MediaVersions.Head().Streams.Count == 0)
|
|
{
|
|
if (maybeMediaVersion.IsNone)
|
|
{
|
|
maybeMediaVersion = await GetMediaServerStatistics(
|
|
connectionParameters,
|
|
library,
|
|
result,
|
|
incoming);
|
|
}
|
|
|
|
foreach (MediaVersion mediaVersion in maybeMediaVersion)
|
|
{
|
|
if (await _metadataRepository.UpdateStatistics(result.Item, mediaVersion))
|
|
{
|
|
result.IsUpdated = true;
|
|
}
|
|
}
|
|
}
|
|
|
|
return result;
|
|
}
|
|
|
|
|
|
private async Task<Either<BaseError, MediaItemScanResult<TOtherVideo>>> UpdateSubtitles(
|
|
MediaItemScanResult<TOtherVideo> existing,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
try
|
|
{
|
|
MediaVersion version = existing.Item.GetHeadVersion();
|
|
Option<OtherVideoMetadata> maybeMetadata = existing.Item.OtherVideoMetadata.HeadOrNone();
|
|
foreach (OtherVideoMetadata metadata in maybeMetadata)
|
|
{
|
|
List<Subtitle> subtitles = version.Streams
|
|
.Filter(s => s.MediaStreamKind is MediaStreamKind.Subtitle or MediaStreamKind.ExternalSubtitle)
|
|
.Map(Subtitle.FromMediaStream)
|
|
.ToList();
|
|
|
|
if (await _metadataRepository.UpdateSubtitles(metadata, subtitles, cancellationToken))
|
|
{
|
|
return existing;
|
|
}
|
|
}
|
|
|
|
return BaseError.New("Failed to update media server subtitles");
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
return BaseError.New(ex.ToString());
|
|
}
|
|
}
|
|
|
|
private async Task<Either<BaseError, MediaItemScanResult<TOtherVideo>>> UpdateChapters(
|
|
MediaItemScanResult<TOtherVideo> existing,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
try
|
|
{
|
|
if (string.IsNullOrEmpty(existing.LocalPath))
|
|
{
|
|
// No local path available for external chapter file lookup
|
|
return existing;
|
|
}
|
|
|
|
if (await _localChaptersProvider.UpdateChapters(existing.Item, Some(existing.LocalPath), cancellationToken))
|
|
{
|
|
existing.IsUpdated = true;
|
|
}
|
|
|
|
return existing;
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
return BaseError.New(ex.ToString());
|
|
}
|
|
}
|
|
}
|