Files
ersatztv/ErsatzTV/Controllers/Api/ResolutionController.cs
T
timothyandClaude Fable 5 540def7f17
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 4m51s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 5m21s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
fix: address #93 adversarial review findings
Backend: 401 documented on all mutating settings/resolution routes;
resolution delete distinguishes 404 (unknown) from 422 (not custom);
XMLTV enum bridging via exhaustive switch instead of int casts;
field-level Arg.Is assertions incl. non-null watermark/filler flow.

Frontend: resolution add/delete failures surfaced inline (were
silent); partial saves merge succeeded groups via allSettled; empty
numeric fields invalid + tunerCount min 1; HLS Direct select shows
out-of-list wire values; media-source rows show derived last-scan.

ErsatzTV.Tests 495; web suite 145.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-07 09:22:51 +02:00

80 lines
3.7 KiB
C#

using System.ComponentModel.DataAnnotations;
using ErsatzTV.Application.Resolutions;
using ErsatzTV.Controllers.Api.Requests;
using ErsatzTV.Core;
using ErsatzTV.Core.Api.Settings;
using ErsatzTV.Extensions;
using MediatR;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc;
namespace ErsatzTV.Controllers.Api;
[ApiController]
[EndpointGroupName("general")]
public class ResolutionController(IMediator mediator) : ControllerBase
{
[HttpGet("/api/ffmpeg/resolution/by-name/{name}", Name="GetResolutionByName")]
public async Task<ActionResult<ResolutionViewModel>> GetResolutionByName(string name, CancellationToken cancellationToken)
{
Option<ResolutionViewModel> result = await mediator.Send(new GetResolutionByName(name), cancellationToken);
return result.Match<ActionResult<ResolutionViewModel>>(i => Ok(i), () => NotFound());
}
[HttpGet("/api/settings/resolutions", Name = "GetResolutions")]
[Tags("Settings")]
[EndpointSummary("Get all resolutions, including custom resolutions")]
[ProducesResponseType(typeof(List<ResolutionResponseModel>), StatusCodes.Status200OK)]
public async Task<List<ResolutionResponseModel>> GetAll(CancellationToken cancellationToken)
{
List<ResolutionViewModel> resolutions = await mediator.Send(new GetAllResolutions(), cancellationToken);
return resolutions.Map(ProjectToResponseModel).ToList();
}
[HttpPost("/api/settings/resolutions", Name = "CreateResolution")]
[Tags("Settings")]
[EndpointSummary("Create a custom resolution")]
[ProducesResponseType(typeof(ResolutionResponseModel), StatusCodes.Status201Created)]
[ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status401Unauthorized)]
[ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status422UnprocessableEntity)]
public async Task<IActionResult> Create(
[Required] [FromBody]
CreateResolutionRequest request,
CancellationToken cancellationToken)
{
Option<BaseError> result = await mediator.Send(request.ToCommand(), cancellationToken);
return await result.Match(
Some: error => Task.FromResult(error.ToErrorResult()),
None: async () =>
{
string name = $"{request.Width}x{request.Height}";
Option<ResolutionViewModel> resolution =
await mediator.Send(new GetResolutionByName(name), cancellationToken);
return resolution.Match(
Some: vm => (IActionResult)new CreatedResult(
$"/api/settings/resolutions/{vm.Id}",
ProjectToResponseModel(vm)),
None: () => ApiResults.NotFoundProblem());
});
}
[HttpDelete("/api/settings/resolutions/{id:int}", Name = "DeleteResolution")]
[Tags("Settings")]
[EndpointSummary("Delete a custom resolution")]
[ProducesResponseType(StatusCodes.Status204NoContent)]
[ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status401Unauthorized)]
[ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status404NotFound)]
[ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status422UnprocessableEntity)]
public async Task<IActionResult> Delete(int id, CancellationToken cancellationToken)
{
Option<BaseError> result = await mediator.Send(new DeleteCustomResolution(id), cancellationToken);
return result.Match<IActionResult>(
Some: error => error.ToErrorResult(),
None: () => new NoContentResult());
}
private static ResolutionResponseModel ProjectToResponseModel(ResolutionViewModel vm) =>
new(vm.Id, vm.Name, vm.Width, vm.Height, vm.IsCustom);
}