Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 3m43s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 4m58s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
Build ErsatzTV Image / Build & test (.NET) (push) Successful in 3m44s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (push) Successful in 5m0s
Build ErsatzTV Image / Build & push image (amd64) (push) Successful in 3m41s
First slice of the REST API (ersatztv#2). Idiomatic REST over existing MediatR handlers; design in docs/rest-api.md.
Foundation: NotFoundError : BaseError (Core) to split 404 from 422; ApiResults mapping helpers (Either/Option -> 201+Location / 200 / 204 / 404 / 422), additive (existing *ToActionResult untouched); ApiKeyAuthorizationFilter (optional X-Api-Key on mutating actions, gated by Api:WriteKey, no-op when unset) — independent of the IPTV JWT toggle so Jellyfin/Dispatcharr reads are unaffected, applied at controller-class level so every mutating action incl. ResetPlayout is covered fail-safe.
Channels: POST /api/channels (201+Location), PUT/{id} (200/404), DELETE/{id} (204/404), GET/{id} (200/404). Request DTOs -> existing commands; responses reuse ChannelViewModel. Ported page-only validations into handlers (ShowInEpg-when-disabled, external-logo-URL, Group NotEmpty) + FFmpegProfile/Watermark/Filler existence on update for create-parity. Fixed a latent 500: the .Filter(c>0) existence pattern threw TaskCanceledException on not-found; rewritten to AnyAsync.
Tests (NUnit, TZ=UTC): handler success/404/422, ApiResults mapping, API-key filter, controller status/Location/mapping, a controller-security regression net, and a create->read->delete EF integration test on a new in-memory SQLite harness. ErsatzTV.Tests 46/46, Architecture 5/5.
Refs #34
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
328 lines
12 KiB
C#
328 lines
12 KiB
C#
using System.Globalization;
|
|
using System.Text.RegularExpressions;
|
|
using System.Threading.Channels;
|
|
using ErsatzTV.Application.Subtitles;
|
|
using ErsatzTV.Core;
|
|
using ErsatzTV.Core.Domain;
|
|
using ErsatzTV.Core.Domain.Filler;
|
|
using ErsatzTV.Core.Errors;
|
|
using ErsatzTV.Core.Interfaces.Search;
|
|
using ErsatzTV.Infrastructure.Data;
|
|
using ErsatzTV.Infrastructure.Extensions;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using static ErsatzTV.Application.Channels.ChannelValidations;
|
|
using static ErsatzTV.Application.Channels.Mapper;
|
|
using Channel = ErsatzTV.Core.Domain.Channel;
|
|
|
|
namespace ErsatzTV.Application.Channels;
|
|
|
|
public class UpdateChannelHandler(
|
|
ChannelWriter<IBackgroundServiceRequest> workerChannel,
|
|
IDbContextFactory<TvContext> dbContextFactory,
|
|
ISearchTargets searchTargets)
|
|
: IRequestHandler<UpdateChannel, Either<BaseError, ChannelViewModel>>
|
|
{
|
|
public async Task<Either<BaseError, ChannelViewModel>> Handle(
|
|
UpdateChannel request,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
await using TvContext dbContext = await dbContextFactory.CreateDbContextAsync(cancellationToken);
|
|
|
|
Option<Channel> maybeChannel = await dbContext.Channels
|
|
.Include(c => c.Artwork)
|
|
.Include(c => c.Watermark)
|
|
.Include(c => c.Playouts)
|
|
.SelectOneAsync(c => c.Id, c => c.Id == request.ChannelId, cancellationToken);
|
|
|
|
return await maybeChannel.Match(
|
|
Some: async channel =>
|
|
{
|
|
Validation<BaseError, Channel> validation =
|
|
await Validate(dbContext, request, channel, cancellationToken);
|
|
return await validation.Apply(c => ApplyUpdateRequest(dbContext, c, request, cancellationToken));
|
|
},
|
|
None: () => Task.FromResult(
|
|
Left<BaseError, ChannelViewModel>(
|
|
new NotFoundError($"Channel {request.ChannelId} does not exist."))));
|
|
}
|
|
|
|
private async Task<ChannelViewModel> ApplyUpdateRequest(
|
|
TvContext dbContext,
|
|
Channel c,
|
|
UpdateChannel update,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
// don't save mirror when playout exists
|
|
if (c.Playouts.Count > 0)
|
|
{
|
|
update = update with
|
|
{
|
|
PlayoutSource = ChannelPlayoutSource.Generated,
|
|
MirrorSourceChannelId = null
|
|
};
|
|
}
|
|
|
|
bool hasEpgChange = c.PlayoutSource != update.PlayoutSource || c.ShowInEpg != update.ShowInEpg;
|
|
|
|
c.Name = update.Name;
|
|
c.Number = update.Number;
|
|
c.SortNumber = double.Parse(update.Number, CultureInfo.InvariantCulture);
|
|
c.Group = update.Group;
|
|
c.Categories = update.Categories;
|
|
c.FFmpegProfileId = update.FFmpegProfileId;
|
|
c.SlugSeconds = update.SlugSeconds;
|
|
c.StreamSelectorMode = update.StreamSelectorMode;
|
|
c.StreamSelector = update.StreamSelector;
|
|
c.PreferredAudioLanguageCode = update.PreferredAudioLanguageCode;
|
|
c.PreferredAudioTitle = update.PreferredAudioTitle;
|
|
c.PreferredSubtitleLanguageCode = update.PreferredSubtitleLanguageCode;
|
|
c.SubtitleMode = update.SubtitleMode;
|
|
c.MusicVideoCreditsMode = update.MusicVideoCreditsMode;
|
|
c.MusicVideoCreditsTemplate = update.MusicVideoCreditsTemplate;
|
|
c.SongVideoMode = update.SongVideoMode;
|
|
c.TranscodeMode = update.TranscodeMode;
|
|
c.IdleBehavior = update.IdleBehavior;
|
|
c.IsEnabled = update.IsEnabled;
|
|
c.ShowInEpg = update.IsEnabled && update.ShowInEpg;
|
|
c.Artwork ??= [];
|
|
|
|
if (!string.IsNullOrWhiteSpace(update.Logo?.Path))
|
|
{
|
|
string logo = update.Logo.Path;
|
|
if (logo.StartsWith("iptv/logos/", StringComparison.Ordinal))
|
|
{
|
|
logo = logo.Replace("iptv/logos/", string.Empty);
|
|
}
|
|
|
|
Option<Artwork> maybeLogo = c.Artwork.Where(a => a.ArtworkKind == ArtworkKind.Logo).HeadOrNone();
|
|
foreach (Artwork artwork in maybeLogo)
|
|
{
|
|
artwork.Path = logo;
|
|
artwork.OriginalContentType = !string.IsNullOrEmpty(update.Logo.ContentType)
|
|
? update.Logo.ContentType
|
|
: null;
|
|
artwork.DateUpdated = DateTime.UtcNow;
|
|
}
|
|
|
|
if (maybeLogo.IsNone)
|
|
{
|
|
var artwork = new Artwork
|
|
{
|
|
Path = logo,
|
|
OriginalContentType = !string.IsNullOrEmpty(update.Logo.ContentType)
|
|
? update.Logo.ContentType
|
|
: null,
|
|
DateAdded = DateTime.UtcNow,
|
|
DateUpdated = DateTime.UtcNow,
|
|
ArtworkKind = ArtworkKind.Logo
|
|
};
|
|
c.Artwork.Add(artwork);
|
|
}
|
|
}
|
|
else
|
|
{
|
|
await dbContext.Entry(c)
|
|
.Collection(channel => channel.Artwork)
|
|
.LoadAsync(cancellationToken);
|
|
|
|
foreach (Artwork artwork in c.Artwork.Where(x => x.ArtworkKind is ArtworkKind.Logo).ToList())
|
|
{
|
|
c.Artwork.Remove(artwork);
|
|
dbContext.Artwork.Remove(artwork);
|
|
}
|
|
}
|
|
|
|
c.PlayoutSource = update.PlayoutSource;
|
|
c.PlayoutMode = update.PlayoutMode;
|
|
|
|
if (c.PlayoutSource is ChannelPlayoutSource.Mirror)
|
|
{
|
|
c.PlayoutMode = ChannelPlayoutMode.Continuous;
|
|
hasEpgChange |= c.MirrorSourceChannelId != update.MirrorSourceChannelId;
|
|
hasEpgChange |= c.PlayoutOffset != update.PlayoutOffset;
|
|
}
|
|
else
|
|
{
|
|
c.MirrorSourceChannelId = null;
|
|
c.PlayoutOffset = null;
|
|
}
|
|
|
|
c.MirrorSourceChannelId = update.MirrorSourceChannelId;
|
|
c.PlayoutOffset = update.PlayoutOffset;
|
|
c.StreamingMode = update.StreamingMode;
|
|
c.WatermarkId = update.WatermarkId;
|
|
c.FallbackFillerId = update.FallbackFillerId;
|
|
|
|
await dbContext.SaveChangesAsync(cancellationToken);
|
|
|
|
searchTargets.SearchTargetsChanged();
|
|
|
|
if (c.SubtitleMode != ChannelSubtitleMode.None)
|
|
{
|
|
Option<Playout> maybePlayout = await dbContext.Playouts
|
|
.SelectOneAsync(p => p.ChannelId, p => p.ChannelId == c.Id, cancellationToken);
|
|
|
|
foreach (Playout playout in maybePlayout)
|
|
{
|
|
await workerChannel.WriteAsync(new ExtractEmbeddedSubtitles(playout.Id), cancellationToken);
|
|
}
|
|
}
|
|
|
|
await workerChannel.WriteAsync(new RefreshChannelList(), cancellationToken);
|
|
if (hasEpgChange)
|
|
{
|
|
await workerChannel.WriteAsync(new RefreshChannelData(c.Number), cancellationToken);
|
|
}
|
|
|
|
return ProjectToViewModel(c, c.Playouts?.Count ?? 0);
|
|
}
|
|
|
|
private static async Task<Validation<BaseError, Channel>> Validate(
|
|
TvContext dbContext,
|
|
UpdateChannel request,
|
|
Channel channel,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
Validation<BaseError, Channel> channelValidation = (ValidateName(request),
|
|
await ValidateNumber(dbContext, request, cancellationToken),
|
|
await MirrorSourceMustBeValid(dbContext, request, cancellationToken),
|
|
ValidateShowInEpg(request.IsEnabled, request.ShowInEpg),
|
|
ValidateLogo(request.Logo?.Path))
|
|
.Apply((_, _, _, _, _) => channel);
|
|
|
|
// combine the page-only Group rule plus the FK existence checks (FFmpeg profile / watermark /
|
|
// fallback filler) with the channel validation; splitting keeps tuple arity within
|
|
// LanguageExt's supported applicative range while still accumulating all errors
|
|
return (ValidateGroup(request.Group),
|
|
await FFmpegProfileMustExist(dbContext, request, cancellationToken),
|
|
await WatermarkMustExist(dbContext, request, cancellationToken),
|
|
await FillerPresetMustExist(dbContext, request, cancellationToken),
|
|
channelValidation)
|
|
.Apply((_, _, _, _, c) => c);
|
|
}
|
|
|
|
private static async Task<Validation<BaseError, int>> FFmpegProfileMustExist(
|
|
TvContext dbContext,
|
|
UpdateChannel request,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
bool exists = await dbContext.FFmpegProfiles
|
|
.AnyAsync(p => p.Id == request.FFmpegProfileId, cancellationToken);
|
|
if (exists)
|
|
{
|
|
return request.FFmpegProfileId;
|
|
}
|
|
|
|
return BaseError.New($"FFmpegProfile {request.FFmpegProfileId} does not exist.");
|
|
}
|
|
|
|
private static async Task<Validation<BaseError, Option<int>>> WatermarkMustExist(
|
|
TvContext dbContext,
|
|
UpdateChannel request,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
if (request.WatermarkId is null)
|
|
{
|
|
return Option<int>.None;
|
|
}
|
|
|
|
bool exists = await dbContext.ChannelWatermarks
|
|
.AnyAsync(w => w.Id == request.WatermarkId, cancellationToken);
|
|
if (exists)
|
|
{
|
|
return Optional(request.WatermarkId);
|
|
}
|
|
|
|
return BaseError.New($"Watermark {request.WatermarkId} does not exist.");
|
|
}
|
|
|
|
private static async Task<Validation<BaseError, Option<int>>> FillerPresetMustExist(
|
|
TvContext dbContext,
|
|
UpdateChannel request,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
if (request.FallbackFillerId is null)
|
|
{
|
|
return Option<int>.None;
|
|
}
|
|
|
|
bool exists = await dbContext.FillerPresets
|
|
.Filter(fp => fp.FillerKind == FillerKind.Fallback)
|
|
.AnyAsync(w => w.Id == request.FallbackFillerId, cancellationToken);
|
|
if (exists)
|
|
{
|
|
return Optional(request.FallbackFillerId);
|
|
}
|
|
|
|
return BaseError.New($"Fallback filler {request.FallbackFillerId} does not exist.");
|
|
}
|
|
|
|
private static async Task<Validation<BaseError, Unit>> MirrorSourceMustBeValid(
|
|
TvContext dbContext,
|
|
UpdateChannel request,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
if (request.PlayoutSource is not ChannelPlayoutSource.Mirror)
|
|
{
|
|
return Unit.Default;
|
|
}
|
|
|
|
Option<Channel> maybeMirrorSource = await dbContext.Channels
|
|
.AsNoTracking()
|
|
.SelectOneAsync(
|
|
c => c.Id == request.MirrorSourceChannelId,
|
|
c => c.Id == request.MirrorSourceChannelId,
|
|
cancellationToken);
|
|
|
|
if (maybeMirrorSource.IsNone)
|
|
{
|
|
return BaseError.New("Mirror source channel does not exist.");
|
|
}
|
|
|
|
foreach (var mirrorSource in maybeMirrorSource)
|
|
{
|
|
if (mirrorSource.PlayoutSource is not ChannelPlayoutSource.Generated)
|
|
{
|
|
return BaseError.New(
|
|
$"Mirror source channel {mirrorSource.Name} must use generated playout source");
|
|
}
|
|
}
|
|
|
|
foreach (TimeSpan playoutOffset in Optional(request.PlayoutOffset))
|
|
{
|
|
if (playoutOffset < TimeSpan.FromHours(-12) || playoutOffset > TimeSpan.FromHours(12))
|
|
{
|
|
return BaseError.New("Playout offset must not be greater than 12 hours");
|
|
}
|
|
}
|
|
|
|
return Unit.Default;
|
|
}
|
|
|
|
private static Validation<BaseError, string> ValidateName(UpdateChannel updateChannel) =>
|
|
updateChannel.NotEmpty(c => c.Name)
|
|
.Bind(_ => updateChannel.NotLongerThan(50)(c => c.Name));
|
|
|
|
private static async Task<Validation<BaseError, string>> ValidateNumber(
|
|
TvContext dbContext,
|
|
UpdateChannel updateChannel,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
int matchId = await dbContext.Channels
|
|
.SelectOneAsync(c => c.Number, c => c.Number == updateChannel.Number, cancellationToken)
|
|
.Match(c => c.Id, () => updateChannel.ChannelId);
|
|
|
|
if (matchId == updateChannel.ChannelId)
|
|
{
|
|
if (Regex.IsMatch(updateChannel.Number, Channel.NumberValidator))
|
|
{
|
|
return updateChannel.Number;
|
|
}
|
|
|
|
return BaseError.New("Invalid channel number; two decimals are allowed for subchannels");
|
|
}
|
|
|
|
return BaseError.New("Channel number must be unique");
|
|
}
|
|
}
|