Files
ersatztv/scripts/tests
timothyandClaude Opus 5 75b0bb14d2 fix(869,893): correct the creator-null mechanism and four overclaims cold review caught
Round-2 fixes. Two independent cold reviews (a fresh Opus agent and a
cross-family Codex pass) agreed on the first finding; I re-verified every
one against the v1.27.1 source before changing anything.

The real defect — the stated MECHANISM for `creator: null` was wrong, and it
was labelled "re-derivable", which is the worst combination. It said null
means `CreatorID == 0`. It does not: an Actions job authenticates as the
synthetic Actions user `ActionsUserID = -2`, `NewCommitStatus` stores
`CreatorID = Creator.ID`, so the `if status.CreatorID != 0` branch is TAKEN.
The null comes from the next line — `GetUserByID(-2)` is a bare lookup with no
system-user mapping (contrast `GetPossibleUserByID`, which handles `id < 0`),
it misses, the error is discarded, and `ToUser(ctx, nil, nil)` returns nil.
The MEASUREMENT was right; only the explanation was wrong, which is exactly
the shape #881 is about. Carries the consequence the wrong version hid: null
means "no user row resolved", not "a machine wrote this" — a deleted author is
indistinguishable, which is safe here only because the test fires on a
POSITIVE allow-list match.

Overclaims, each narrowed to what the evidence supports:

- "the last load-bearing 1.25.4-dated claim" — false; the fence's
  `pull_request_target` half is load-bearing and still dated.
- the `notifier_helper.go` read discharges DEFINITION RESOLUTION only. It says
  nothing about event `types` or secrets availability, so those halves stay
  scratch-PR-attested on 1.25.4.
- "no agent-side cancel route" now scoped to the REST surface; `api.go` cannot
  speak for the web UI or the runner protocol.
- "#869 finished the sweep" — it swept and re-established most of it; three
  findings stay dated by decision.
- "two different commits by construction" -> two SEPARATELY RESOLVED refs;
  nothing forbids them resolving equal.

And the one I am least comfortable with, now stated honestly: the reason given
for not re-probing MCP `cancel_run` was invented. I wrote "there is no
disposable run to spend", which is false — four of six workflows carry
`workflow_dispatch:` (renovate's defaults to `dryRun: full`), and the record
itself says `dispatch_workflow` still works. It was also self-refuting, since
the REST half was probed by observing a 404, which cancels nothing. The true
reason is that the agent harness refused the call, and that is what the record
now says. Removing that false reason also made two neighbours stale, and both
are fixed in the same commit.

Refs #869
Refs #893

Decisions-Edit: yes
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Whe75djeAEuZpdNk6KU7No
2026-09-02 20:10:20 +02:00
..