timothyandClaude Fable 5
ad7e151565
RerunCollectionRequestMapping.ResolveSelection builds an id-only VM with no existence check, so CreateRerunCollectionHandler and UpdateRerunCollectionHandler blindly copied CollectionId / MultiCollectionId / SmartCollectionId / MediaItemId from the request onto the RerunCollection FK columns. A bad id persisted a dangling FK or 500'd at SaveChanges. Add RerunCollectionSelectionValidation, a shared per-CollectionType existence check (Collection/MultiCollection/SmartCollection sets, and subtype-accurate media-item sets: Shows/Seasons/Artists/Movies/ Episodes/MusicVideos/OtherVideos/Songs/Images/RemoteStreams), composed into both handlers' Validate via the existing .Apply(...) pattern so a missing/mismatched id now fails validation (422) with a clear message instead of persisting or 500ing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
72 lines
2.9 KiB
C#
72 lines
2.9 KiB
C#
using ErsatzTV.Core;
|
|
using ErsatzTV.Core.Domain;
|
|
using ErsatzTV.Infrastructure.Data;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using static ErsatzTV.Application.MediaCollections.Mapper;
|
|
|
|
namespace ErsatzTV.Application.MediaCollections;
|
|
|
|
public class CreateRerunCollectionHandler(IDbContextFactory<TvContext> dbContextFactory) :
|
|
IRequestHandler<CreateRerunCollection, Either<BaseError, RerunCollectionViewModel>>
|
|
{
|
|
public async Task<Either<BaseError, RerunCollectionViewModel>> Handle(
|
|
CreateRerunCollection request,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
await using TvContext dbContext = await dbContextFactory.CreateDbContextAsync(cancellationToken);
|
|
Validation<BaseError, RerunCollection> validation = await Validate(dbContext, request, cancellationToken);
|
|
return await validation.Apply(c => PersistCollection(dbContext, c));
|
|
}
|
|
|
|
private static async Task<RerunCollectionViewModel> PersistCollection(
|
|
TvContext dbContext,
|
|
RerunCollection collection)
|
|
{
|
|
await dbContext.RerunCollections.AddAsync(collection);
|
|
await dbContext.SaveChangesAsync();
|
|
return ProjectToViewModel(collection);
|
|
}
|
|
|
|
private static async Task<Validation<BaseError, RerunCollection>> Validate(
|
|
TvContext dbContext,
|
|
CreateRerunCollection request,
|
|
CancellationToken cancellationToken) =>
|
|
(await ValidateName(dbContext, request),
|
|
await RerunCollectionSelectionValidation.SelectedEntityMustExist(
|
|
dbContext,
|
|
request.CollectionType,
|
|
request.Collection?.Id,
|
|
request.MultiCollection?.Id,
|
|
request.SmartCollection?.Id,
|
|
request.MediaItem?.MediaItemId,
|
|
cancellationToken))
|
|
.Apply((name, _) => new RerunCollection
|
|
{
|
|
Name = name,
|
|
CollectionType = request.CollectionType,
|
|
CollectionId = request.Collection?.Id,
|
|
MultiCollectionId = request.MultiCollection?.Id,
|
|
SmartCollectionId = request.SmartCollection?.Id,
|
|
MediaItemId = request.MediaItem?.MediaItemId,
|
|
FirstRunPlaybackOrder = request.FirstRunPlaybackOrder,
|
|
RerunPlaybackOrder = request.RerunPlaybackOrder
|
|
});
|
|
|
|
private static async Task<Validation<BaseError, string>> ValidateName(
|
|
TvContext dbContext,
|
|
CreateRerunCollection createCollection)
|
|
{
|
|
Validation<BaseError, string> result1 = createCollection.NotEmpty(c => c.Name)
|
|
.Bind(_ => createCollection.NotLongerThan(50)(c => c.Name));
|
|
|
|
bool duplicateName = await dbContext.RerunCollections
|
|
.AnyAsync(c => c.Name == createCollection.Name);
|
|
|
|
Validation<BaseError, Unit> result2 = duplicateName
|
|
? Fail<BaseError, Unit>("Rerun collection name must be unique")
|
|
: Success<BaseError, Unit>(Unit.Default);
|
|
|
|
return (result1, result2).Apply((_, _) => createCollection.Name);
|
|
}
|
|
}
|