Build ErsatzTV Image / Docs update reminder (pull_request) Successful in 6s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Failing after 18m17s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Failing after 18m41s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been cancelled
Backend mutation-hardening cluster from the 2026-07-11 mutation-safety audit sweep (adversarial-reviewer #22/#23), the parallel-safe backend-isolated slice. audit#22 F4 — standardize post-commit enqueues on CancellationToken.None: 20 command handlers under MediaCollections/, ProgramSchedules/, Playouts/, Channels/ threaded the request cancellationToken into work that runs AFTER SaveChangesAsync commits (WriteAsync rebuild/refresh enqueues, mediator.Publish, reindex, cache Refresh, and post-commit lookups that gate an enqueue). A late client-disconnect then turns an already-durable commit into a thrown request AND drops the side effect. Generalizes the #251 deco-handler fix. Excludes BuildPlayoutHandler (worker/background token, not a client-disconnect token), the config/FFmpeg multi-upsert handlers (partial-commit case, separate follow-up), and response-projection reloads (correctly keep the request token). audit#22 F2 — DeleteChannelHandler/DeletePlayoutHandler now delete the channel guide {number}.xml through IFileSystem.File.Delete (observable under MockFileSystem) and BEFORE the commit (a post-commit delete orphans the xml on a crash; the xml is regenerable on demand, so pre-commit delete is the safe order). audit#23 F4 — ReplacePlayoutAlternateScheduleItemsHandler rejects an empty item list in the handler (not only the controller pre-guard) so a direct caller can't trip the Max()-on-empty crash. Docs: api-conventions.md §7a (post-commit token convention + boundaries), decisions.md entry (rationale, sweep scope, #253 PR2-4 coordination note). Tests: guide-cache-delete-through-FS for both delete handlers, empty-list guard. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
101 lines
4.2 KiB
C#
101 lines
4.2 KiB
C#
using System.CommandLine.Parsing;
|
|
using System.IO.Abstractions;
|
|
using System.Threading.Channels;
|
|
using ErsatzTV.Application.Channels;
|
|
using ErsatzTV.Core;
|
|
using ErsatzTV.Core.Domain;
|
|
using ErsatzTV.Core.Interfaces.Metadata;
|
|
using ErsatzTV.Core.Scheduling;
|
|
using ErsatzTV.Infrastructure.Data;
|
|
using ErsatzTV.Infrastructure.Extensions;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using Channel = ErsatzTV.Core.Domain.Channel;
|
|
|
|
namespace ErsatzTV.Application.Playouts;
|
|
|
|
public class CreateScriptedPlayoutHandler(
|
|
IFileSystem fileSystem,
|
|
ChannelWriter<IBackgroundServiceRequest> channel,
|
|
IDbContextFactory<TvContext> dbContextFactory)
|
|
: IRequestHandler<CreateScriptedPlayout, Either<BaseError, CreatePlayoutResponse>>
|
|
{
|
|
public async Task<Either<BaseError, CreatePlayoutResponse>> Handle(
|
|
CreateScriptedPlayout request,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
await using TvContext dbContext = await dbContextFactory.CreateDbContextAsync(cancellationToken);
|
|
Validation<BaseError, Playout> validation = await Validate(dbContext, request, cancellationToken);
|
|
return await validation.Apply(playout => PersistPlayout(dbContext, playout, cancellationToken));
|
|
}
|
|
|
|
private async Task<CreatePlayoutResponse> PersistPlayout(
|
|
TvContext dbContext,
|
|
Playout playout,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
await dbContext.Playouts.AddAsync(playout, cancellationToken);
|
|
await dbContext.SaveChangesAsync(cancellationToken);
|
|
|
|
// post-commit side effect runs on CancellationToken.None so a late request cancellation
|
|
// can't abort it after the commit landed (#254)
|
|
await channel.WriteAsync(new BuildPlayout(playout.Id, PlayoutBuildMode.Reset), CancellationToken.None);
|
|
if (playout.Channel.PlayoutMode is ChannelPlayoutMode.OnDemand)
|
|
{
|
|
await channel.WriteAsync(
|
|
new TimeShiftOnDemandPlayout(playout.Id, DateTimeOffset.Now, false),
|
|
CancellationToken.None);
|
|
}
|
|
|
|
await channel.WriteAsync(new RefreshChannelList(), CancellationToken.None);
|
|
return new CreatePlayoutResponse(playout.Id);
|
|
}
|
|
|
|
private async Task<Validation<BaseError, Playout>> Validate(
|
|
TvContext dbContext,
|
|
CreateScriptedPlayout request,
|
|
CancellationToken cancellationToken) =>
|
|
(await ValidateChannel(dbContext, request, cancellationToken), ValidateScheduleFile(request),
|
|
ValidateScheduleKind(request))
|
|
.Apply((channel, yamlFile, scheduleKind) => new Playout
|
|
{
|
|
ChannelId = channel.Id,
|
|
ScheduleFile = yamlFile,
|
|
ScheduleKind = scheduleKind,
|
|
Seed = new Random().Next()
|
|
});
|
|
|
|
private static Task<Validation<BaseError, Channel>> ValidateChannel(
|
|
TvContext dbContext,
|
|
CreateScriptedPlayout createScriptedPlayout,
|
|
CancellationToken cancellationToken) =>
|
|
dbContext.Channels
|
|
.Include(c => c.Playouts)
|
|
.SelectOneAsync(c => c.Id, c => c.Id == createScriptedPlayout.ChannelId, cancellationToken)
|
|
.Map(o => o.ToValidation<BaseError>("Channel does not exist"))
|
|
.BindT(ChannelMustNotHavePlayouts);
|
|
|
|
private static Validation<BaseError, Channel> ChannelMustNotHavePlayouts(Channel channel) =>
|
|
Optional(channel.Playouts.Count)
|
|
.Filter(count => count == 0)
|
|
.Map(_ => channel)
|
|
.ToValidation<BaseError>("Channel already has one playout");
|
|
|
|
private Validation<BaseError, string> ValidateScheduleFile(CreateScriptedPlayout request)
|
|
{
|
|
var args = CommandLineParser.SplitCommandLine(request.ScheduleFile).ToList();
|
|
string scriptFile = args[0];
|
|
if (!fileSystem.File.Exists(scriptFile))
|
|
{
|
|
return BaseError.New("Scripted schedule does not exist!");
|
|
}
|
|
|
|
return request.ScheduleFile;
|
|
}
|
|
|
|
private static Validation<BaseError, PlayoutScheduleKind> ValidateScheduleKind(
|
|
CreateScriptedPlayout createScriptedPlayout) =>
|
|
Optional(createScriptedPlayout.ScheduleKind)
|
|
.Filter(scheduleKind => scheduleKind == PlayoutScheduleKind.Scripted)
|
|
.ToValidation<BaseError>("[ScheduleKind] must be Scripted");
|
|
}
|