Build ErsatzTV Image / Docs update reminder (pull_request) Successful in 7s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Failing after 40s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 4m2s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
Independent Codex review of #268 found two Blockers the fork missed + two Mediums: - Blocker: replace PUTs returned the handler's item snapshot but re-queried the root for the ETag separately, so a racing writer could pair stale items with a newer ETag (silent overwrite). All four controllers now reload root-then-items (version-first, fail-safe) and 404 when the root is gone between commit and reload — matching the Block reference. Fixes the Blocker + the Medium '200 without ETag' case together. - Blocker: PlaylistsScreen loaded items+root via Promise.all (concurrent), pairing a stale name with the current ETag; now sequential (items-with-meta first, then root). - Medium: SchedulesScreen loadItems now marks not-loaded/loading up front so canEdit is false through the 412 conflict reload (no stale-draft edits lost). Controller unit-test mocks updated to stub the new reload query. Full suite green (ErsatzTV.Tests 1334, web 667, check:api no drift).
218 lines
11 KiB
C#
218 lines
11 KiB
C#
using System.ComponentModel.DataAnnotations;
|
|
using System.Linq;
|
|
using ErsatzTV.Application.ProgramSchedules;
|
|
using ErsatzTV.Controllers.Api.Requests;
|
|
using ErsatzTV.Core;
|
|
using ErsatzTV.Core.Api.Scheduling;
|
|
using ErsatzTV.Extensions;
|
|
using MediatR;
|
|
using Microsoft.AspNetCore.Http;
|
|
using Microsoft.AspNetCore.Mvc;
|
|
|
|
namespace ErsatzTV.Controllers.Api;
|
|
|
|
[ApiController]
|
|
public class ScheduleController(IMediator mediator) : ControllerBase
|
|
{
|
|
[HttpGet("/api/schedules")]
|
|
[Tags("Schedules")]
|
|
[EndpointSummary("Get all schedules")]
|
|
[EndpointGroupName("general")]
|
|
[ProducesResponseType(typeof(List<ProgramScheduleViewModel>), StatusCodes.Status200OK)]
|
|
public async Task<List<ProgramScheduleViewModel>> GetAll(CancellationToken cancellationToken) =>
|
|
await mediator.Send(new GetAllProgramSchedules(), cancellationToken);
|
|
|
|
[HttpGet("/api/schedules/{id:int}", Name = "GetScheduleById")]
|
|
[Tags("Schedules")]
|
|
[EndpointSummary("Get a schedule by id")]
|
|
[EndpointGroupName("general")]
|
|
[ProducesResponseType(typeof(ProgramScheduleViewModel), StatusCodes.Status200OK)]
|
|
[ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status404NotFound)]
|
|
public async Task<IActionResult> GetById(int id, CancellationToken cancellationToken)
|
|
{
|
|
Option<ProgramScheduleViewModel> result = await mediator.Send(new GetProgramScheduleById(id), cancellationToken);
|
|
return result.ToGetResult();
|
|
}
|
|
|
|
[HttpPost("/api/schedules")]
|
|
[Tags("Schedules")]
|
|
[EndpointSummary("Create a schedule")]
|
|
[EndpointGroupName("general")]
|
|
[ProducesResponseType(typeof(ProgramScheduleViewModel), StatusCodes.Status201Created)]
|
|
[ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status404NotFound)]
|
|
[ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status422UnprocessableEntity)]
|
|
public async Task<IActionResult> Create(
|
|
[Required] [FromBody] CreateScheduleRequest request,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
Either<BaseError, CreateProgramScheduleResult> result =
|
|
await mediator.Send(request.ToCreateCommand(), cancellationToken);
|
|
return await result.Match(
|
|
Left: error => Task.FromResult(error.ToErrorResult()),
|
|
Right: async created =>
|
|
{
|
|
Option<ProgramScheduleViewModel> schedule =
|
|
await mediator.Send(new GetProgramScheduleById(created.ProgramScheduleId), cancellationToken);
|
|
return schedule.Match(
|
|
Some: vm => (IActionResult)new CreatedResult($"/api/schedules/{vm.Id}", vm),
|
|
None: () => ApiResults.NotFoundProblem());
|
|
});
|
|
}
|
|
|
|
[HttpPut("/api/schedules/{id:int}")]
|
|
[Tags("Schedules")]
|
|
[EndpointSummary("Update a schedule")]
|
|
[EndpointGroupName("general")]
|
|
[ProducesResponseType(typeof(ProgramScheduleViewModel), StatusCodes.Status200OK)]
|
|
[ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status404NotFound)]
|
|
[ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status422UnprocessableEntity)]
|
|
public async Task<IActionResult> Update(
|
|
int id,
|
|
[Required] [FromBody] UpdateScheduleRequest request,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
Either<BaseError, UpdateProgramScheduleResult> result =
|
|
await mediator.Send(request.ToCommand(id), cancellationToken);
|
|
return await result.Match(
|
|
Left: error => Task.FromResult(error.ToErrorResult()),
|
|
Right: async _ =>
|
|
{
|
|
Option<ProgramScheduleViewModel> schedule =
|
|
await mediator.Send(new GetProgramScheduleById(id), cancellationToken);
|
|
return schedule.Match(
|
|
Some: vm => (IActionResult)new OkObjectResult(vm),
|
|
None: () => ApiResults.NotFoundProblem());
|
|
});
|
|
}
|
|
|
|
[HttpDelete("/api/schedules/{id:int}")]
|
|
[Tags("Schedules")]
|
|
[EndpointSummary("Delete a schedule")]
|
|
[EndpointGroupName("general")]
|
|
[ProducesResponseType(StatusCodes.Status204NoContent)]
|
|
[ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status404NotFound)]
|
|
[ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status422UnprocessableEntity)]
|
|
public async Task<IActionResult> Delete(int id, CancellationToken cancellationToken)
|
|
{
|
|
Either<BaseError, Unit> result = await mediator.Send(new DeleteProgramSchedule(id), cancellationToken);
|
|
return result.ToDeletedResult();
|
|
}
|
|
|
|
[HttpGet("/api/schedules/{id:int}/items")]
|
|
[Tags("Schedules")]
|
|
[EndpointSummary("Get schedule items")]
|
|
[EndpointDescription(
|
|
"Returns the schedule's items plus a computed, best-effort runtime estimate: each item carries a " +
|
|
"nullable durationEstimate and the envelope carries a nullable totalDurationEstimate. Estimates are " +
|
|
"derived from referenced collection/media runtimes and are null when unbounded or unknown. The " +
|
|
"response also carries a strong ETag of the schedule's version; pass that ETag back as If-Match on " +
|
|
"the replace (PUT) to detect a concurrent edit (issue #253).")]
|
|
[EndpointGroupName("general")]
|
|
[ProducesResponseType(typeof(ScheduleItemsResponseModel), StatusCodes.Status200OK)]
|
|
[ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status404NotFound)]
|
|
public async Task<IActionResult> GetItems(int id, CancellationToken cancellationToken)
|
|
{
|
|
Option<ProgramScheduleViewModel> schedule = await mediator.Send(new GetProgramScheduleById(id), cancellationToken);
|
|
if (schedule.IsNone)
|
|
{
|
|
return ApiResults.NotFoundProblem();
|
|
}
|
|
|
|
// The items GET returns children, not the root, so read the schedule's version for the ETag.
|
|
ConcurrencyHeaders.SetETag(Response, schedule.Map(s => s.Version).IfNone(0));
|
|
|
|
ProgramScheduleItemsWithDurationViewModel items =
|
|
await mediator.Send(new GetProgramScheduleItemsWithDurations(id), cancellationToken);
|
|
return new OkObjectResult(ScheduleItemResponseMapper.ProjectToResponseModel(items));
|
|
}
|
|
|
|
[HttpPost("/api/schedules/{id:int}/items")]
|
|
[Tags("Schedules")]
|
|
[EndpointSummary("Add a schedule item")]
|
|
[EndpointGroupName("general")]
|
|
[ProducesResponseType(typeof(ScheduleItemResponseModel), StatusCodes.Status201Created)]
|
|
[ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status404NotFound)]
|
|
[ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status422UnprocessableEntity)]
|
|
public async Task<IActionResult> AddItem(
|
|
int id,
|
|
[Required] [FromBody] ScheduleItemRequest request,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
Either<BaseError, ProgramScheduleItemViewModel> result =
|
|
await mediator.Send(request.ToAddCommand(id), cancellationToken);
|
|
return result.ToCreatedResult(
|
|
item => $"/api/schedules/{id}/items/{item.Id}",
|
|
item => ScheduleItemResponseMapper.ProjectToResponseModel(item));
|
|
}
|
|
|
|
[HttpPut("/api/schedules/{id:int}/items")]
|
|
[Tags("Schedules")]
|
|
[EndpointSummary("Replace schedule items")]
|
|
[EndpointDescription(
|
|
"Replaces the schedule's full item list; item indexes are assigned from the array order. Send the " +
|
|
"ETag from the items GET as If-Match to reject a stale overwrite with 412 (issue #253); a successful " +
|
|
"response carries the new ETag.")]
|
|
[EndpointGroupName("general")]
|
|
[ProducesResponseType(typeof(List<ScheduleItemResponseModel>), StatusCodes.Status200OK)]
|
|
[ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status400BadRequest)]
|
|
[ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status404NotFound)]
|
|
[ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status412PreconditionFailed)]
|
|
[ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status422UnprocessableEntity)]
|
|
public async Task<IActionResult> ReplaceItems(
|
|
int id,
|
|
[Required] [FromBody] ReplaceScheduleItemsRequest request,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
IfMatchCondition ifMatch = ConcurrencyHeaders.ParseIfMatch(Request);
|
|
if (ifMatch.Kind is IfMatchKind.Malformed)
|
|
{
|
|
return new BadRequestObjectResult(
|
|
new ProblemDetails
|
|
{
|
|
Status = StatusCodes.Status400BadRequest,
|
|
Title = "Invalid If-Match header",
|
|
Detail = "If-Match must be a strong ETag of the resource version (e.g. \"3\") or \"*\"."
|
|
});
|
|
}
|
|
|
|
Either<BaseError, IEnumerable<ProgramScheduleItemViewModel>> result =
|
|
await mediator.Send(request.ToCommand(id, ifMatch.ExpectedVersion), cancellationToken);
|
|
|
|
return await result.Match(
|
|
Left: error => Task.FromResult(error.ToErrorResult()),
|
|
Right: async _ =>
|
|
{
|
|
// Reload the root (version) FIRST, then the items, so the emitted ETag is never newer than
|
|
// the returned items (issue #253 fail-safe ordering; matches BlockController). A None root
|
|
// (deleted between commit and reload) is a 404, never a 200 without an ETag.
|
|
Option<ProgramScheduleViewModel> refreshed =
|
|
await mediator.Send(new GetProgramScheduleById(id), cancellationToken);
|
|
List<ProgramScheduleItemViewModel> items =
|
|
await mediator.Send(new GetProgramScheduleItems(id), cancellationToken);
|
|
return refreshed.Match(
|
|
Some: vm =>
|
|
{
|
|
// Return the new ETag so a same-tab second save doesn't 412 against its own write.
|
|
ConcurrencyHeaders.SetETag(Response, vm.Version);
|
|
return (IActionResult)new OkObjectResult(
|
|
items.Select(ScheduleItemResponseMapper.ProjectToResponseModel).ToList());
|
|
},
|
|
None: () => ApiResults.NotFoundProblem());
|
|
});
|
|
}
|
|
|
|
[HttpDelete("/api/schedules/{id:int}/items/{itemId:int}")]
|
|
[Tags("Schedules")]
|
|
[EndpointSummary("Delete a schedule item")]
|
|
[EndpointGroupName("general")]
|
|
[ProducesResponseType(StatusCodes.Status204NoContent)]
|
|
[ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status404NotFound)]
|
|
[ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status422UnprocessableEntity)]
|
|
public async Task<IActionResult> DeleteItem(int id, int itemId, CancellationToken cancellationToken)
|
|
{
|
|
Either<BaseError, Unit> result =
|
|
await mediator.Send(new DeleteProgramScheduleItem(id, itemId), cancellationToken);
|
|
return result.ToDeletedResult();
|
|
}
|
|
}
|