timothy 7ed0a59c56 test(649): cold-review fixes — the never-overwrite test skipped the case its docstring called sharpest ...

Four gaps, all found by mutation rather than reading.

The never-overwrite test used only a NON-EXEMPT file list, so "an exemption posted over a human
BLOCKED verdict" — the scenario its own docstring named as the sharp one — was asserted nowhere.
Moving the short-circuit to after classification, gated on non-exempt, survived the whole suite
while turning a human rejection into a green required status for both a docs-only PR and a bot PR.
Now parametrised over non-exempt, docs-only-exempt and bot-exempt file lists.

The structural emptiness pin is REPLACED by a real jq-1.6 behavioural test. Its stated
justification — "no behavioural test can catch this on a dev machine" — was simply false: this
file already imports _JQ16_SHIM for pr-changed-files.sh, so the runner's quirk is reproducible
here. The structural version was also weaker than it looked, stripping only FULL-LINE comments, so
leaving the literal as a trailing comment on the surviving guard satisfied it while the real check
was gone. The behavioural test catches that mutant and needs no comment-stripping.

The status-read stub now returns DECOY contexts either side of the verdict row, so dropping
`select(.context == $c)` is caught. First attempt gave the decoys `status: success`, which triggers
the same short-circuit as a real verdict — the mutation still produced an identical outcome and
survived. `pending` decoys make mis-selection observable.

DOCS_ONLY's `^` anchor is now covered alongside its `$`: losing it exempts ErsatzTV/docs/Evil.cs,
a C# file, and is fail-OPEN.

Two remaining survivors are documented in-file as behaviourally equivalent, not gaps: `first` ->
`last` (the combined endpoint returns one row per context by contract, so a two-row fixture would
test a fiction), and the garbage-response test defending the type guard only by redundancy.

2026-07-27 08:01:36 +02:00

..

fixtures

feat(610): split the decision corpus into one YAML-frontmatter file per record

2026-07-25 19:45:09 +02:00

__init__.py

feat(521): decision-record parser (decisions_lib)

2026-07-21 02:58:58 +02:00

test_build_catalog.py

fix(603): close four defects found in adversarial review of the stale-after fields

2026-07-25 15:22:50 +02:00

test_check_review_verdict.py

fix(629): strip raw HTML blocks, and state where the hardening stops

2026-07-26 01:14:59 +02:00

test_decisions_lib.py

fix(610): make the frontmatter READ path dependency-free — CI has no PyYAML

2026-07-25 19:57:22 +02:00

test_decisions_validate.py

fix(620): signal corpus size per RECORD; the aggregate becomes an unthresholded trend

2026-07-26 13:57:01 +02:00

test_jq_preflight.py

test(648): close the mutation gaps round 5 found — two tests passed for the wrong reason

2026-07-26 22:21:07 +02:00

test_merge_consent_base_change.py

fix(632): validate status ROWS, not just the top-level array — the same swallow one level down

2026-07-26 23:38:14 +02:00

test_merge_consent_exemption.py

fix(647): the jq-1.6 fail-open was ALSO in review-verdict.yml — the enforced gate

2026-07-26 13:24:20 +02:00

test_migration_equivalence.py

feat(610): split the decision corpus into one YAML-frontmatter file per record

2026-07-25 19:45:09 +02:00

test_post_review_verdict.py

fix(632): fail closed when the head/base re-read itself fails

2026-07-26 23:16:35 +02:00

test_pr_changed_files.py

test(649): cold-review fixes — the never-overwrite test skipped the case its docstring called sharpest

2026-07-27 08:01:36 +02:00