Files
ersatztv/web/src/api/decoTemplates.test.ts
T
timothyandClaude Opus 4.8 ef2bd65c27
Build ErsatzTV Image / decisions.md append-only (pull_request) Successful in 10s
Build ErsatzTV Image / Docs update reminder (pull_request) Successful in 10s
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 1m12s
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 3m4s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 8m17s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 10m36s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
feat(api): #286 — mount the whole /api surface at /api/v1
Version every /api route to /api/v1 (251 controller routes + ~24 Location
headers + the scanner callback URL + the Startup request-log literal),
uniform across the machine API, auth, scanner and scripted-build surfaces.

Add ApiVersionRewriteMiddleware: a legacy unversioned /api/* request is
rewritten (NOT redirected) to /api/v1/* in-pipeline — method, body, auth
headers and query survive — carrying RFC 8594 Deprecation/Sunset headers,
so curl / the future MCP server / bookmarks keep working. An already-
versioned path passes through; a future /api/v2 is never forced to v1.

Standardize the route convention (leading-slash absolute route per method,
no class-[Route] — except the two Scanner/Scripted controllers whose ~all
actions share a parametrized {id} prefix), enforced by ApiRouteVersioningTests
(^/api/v\d+/ over the whole Controllers.Api surface; browser-nav
/auth/oidc/login is out of scope).

Regenerate v1.json (160 paths, all /api/v1)/endpoint-index/v1.d.ts; sweep 945
SPA request literals + the test mocks (regex + positional URL parsers). /api/v1
is additive-only after freeze; the legacy-rewrite shim sunsets in ~2 releases
(owner decision) with removal tracked as a Phase-3 follow-up.

Docs: decisions.md 2026-07-13, api-conventions §1/§9, rest-api/spa-conventions/
blazor-route-parity/e2e-local/domain-model.

fixes #286
refs #197

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-13 00:30:20 +02:00

113 lines
4.4 KiB
TypeScript

import { beforeEach, describe, expect, it, vi } from 'vitest';
import {
createDecoTemplate,
createDecoTemplateGroup,
deleteDecoTemplate,
deleteDecoTemplateGroup,
getDecoTemplate,
getDecoTemplateGroups,
getDecoTemplateItems,
getDecoTemplates,
replaceDecoTemplate,
type ReplaceDecoTemplateRequest
} from './decoTemplates';
function jsonResponse(body: unknown, status = 200): Response {
return new Response(JSON.stringify(body), { headers: { 'Content-Type': 'application/json' }, status });
}
function noContent(): Response {
return new Response(null, { status: 204 });
}
const sampleReplace: ReplaceDecoTemplateRequest = {
name: 'Weekdays',
items: [{ decoId: 10, startTime: '06:00:00', endTime: '07:00:00' }]
};
describe('decoTemplates api client', () => {
beforeEach(() => {
window.localStorage.clear();
vi.restoreAllMocks();
});
it('getDecoTemplateGroups fetches all deco template groups', async () => {
const fetchMock = vi
.spyOn(window, 'fetch')
.mockResolvedValue(jsonResponse([{ id: 1, name: 'Weekday', decoTemplateCount: 2 }]));
await expect(getDecoTemplateGroups()).resolves.toHaveLength(1);
expect(fetchMock).toHaveBeenCalledWith(
'/api/v1/deco-templates/groups',
expect.objectContaining({ method: 'GET' })
);
});
it('createDecoTemplateGroup POSTs the name', async () => {
const fetchMock = vi
.spyOn(window, 'fetch')
.mockResolvedValue(jsonResponse({ id: 3, name: 'Weekday', decoTemplateCount: 0 }, 201));
await createDecoTemplateGroup({ name: 'Weekday' });
const [url, init] = fetchMock.mock.calls[0];
expect(url).toBe('/api/v1/deco-templates/groups');
expect(init).toMatchObject({ method: 'POST' });
expect(JSON.parse(String(init?.body)).name).toBe('Weekday');
});
it('deleteDecoTemplateGroup DELETEs by id', async () => {
const fetchMock = vi.spyOn(window, 'fetch').mockResolvedValue(noContent());
await expect(deleteDecoTemplateGroup(3)).resolves.toBeUndefined();
expect(fetchMock).toHaveBeenCalledWith(
'/api/v1/deco-templates/groups/3',
expect.objectContaining({ method: 'DELETE' })
);
});
it('getDecoTemplates fetches all deco templates', async () => {
const fetchMock = vi.spyOn(window, 'fetch').mockResolvedValue(jsonResponse([]));
await getDecoTemplates();
expect(fetchMock).toHaveBeenCalledWith('/api/v1/deco-templates', expect.objectContaining({ method: 'GET' }));
});
it('getDecoTemplate fetches a deco template by id', async () => {
const fetchMock = vi.spyOn(window, 'fetch').mockResolvedValue(jsonResponse({ id: 4 }));
await getDecoTemplate(4);
expect(fetchMock).toHaveBeenCalledWith('/api/v1/deco-templates/4', expect.objectContaining({ method: 'GET' }));
});
it('createDecoTemplate POSTs group id and name', async () => {
const fetchMock = vi.spyOn(window, 'fetch').mockResolvedValue(jsonResponse({ id: 8 }, 201));
await createDecoTemplate({ decoTemplateGroupId: 2, name: 'Weekdays' });
const [url, init] = fetchMock.mock.calls[0];
expect(url).toBe('/api/v1/deco-templates');
expect(init).toMatchObject({ method: 'POST' });
expect(JSON.parse(String(init?.body))).toMatchObject({ decoTemplateGroupId: 2, name: 'Weekdays' });
});
it('deleteDecoTemplate DELETEs by id', async () => {
const fetchMock = vi.spyOn(window, 'fetch').mockResolvedValue(noContent());
await deleteDecoTemplate(4);
expect(fetchMock).toHaveBeenCalledWith('/api/v1/deco-templates/4', expect.objectContaining({ method: 'DELETE' }));
});
it('getDecoTemplateItems fetches items for a deco template', async () => {
const fetchMock = vi.spyOn(window, 'fetch').mockResolvedValue(jsonResponse([]));
await getDecoTemplateItems(4);
expect(fetchMock).toHaveBeenCalledWith(
'/api/v1/deco-templates/4/items',
expect.objectContaining({ method: 'GET' })
);
});
it('replaceDecoTemplate PUTs the full deco template body', async () => {
const fetchMock = vi.spyOn(window, 'fetch').mockResolvedValue(jsonResponse({ id: 4, items: [] }));
await replaceDecoTemplate(4, sampleReplace);
const [url, init] = fetchMock.mock.calls[0];
expect(url).toBe('/api/v1/deco-templates/4');
expect(init).toMatchObject({ method: 'PUT' });
const body = JSON.parse(String(init?.body));
expect(body.name).toBe('Weekdays');
expect(body.items).toHaveLength(1);
expect(body.items[0]).toMatchObject({ decoId: 10, startTime: '06:00:00', endTime: '07:00:00' });
});
});