Files
ersatztv/web/vite-plugins/trackedSourceFiles.realgit.test.ts
T
timothyandtimothy 8aeacd534a
Build ErsatzTV Image / CI toolchain image resolves (push) Successful in 9s
Build ErsatzTV Image / Delimiter ban (release path) (push) Successful in 21s
Build ErsatzTV Image / Build & test (.NET) (push) Successful in 8m52s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (push) Successful in 6m23s
Build ErsatzTV Image / Functional E2E (curl + UI contracts) (push) Successful in 5m50s
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (push) Skipped
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (push) Skipped
Build ErsatzTV Image / Build & push image (amd64) (push) Successful in 5m5s
fix(819): derive the SPA page-size guard population from the git index (#875)
The guard asserted EXACT completeness over a population enumerated by a directory
walk, so an untracked .ts/.tsx under web/src/ entered it and failed as unregistered
on that developer's checkout while CI — which only ever checks out tracked files —
stayed green.

The glob still supplies file CONTENT; the POPULATION is now the git index, read by
web/vite-plugins/trackedSourceFiles.ts in Vite's own Node context and handed to the
app project as a virtual module. That reaches the index without admitting
@types/node to tsconfig.app.json, the obstacle that deferred this in #818.

Three mechanisms carry the proof, each added because the previous was measured
insufficient: a closed-form restatement of the shared scope predicate (sharing no
helper at any depth with what it checks); a second independent `ls-files --others`
query cross-checking the population; and real-git tests that execute the derivation
against a temp repository.

Six residuals are stated with their MEASURED fail-directions, and
testing.guard-derives-population-from-source gains a bounded exception plus the
closed-form criterion.

fixes #819

Co-authored-by: Timothy <timothy@noreply.gitea.tblindustries.be>
2026-08-29 09:14:15 +00:00

98 lines
5.0 KiB
TypeScript

import { execFileSync } from 'node:child_process';
import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from 'node:fs';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterAll, describe, expect, it } from 'vitest';
import { type GitRunner, resolveTrackedSourceFiles } from './trackedSourceFiles';
/**
* SEPARATE FILE because these are the only tests in the SPA suite that need the `git` BINARY but NO
* CHECKOUT — they build their own repository (ersatztv#819). That is not the same as saying the
* guard needs only a checkout: it needs a checkout AND, through it, the binary. Measured — with
* `.git` present and git off `PATH`, `pageSizeCallSites.guard.test.ts` still fails with the
* plugin's refusal. Reading the two exclusions as checkout-versus-binary is what broke the Docker
* stage once already; see `docker/Dockerfile`, which retracts that framing.
*
* `docker/Dockerfile`'s web-build stage runs on `node:22-bookworm-slim`, which ships no git at all,
* so this file is excluded there alongside the guard. Keeping them apart means
* that exclusion costs two files rather than the thirteen injected-runner tests in
* `trackedSourceFiles.test.ts`, which run fine with no git and no repository.
*
* Do NOT make these skip when git is missing. A check that answers "could not tell" by passing is a
* permanent no-op, which is the whole failure mode this plugin exists to avoid.
*/
describe('resolveTrackedSourceFiles against a REAL repository (#819)', () => {
// Every test in the sibling `trackedSourceFiles.test.ts` injects a fake `GitRunner`, which proves
// the derivation's SHAPE and never that
// it works against git. `scripts/tests/test_guard_populations_derive_from_git.py` makes exactly
// this point about its own primitive — "It proves the mechanism by EXECUTING it rather than by
// recognising its shape — no monkeypatching, no stand-in for git" — and the population this
// plugin feeds is asserted for completeness, so it earns the same treatment.
const repos: string[] = [];
afterAll(() => {
for (const dir of repos) {
rmSync(dir, { recursive: true, force: true });
}
});
function repoWithOneTrackedAndOneUntracked(): string {
const dir = mkdtempSync(join(tmpdir(), 'etv-819-'));
repos.push(dir);
const git = (...args: string[]) => execFileSync('git', ['-C', dir, ...args], { encoding: 'utf8' });
git('init', '-q');
mkdirSync(join(dir, 'src'), { recursive: true });
writeFileSync(join(dir, 'src', 'tracked.ts'), 'export const a = 1;\n');
writeFileSync(join(dir, 'src', 'untracked.ts'), 'export const b = 2;\n');
// STAGED, not committed. `ls-files` reads the INDEX, so a commit adds nothing — and committing
// makes the fixture depend on the developer's global git config: under a `commit.gpgsign = true`
// that many people set, `git commit` fails and these tests go red on their machine while CI
// stays green. That is the very shape #819 exists to remove, so it must not be reintroduced by
// #819's own tests. `git add` is unaffected by signing.
git('add', 'src/tracked.ts');
return dir;
}
it('really separates a tracked file from an identical untracked sibling', () => {
const result = resolveTrackedSourceFiles(repoWithOneTrackedAndOneUntracked());
expect(result.tracked).toEqual(['src/tracked.ts']);
expect(result.others).toEqual(['src/untracked.ts']);
expect(result.absentFromDisk).toEqual([]);
});
it('really reports a tracked file deleted from the working tree as absent', () => {
const dir = repoWithOneTrackedAndOneUntracked();
rmSync(join(dir, 'src', 'tracked.ts'));
const result = resolveTrackedSourceFiles(dir);
expect(result.tracked).toEqual(['src/tracked.ts']);
expect(result.absentFromDisk).toEqual(['src/tracked.ts']);
});
// Residual: this asserts the message the MISSING-BINARY path also emits, so in an environment with
// no git it passes for the wrong reason. Not silent overall — its two siblings fail ENOENT there,
// loudly — and that is exactly the environment this file is excluded from in `docker/Dockerfile`.
it('really throws outside a repository, rather than returning an empty population', () => {
const notARepo = mkdtempSync(join(tmpdir(), 'etv-819-bare-'));
repos.push(notARepo);
mkdirSync(join(notARepo, 'src'), { recursive: true });
// `GIT_CEILING_DIRECTORIES` stops git walking up into an enclosing repository — without it this
// test depends on where TMPDIR happens to point, and reports the wrong throw when TMPDIR sits
// inside a checkout.
const ceiling: GitRunner = (args) =>
execFileSync('git', [...args], {
encoding: 'utf8',
// Same stderr suppression `runGitDefault` sets, for the same reason: without it git's own
// `fatal: not a git repository` prints on every run of this file.
stdio: ['ignore', 'pipe', 'pipe'],
env: { ...process.env, GIT_CEILING_DIRECTORIES: tmpdir() }
});
expect(() => resolveTrackedSourceFiles(notARepo, ceiling)).toThrow(/could not read the git index/);
});
});