timothyandClaude Opus 4.8
928784ba48
PR Gates / CI image pin matches docker/ci (pull_request) Successful in 12s
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 17s
PR Gates / Docs update reminder (pull_request) Successful in 19s
PR Gates / decisions lifecycle (pull_request) Successful in 22s
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 13m44s
Build ErsatzTV Image / Functional E2E (curl contracts) (pull_request) Successful in 17m8s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 20m34s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 20m41s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
CreateChannelFromLineupHandler resolved every advanced override with advanced.X ?? template.X, so null always meant INHERIT and a channel could not drop a template-set watermark / filler / preferred language. Add an optional typed `clear` enum list to CreateChannelFromLineupAdvancedOptions: omitted/null still inherits (byte-stable for existing clients), a field named in `clear` is forced to none. Set+clear of the same field is a 422. The enum (CreateChannelFromLineupClearField) lives in ErsatzTV.Core so the OpenAPI string-enum scan renders it as a string enum, matching every sibling advanced-options enum. Handler resolves clearable fields once via ResolveClearable and validates set/clear conflicts via ValidateClear; reference validation skips existence checks for cleared (null) refs. SPA: the shared advancedOptions model re-adds a real "None" option to the five id selects (watermark + fillers) in both the Channel Builder and the Auto-Tune DetailPanel, routed through a CLEAR overrides sentinel that applyOverridesToRequest folds into advanced.clear (never leaking onto the wire as a field value). The backend enum also covers the preferred audio/subtitle language strings for machine clients; the SPA text inputs keep "empty = inherit" (tri-state deferred). Docs: api-conventions.md §2, spa-conventions.md §11, decisions.md record api.from-lineup-clear-to-none; v1.json + generated TS regenerated. fixes #135 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
21 lines
927 B
C#
21 lines
927 B
C#
namespace ErsatzTV.Core.Api.Channels;
|
|
|
|
// The "clear to none" signal for POST /api/v1/channels/from-lineup (#135). For these
|
|
// template-inheritable advanced fields a null/omitted override means INHERIT the template value;
|
|
// naming the field here forces it to NONE on the new channel even when the template sets one.
|
|
// Omitting the field entirely keeps the historical omitted=inherit behavior stable for existing
|
|
// clients. Sending both a set value and a clear for the same field is a validation error (see
|
|
// CreateChannelFromLineupHandler). Lives in Core so the OpenAPI string-enum scan (Startup
|
|
// UseStringEnumSchemas) renders it as a string enum, matching every sibling advanced-options enum.
|
|
public enum CreateChannelFromLineupClearField
|
|
{
|
|
Watermark,
|
|
FallbackFiller,
|
|
PreRollFiller,
|
|
MidRollFiller,
|
|
PostRollFiller,
|
|
PreferredAudioLanguage,
|
|
PreferredAudioTitle,
|
|
PreferredSubtitleLanguage
|
|
}
|