Files
ersatztv/scripts/tests
timothy 9454be1226 fix(803,664): round 4 — a retraction left standing in four places, and a guard for the rule I broke
Third cold review (isolated Opus reviewer; no cross-family pass this round — Codex hit its
usage limit, stated rather than quietly skipped). It found NOTHING at Blocker or High, and
independently re-verified the green, the guard-inventory summary, jq 1.6's behaviour on the
new predicate, and the live Gitea probes. It confirmed round 2's "four true, one false"
correction. BLOCKED on one Medium and some Lows, all documentation.

MEDIUM — round 2 retracted a claim in one place and left it standing in four. The body of
`ci.verdict-write-retarget-fence` says the no-self-abstain property is established FROM THE
SOURCE and that calling it "a deployment property" was weaker than the truth. The `rule:`
frontmatter, the generated catalog, the workflow comment and `release.verdict-status-check`
all still carried the retracted framing — and the catalog is the DESIGNATED lookup surface,
so resolving the key gave the retracted version and only reading two screens in gave the
retraction. That is precisely the defect this PR's own round 2 named and fixed for the
head-binding overclaim; I swept for that retraction and not for my own. Corrected at every
site, and `release.verdict-status-check`'s residual now names the real one (#870) instead.

LOW — `docs/ci-cd.md` still said `null` is accepted as exhaustion "only from page 2 on", two
sentences after saying both shapes terminate the walk. Round 2 gave `[]` the identical
`page > 1` rule, so singling out `null` now reads as "`[]` is trusted on page 1" — the exact
fail-open round 2 closed. Round 2 edited three other hunks of that file and missed this one.

LOW — the head arm's notice promised unconditionally that a successor run is queued, while
the record names the window where that is false (a PR's first push fires no `synchronize`).
The record's stated detector for that inversion is "the head-fence notice in every run's
log" — the very line that would then be lying. The notice now carries the exception.

LOW — round 3 asserted "`count_pr_mutations` now contains no `jq -e` call" and nothing
guarded it. The rule was broken one commit after being quoted and caught only by hand, so
it now has a test, function-scoped (`jq -e` is legitimate elsewhere in both files) and
comment-stripped so the paragraphs explaining the rule cannot redden it. Mutation-proved
against the REAL predecessor — round 2's actual `jq -e` guard, restored verbatim — not a
hand-written mutant.

NITS — the `trusted-then-unreadable` comment described request-counting when the counter
counts real pages served (a mechanism nobody measured; the arrangement is produced either
way, proved by the mutant log); a dead `or mode == ...` arm re-initialising zeros; a
present-tense reference to the renamed `count_retargets`.

CORRECTED FIGURE — round 2 quoted "page-1-only walk (3 red)" from a `-k` subset. Measured
over the whole file it is 53, because a walk that never reaches a terminator leaves
`rt_ok=no` and withholds EVERY exemption — the #751 shape. The number is fragile and the
invariant is not, so: a page-1-only walk stops the fence trusting anything.

NOT MINE, and verified so rather than assumed: the full suite showed one red in
`test_hook_fire_log.py::test_the_suite_does_not_write_to_the_PRODUCTION_log`. That test
snapshots mtimes in `~/.cache/ersatztv/hook-fire/`, the log every live Claude session on
this machine writes to, and four peer sessions were running. It is already filed as #822
("any concurrent session reddens it"), passes in isolation (78 passed), and passed on the
final run here.

Verification: 1118 passed, 2 skipped; ruff clean; decisions-validate OK; YAML + `bash -n`
clean. No `.cs` touched, so the BOM/format gate does not apply.

Refs #870, #822
Decisions-Edit: yes
2026-08-28 23:22:08 +02:00
..