Files
ersatztv/ErsatzTV.Tests
timothy 9e6d055ee1 docs(690,758): correct three measured details from round 2
Round 2's second reviewer returned MERGEABLE with no correctness defect, and
reproduced the mutation proof rather than trusting it. Three accuracy findings,
each backed by a probe I re-verified against the entity definitions.

The include-chain gap is not one pair, it is all three, and I had named the
wrong link. A REQUIRED reference Include is emitted as an INNER JOIN, so
GetPagedSeasons (Include(s => s.Show)) and GetPagedMusicVideos
(ThenInclude(mv => mv.Artist)) have the identical gap, not just GetPagedEpisodes.
And the link I blamed was inert: Show.ShowMetadata is a List<>, a COLLECTION nav
and therefore a LEFT JOIN, which drops nothing — the reviewer's probe seeds the
full graph minus ShowMetadata and still pages 2 rows. The load-bearing legs are
Season and Show. The test comment and the record both narrated a chain one link
longer than the one that actually filters, and the seeded ShowMetadata row is
incidental; it is now labelled as such rather than presented as the reason the
seed exists.

That distinction is the mechanism, so the record now states it: "an include
filters" is false as a blanket claim and true only of required references.

Frontmatter was still describing the pre-MediaCards change: paths listed six
handlers and one test file, omitting both repositories, the second test fixture
and the two unfiltered handlers, and mechanics named only PagedQueryTotalCountTests
though the record's own point (3) makes the MediaCards test a second enforcement
mode. Retrieval by those signals would have reproduced exactly the name-derived
population this record condemns.

Not changed, with the reason recorded: TelevisionRepository.GetSeasonCount passes
CancellationToken.None because ITelevisionRepository.GetSeasonCount(int) has no
token parameter, so there is nothing to thread. Threading one means an interface
change touching FakeTelevisionRepository for a dead caller. The asymmetry (the
count is uncancellable while its sibling GetPagedSeasons is cancellable, and it
went from 1 round trip to 3) is real and has zero impact while the caller is dead
code; #832 owns the delete-or-keep decision that settles it.
2026-08-26 08:56:02 +02:00
..