Build ErsatzTV Image / Docs update reminder (pull_request) Successful in 6s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Failing after 18m17s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Failing after 18m41s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been cancelled
Backend mutation-hardening cluster from the 2026-07-11 mutation-safety audit sweep (adversarial-reviewer #22/#23), the parallel-safe backend-isolated slice. audit#22 F4 — standardize post-commit enqueues on CancellationToken.None: 20 command handlers under MediaCollections/, ProgramSchedules/, Playouts/, Channels/ threaded the request cancellationToken into work that runs AFTER SaveChangesAsync commits (WriteAsync rebuild/refresh enqueues, mediator.Publish, reindex, cache Refresh, and post-commit lookups that gate an enqueue). A late client-disconnect then turns an already-durable commit into a thrown request AND drops the side effect. Generalizes the #251 deco-handler fix. Excludes BuildPlayoutHandler (worker/background token, not a client-disconnect token), the config/FFmpeg multi-upsert handlers (partial-commit case, separate follow-up), and response-projection reloads (correctly keep the request token). audit#22 F2 — DeleteChannelHandler/DeletePlayoutHandler now delete the channel guide {number}.xml through IFileSystem.File.Delete (observable under MockFileSystem) and BEFORE the commit (a post-commit delete orphans the xml on a crash; the xml is regenerable on demand, so pre-commit delete is the safe order). audit#23 F4 — ReplacePlayoutAlternateScheduleItemsHandler rejects an empty item list in the handler (not only the controller pre-guard) so a direct caller can't trip the Max()-on-empty crash. Docs: api-conventions.md §7a (post-commit token convention + boundaries), decisions.md entry (rationale, sweep scope, #253 PR2-4 coordination note). Tests: guide-cache-delete-through-FS for both delete handlers, empty-list guard. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
173 lines
7.2 KiB
C#
173 lines
7.2 KiB
C#
using System.Threading.Channels;
|
|
using ErsatzTV.Application.Playouts;
|
|
using ErsatzTV.Core;
|
|
using ErsatzTV.Core.Domain;
|
|
using ErsatzTV.Core.Interfaces.Repositories;
|
|
using ErsatzTV.Core.Interfaces.Search;
|
|
using ErsatzTV.Core.Scheduling;
|
|
using ErsatzTV.Infrastructure.Data;
|
|
using ErsatzTV.Infrastructure.Extensions;
|
|
using Microsoft.EntityFrameworkCore;
|
|
|
|
namespace ErsatzTV.Application.MediaCollections;
|
|
|
|
public class UpdateMultiCollectionHandler : IRequestHandler<UpdateMultiCollection, Either<BaseError, Unit>>
|
|
{
|
|
private readonly ChannelWriter<IBackgroundServiceRequest> _channel;
|
|
private readonly IDbContextFactory<TvContext> _dbContextFactory;
|
|
private readonly IMediaCollectionRepository _mediaCollectionRepository;
|
|
private readonly ISearchTargets _searchTargets;
|
|
|
|
public UpdateMultiCollectionHandler(
|
|
IDbContextFactory<TvContext> dbContextFactory,
|
|
IMediaCollectionRepository mediaCollectionRepository,
|
|
ChannelWriter<IBackgroundServiceRequest> channel,
|
|
ISearchTargets searchTargets)
|
|
{
|
|
_dbContextFactory = dbContextFactory;
|
|
_mediaCollectionRepository = mediaCollectionRepository;
|
|
_channel = channel;
|
|
_searchTargets = searchTargets;
|
|
}
|
|
|
|
public async Task<Either<BaseError, Unit>> Handle(
|
|
UpdateMultiCollection request,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
await using TvContext dbContext = await _dbContextFactory.CreateDbContextAsync(cancellationToken);
|
|
Validation<BaseError, MultiCollection> validation = await Validate(dbContext, request, cancellationToken);
|
|
return await validation.Apply(c => ApplyUpdateRequest(dbContext, c, request, cancellationToken));
|
|
}
|
|
|
|
private async Task<Unit> ApplyUpdateRequest(
|
|
TvContext dbContext,
|
|
MultiCollection c,
|
|
UpdateMultiCollection request,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
c.Name = request.Name;
|
|
|
|
// save name first so playouts don't get rebuilt for a name change
|
|
await dbContext.SaveChangesAsync(cancellationToken);
|
|
|
|
var toAdd = request.Items
|
|
.Filter(i => i.CollectionId.HasValue)
|
|
// ReSharper disable once PossibleInvalidOperationException
|
|
.Filter(i => c.MultiCollectionItems.All(i2 => i2.CollectionId != i.CollectionId.Value))
|
|
.Map(i => new MultiCollectionItem
|
|
{
|
|
// ReSharper disable once PossibleInvalidOperationException
|
|
CollectionId = i.CollectionId.Value,
|
|
MultiCollectionId = c.Id,
|
|
ScheduleAsGroup = i.ScheduleAsGroup,
|
|
PlaybackOrder = i.PlaybackOrder
|
|
})
|
|
.ToList();
|
|
var toRemove = c.MultiCollectionItems
|
|
.Filter(i => request.Items.All(i2 => i2.CollectionId != i.CollectionId))
|
|
.ToList();
|
|
|
|
// remove items that are no longer present
|
|
c.MultiCollectionItems.RemoveAll(toRemove.Contains);
|
|
|
|
// update existing items
|
|
foreach (MultiCollectionItem item in c.MultiCollectionItems)
|
|
{
|
|
foreach (UpdateMultiCollectionItem incoming in
|
|
request.Items.Filter(i => i.CollectionId == item.CollectionId))
|
|
{
|
|
item.ScheduleAsGroup = incoming.ScheduleAsGroup;
|
|
item.PlaybackOrder = incoming.PlaybackOrder;
|
|
}
|
|
}
|
|
|
|
// add new items
|
|
c.MultiCollectionItems.AddRange(toAdd);
|
|
|
|
var toAddSmart = request.Items
|
|
.Filter(i => i.SmartCollectionId.HasValue)
|
|
// ReSharper disable once PossibleInvalidOperationException
|
|
.Filter(i => c.MultiCollectionSmartItems.All(i2 => i2.SmartCollectionId != i.SmartCollectionId.Value))
|
|
.Map(i => new MultiCollectionSmartItem
|
|
{
|
|
// ReSharper disable once PossibleInvalidOperationException
|
|
SmartCollectionId = i.SmartCollectionId.Value,
|
|
MultiCollectionId = c.Id,
|
|
ScheduleAsGroup = i.ScheduleAsGroup,
|
|
PlaybackOrder = i.PlaybackOrder
|
|
})
|
|
.ToList();
|
|
var toRemoveSmart = c.MultiCollectionSmartItems
|
|
.Filter(i => request.Items.All(i2 => i2.SmartCollectionId != i.SmartCollectionId))
|
|
.ToList();
|
|
|
|
// remove items that are no longer present
|
|
c.MultiCollectionSmartItems.RemoveAll(toRemoveSmart.Contains);
|
|
|
|
// update existing items
|
|
foreach (MultiCollectionSmartItem item in c.MultiCollectionSmartItems)
|
|
{
|
|
foreach (UpdateMultiCollectionItem incoming in request.Items.Filter(i =>
|
|
i.SmartCollectionId == item.SmartCollectionId))
|
|
{
|
|
item.ScheduleAsGroup = incoming.ScheduleAsGroup;
|
|
item.PlaybackOrder = incoming.PlaybackOrder;
|
|
}
|
|
}
|
|
|
|
// add new items
|
|
c.MultiCollectionSmartItems.AddRange(toAddSmart);
|
|
|
|
// rebuild playouts
|
|
if (await dbContext.SaveChangesAsync(cancellationToken) > 0)
|
|
{
|
|
_searchTargets.SearchTargetsChanged();
|
|
|
|
// refresh all playouts that use this collection
|
|
// post-commit side effect runs on CancellationToken.None so a late request cancellation
|
|
// can't abort it after the commit landed (#254)
|
|
foreach (int playoutId in await _mediaCollectionRepository.PlayoutIdsUsingMultiCollection(
|
|
request.MultiCollectionId))
|
|
{
|
|
await _channel.WriteAsync(new BuildPlayout(playoutId, PlayoutBuildMode.Refresh), CancellationToken.None);
|
|
}
|
|
}
|
|
|
|
return Unit.Default;
|
|
}
|
|
|
|
private static async Task<Validation<BaseError, MultiCollection>> Validate(
|
|
TvContext dbContext,
|
|
UpdateMultiCollection request,
|
|
CancellationToken cancellationToken) =>
|
|
(await MultiCollectionMustExist(dbContext, request, cancellationToken), await ValidateName(dbContext, request))
|
|
.Apply((collectionToUpdate, _) => collectionToUpdate);
|
|
|
|
private static Task<Validation<BaseError, MultiCollection>> MultiCollectionMustExist(
|
|
TvContext dbContext,
|
|
UpdateMultiCollection updateCollection,
|
|
CancellationToken cancellationToken) =>
|
|
dbContext.MultiCollections
|
|
.Include(mc => mc.MultiCollectionItems)
|
|
.Include(mc => mc.MultiCollectionSmartItems)
|
|
.SelectOneAsync(c => c.Id, c => c.Id == updateCollection.MultiCollectionId, cancellationToken)
|
|
.Map(o => o.ToValidation<BaseError>("MultiCollection does not exist."));
|
|
|
|
private static async Task<Validation<BaseError, string>> ValidateName(
|
|
TvContext dbContext,
|
|
UpdateMultiCollection updateMultiCollection)
|
|
{
|
|
Validation<BaseError, string> result1 = updateMultiCollection.NotEmpty(c => c.Name)
|
|
.Bind(_ => updateMultiCollection.NotLongerThan(50)(c => c.Name));
|
|
|
|
bool duplicateName = await dbContext.MultiCollections
|
|
.AnyAsync(c => c.Id != updateMultiCollection.MultiCollectionId && c.Name == updateMultiCollection.Name);
|
|
|
|
Validation<BaseError, Unit> result2 = duplicateName
|
|
? Fail<BaseError, Unit>("MultiCollection name must be unique")
|
|
: Success<BaseError, Unit>(Unit.Default);
|
|
|
|
return (result1, result2).Apply((_, _) => updateMultiCollection.Name);
|
|
}
|
|
}
|