Files
ersatztv/docker
timothy a3abfa7234 fix(819): restate BOTH halves of the scope decomposition, not one
Round 4's cold review found the recurring class had moved one level down rather
than terminated. The decomposition restated the `/generated/` half inline but
DELEGATED the filename half to `isScannableSourceFileName` — the same function
`isInScopeSourcePath` calls — putting it on both sides of the comparison, where
it cancels algebraically. Exactly the cancellation that hid the walk-vs-index
narrowing in round 2 and the directory narrowing in round 3.

MEASURED survivors on the previous head, whole suite, no filter: adding
`&& !name.endsWith('.d.ts')` to that predicate dropped a real tracked file
(`src/vite-env.d.ts`) and a term skipping lowercase-initial `.tsx` dropped
eleven — 8% of the in-scope SPA — both with all 1259 tests green. Reproduced
here before fixing. Both now redden `the shared scope predicate is EXACTLY its
two documented components`.

The fix is to restate the filename predicate inline too, so the decomposition
delegates nothing. What that is, said plainly instead of overclaimed: a verbatim
restatement of a FIXED-SIZE predicate checked against itself every run — the
`MARKED_JOBS` shape the record already blesses — which does not decay as the SPA
grows, unlike a list of members or example paths. Two residuals are now stated
rather than implied: an author editing the predicate AND the restatement together
passes deliberately, the two-site edit being the signal; and a term matching zero
tracked paths survives until the day it first matches one. So the claim is "a
term becomes visible the moment it affects a tracked path", not the previous
"regardless of what it excludes", which round 4 measured false.

Also from round 4:
- `docs/guard-inventory.md` still named the table as the proof — the mechanism
  the previous commit retracted in code but did not sweep out of the docs. It now
  describes the decomposition, why both halves are restated, and the residual.
  The same retracted phrase in the walk-side code comment is gone too; grepping
  the subject ("table of cases") found both, which is the sweep that was missed.
- The anti-vacuity floor was bounded by every tracked path under `src/` (260),
  a denominator that grows with test files while the numerator counts sources.
  It is now bounded by the IN-SCOPE count, so at most a tenth of those may be
  absent from disk before the plugin result reads as degenerate.
- The Dockerfile comment named two gates on `Test SPA` and argued only one; the
  `docs_only` arm holds because `ci-detect-docs-only.sh` classifies any `web/**`
  path as not-docs-only, so a tree taking that skip has an SPA subtree already
  tested.
- "~260 SPA sources" read as the guarded population in both the record and the
  guard comment; it is every tracked path under `web/src/`, of which ~141 are in
  scope. A worked example named a file that does not exist.

Refs: #819
Decisions-Edit: yes
2026-08-29 05:12:23 +02:00
..