timothyandClaude Opus 4.8
a1bd303cce
Build ErsatzTV Image / Docs update reminder (pull_request) Successful in 6s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Failing after 18m17s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Failing after 18m41s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been cancelled
Backend mutation-hardening cluster from the 2026-07-11 mutation-safety audit sweep (adversarial-reviewer #22/#23), the parallel-safe backend-isolated slice. audit#22 F4 — standardize post-commit enqueues on CancellationToken.None: 20 command handlers under MediaCollections/, ProgramSchedules/, Playouts/, Channels/ threaded the request cancellationToken into work that runs AFTER SaveChangesAsync commits (WriteAsync rebuild/refresh enqueues, mediator.Publish, reindex, cache Refresh, and post-commit lookups that gate an enqueue). A late client-disconnect then turns an already-durable commit into a thrown request AND drops the side effect. Generalizes the #251 deco-handler fix. Excludes BuildPlayoutHandler (worker/background token, not a client-disconnect token), the config/FFmpeg multi-upsert handlers (partial-commit case, separate follow-up), and response-projection reloads (correctly keep the request token). audit#22 F2 — DeleteChannelHandler/DeletePlayoutHandler now delete the channel guide {number}.xml through IFileSystem.File.Delete (observable under MockFileSystem) and BEFORE the commit (a post-commit delete orphans the xml on a crash; the xml is regenerable on demand, so pre-commit delete is the safe order). audit#23 F4 — ReplacePlayoutAlternateScheduleItemsHandler rejects an empty item list in the handler (not only the controller pre-guard) so a direct caller can't trip the Max()-on-empty crash. Docs: api-conventions.md §7a (post-commit token convention + boundaries), decisions.md entry (rationale, sweep scope, #253 PR2-4 coordination note). Tests: guide-cache-delete-through-FS for both delete handlers, empty-list guard. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
65 lines
2.4 KiB
C#
65 lines
2.4 KiB
C#
using System.Threading.Channels;
|
|
using ErsatzTV.Core;
|
|
using ErsatzTV.Core.Errors;
|
|
using ErsatzTV.Core.Interfaces.Search;
|
|
using ErsatzTV.Infrastructure.Data;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using static ErsatzTV.Application.Channels.ChannelValidations;
|
|
using Channel = ErsatzTV.Core.Domain.Channel;
|
|
|
|
namespace ErsatzTV.Application.Channels;
|
|
|
|
public class BulkMoveChannelsToGroupHandler(
|
|
IDbContextFactory<TvContext> dbContextFactory,
|
|
ChannelWriter<IBackgroundServiceRequest> workerChannel,
|
|
ISearchTargets searchTargets)
|
|
: IRequestHandler<BulkMoveChannelsToGroup, Either<BaseError, Unit>>
|
|
{
|
|
public async Task<Either<BaseError, Unit>> Handle(
|
|
BulkMoveChannelsToGroup request,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
if (request.ChannelIds.Count == 0)
|
|
{
|
|
return Left<BaseError, Unit>(BaseError.New("At least one channel id is required"));
|
|
}
|
|
|
|
Validation<BaseError, string> groupValidation = ValidateGroup(request.Group);
|
|
if (groupValidation.IsFail)
|
|
{
|
|
return Left<BaseError, Unit>(groupValidation.FailToSeq().Head());
|
|
}
|
|
|
|
await using TvContext dbContext = await dbContextFactory.CreateDbContextAsync(cancellationToken);
|
|
await using var transaction = await dbContext.Database.BeginTransactionAsync(cancellationToken);
|
|
|
|
List<int> channelIds = request.ChannelIds.Distinct().ToList();
|
|
List<Channel> channels = await dbContext.Channels
|
|
.Where(c => channelIds.Contains(c.Id))
|
|
.ToListAsync(cancellationToken);
|
|
|
|
if (channels.Count != channelIds.Count)
|
|
{
|
|
var found = channels.Select(c => c.Id).ToHashSet();
|
|
int missingId = channelIds.First(id => !found.Contains(id));
|
|
return Left<BaseError, Unit>(new NotFoundError($"Channel {missingId} does not exist."));
|
|
}
|
|
|
|
foreach (Channel channel in channels)
|
|
{
|
|
channel.Group = request.Group;
|
|
}
|
|
|
|
await dbContext.SaveChangesAsync(cancellationToken);
|
|
await transaction.CommitAsync(cancellationToken);
|
|
|
|
searchTargets.SearchTargetsChanged();
|
|
|
|
// post-commit side effect runs on CancellationToken.None so a late request cancellation
|
|
// can't abort it after the commit landed (#254)
|
|
await workerChannel.WriteAsync(new RefreshChannelList(), CancellationToken.None);
|
|
|
|
return Right<BaseError, Unit>(Unit.Default);
|
|
}
|
|
}
|