timothyandClaude Opus 5
017ef988d0
Cross-family (Codex) adversarial review of 8523088ce. All three findings taken:
- The name assertion only checked "not a placeholder", so it could not see a
missing NESTED include leg: dropping Episode -> Season -> Show still renders
"s00e04 - Selected episode", which contains no placeholder marker and passed.
Now every type pins its whole expected string; re-removing that leg fails, as
verified before restoring it.
- Widening the shared switch with a RemoteStream arm put `GetPlaylistItemsHandler`
one include short -- it loaded metadata for the other nine types, so playlist
RemoteStream names alone would have degraded to "???".
- `?? 0` rendered an unloaded Season as "s00", which conventionally means
Specials and so fabricated plausible-looking real data; it now renders "s??".
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
67 lines
3.0 KiB
C#
67 lines
3.0 KiB
C#
using ErsatzTV.Core.Domain;
|
|
using ErsatzTV.Infrastructure.Data;
|
|
using Microsoft.EntityFrameworkCore;
|
|
|
|
namespace ErsatzTV.Application.MediaCollections;
|
|
|
|
public class GetPlaylistItemsHandler(IDbContextFactory<TvContext> dbContextFactory)
|
|
: IRequestHandler<GetPlaylistItems, List<PlaylistItemViewModel>>
|
|
{
|
|
public async Task<List<PlaylistItemViewModel>> Handle(GetPlaylistItems request, CancellationToken cancellationToken)
|
|
{
|
|
await using TvContext dbContext = await dbContextFactory.CreateDbContextAsync(cancellationToken);
|
|
|
|
List<PlaylistItem> allItems = await dbContext.PlaylistItems
|
|
.AsNoTracking()
|
|
.Filter(i => i.PlaylistId == request.PlaylistId)
|
|
.Include(i => i.Collection)
|
|
.Include(i => i.MultiCollection)
|
|
.Include(i => i.SmartCollection)
|
|
.Include(i => i.MediaItem)
|
|
.ThenInclude(i => (i as Season).SeasonMetadata)
|
|
.ThenInclude(sm => sm.Artwork)
|
|
.Include(i => i.MediaItem)
|
|
.ThenInclude(i => (i as Season).Show)
|
|
.ThenInclude(s => s.ShowMetadata)
|
|
.ThenInclude(sm => sm.Artwork)
|
|
.Include(i => i.MediaItem)
|
|
.ThenInclude(i => (i as Show).ShowMetadata)
|
|
.ThenInclude(sm => sm.Artwork)
|
|
.Include(i => i.MediaItem)
|
|
.ThenInclude(i => (i as Artist).ArtistMetadata)
|
|
.ThenInclude(am => am.Artwork)
|
|
.Include(i => i.MediaItem)
|
|
.ThenInclude(i => (i as Movie).MovieMetadata)
|
|
.ThenInclude(mm => mm.Artwork)
|
|
.Include(i => i.MediaItem)
|
|
.ThenInclude(i => (i as Episode).EpisodeMetadata)
|
|
.ThenInclude(mm => mm.Artwork)
|
|
.Include(i => i.MediaItem)
|
|
.ThenInclude(i => (i as Episode).Season)
|
|
.ThenInclude(s => s.Show)
|
|
.ThenInclude(s => s.ShowMetadata)
|
|
.Include(i => i.MediaItem)
|
|
.ThenInclude(i => (i as MusicVideo).MusicVideoMetadata)
|
|
.ThenInclude(mm => mm.Artwork)
|
|
.Include(i => i.MediaItem)
|
|
.ThenInclude(i => (i as MusicVideo).Artist)
|
|
.ThenInclude(a => a.ArtistMetadata)
|
|
.Include(i => i.MediaItem)
|
|
.ThenInclude(i => (i as OtherVideo).OtherVideoMetadata)
|
|
.ThenInclude(mm => mm.Artwork)
|
|
.Include(i => i.MediaItem)
|
|
.ThenInclude(i => (i as Song).SongMetadata)
|
|
.ThenInclude(mm => mm.Artwork)
|
|
.Include(i => i.MediaItem)
|
|
.ThenInclude(i => (i as Image).ImageMetadata)
|
|
.ThenInclude(mm => mm.Artwork)
|
|
// RemoteStream is projected by the shared ProjectMediaItemToViewModel switch as of #671;
|
|
// without its metadata the name would degrade to "???" here while every sibling type resolves.
|
|
.Include(i => i.MediaItem)
|
|
.ThenInclude(i => (i as RemoteStream).RemoteStreamMetadata)
|
|
.ToListAsync(cancellationToken);
|
|
|
|
return allItems.Map(Mapper.ProjectToViewModel).ToList();
|
|
}
|
|
}
|