timothyandClaude Opus 4.8
d3db2f6af1
Build ErsatzTV Image / CI image pin matches docker/ci (pull_request) Successful in 8s
Build ErsatzTV Image / Docs update reminder (pull_request) Successful in 13s
Build ErsatzTV Image / decisions.md append-only (pull_request) Successful in 39s
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 1m21s
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 1m18s
Build ErsatzTV Image / Functional E2E (curl contracts) (pull_request) Successful in 14m14s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 17m47s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 7m21s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
GetOrAddFolder read libraryPath.LibraryFolders, a navigation collection only
eager-loaded on the local scan path (via GetLibrary). The Jellyfin remote sync
path takes its LibraryPath off the JellyfinLibrary entity, where LibraryFolders
is null, so .Filter(null) threw ArgumentNullException('source') on the first
item of every Jellyfin music-video scan — a feature that had therefore never
run in prod, CI, or locally.
Look the folder up from the DB by (LibraryPathId, Path) instead, removing the
implicit eager-load contract entirely (correct for all nine callers) and
documenting it on ILibraryRepository. null != empty is preserved so a re-scan
does not insert duplicate LibraryFolder rows. No new hot-path cost: local
scanners already query GetParentFolderId per folder just before this call.
Tests:
- LibraryRepositoryTests: GetOrAddFolder with a null LibraryFolders (the exact
remote-path shape) creates the folder, is idempotent on re-scan, and persists
a supplied ParentId.
- JellyfinMusicVideoLibraryScannerTests: an end-to-end scan of one synthetic
music video, wiring the REAL LibraryRepository/ArtistRepository/
MusicVideoRepository against in-memory SQLite (the existing MediaServer*
scanner tests mock every repo, which is why the bug escaped), asserts the scan
completes and creates Artist + MusicVideo rows with a real LibraryFolder.
Both proven non-vacuous against the reverted fix (each reproduces the issue's
ArgumentNullException). decisions.md entry added.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
41 lines
2.0 KiB
C#
41 lines
2.0 KiB
C#
using ErsatzTV.Core.Domain;
|
|
|
|
namespace ErsatzTV.Core.Interfaces.Repositories;
|
|
|
|
public interface ILibraryRepository
|
|
{
|
|
Task<LibraryPath> Add(LibraryPath libraryPath);
|
|
Task<Option<Library>> GetLibrary(int libraryId);
|
|
Task<Option<LocalLibrary>> GetLocal(int libraryId);
|
|
|
|
/// <summary>
|
|
/// Resolves the owning library id for a library path, without loading the full entity graph.
|
|
/// Used by the local-libraries API to pre-check a path's existence/ownership before a move
|
|
/// (see design #202 §C6 — the 404/lock-check for <c>POST .../paths/{pathId}/move</c>).
|
|
/// </summary>
|
|
Task<Option<int>> GetLibraryIdForPath(int libraryPathId);
|
|
|
|
Task<List<Library>> GetAll();
|
|
Task<Unit> UpdateLastScan(Library library);
|
|
Task<Unit> UpdateLastScan(LibraryPath libraryPath);
|
|
Task<List<LibraryPath>> GetLocalPaths(int libraryId);
|
|
Task<int> CountMediaItemsByPath(int libraryPathId);
|
|
Task SetEtag(LibraryPath libraryPath, Option<LibraryFolder> knownFolder, string path, string etag);
|
|
Task CleanEtagsForLibraryPath(LibraryPath libraryPath);
|
|
Task<Option<int>> GetParentFolderId(LibraryPath libraryPath, string folder, CancellationToken cancellationToken);
|
|
|
|
/// <summary>
|
|
/// Returns the <see cref="LibraryFolder" /> at <paramref name="folder" /> under
|
|
/// <paramref name="libraryPath" />, creating it if it does not yet exist.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// The existing folder is looked up from the database by <c>(LibraryPathId, Path)</c>. Callers do
|
|
/// <b>not</b> need to eager-load <see cref="LibraryPath.LibraryFolders" /> — the remote (Jellyfin)
|
|
/// sync path never does, and relying on that navigation collection here previously NRE'd every
|
|
/// Jellyfin music-video scan (ersatztv#488).
|
|
/// </remarks>
|
|
Task<LibraryFolder> GetOrAddFolder(LibraryPath libraryPath, Option<int> maybeParentFolder, string folder);
|
|
Task UpdateLibraryFolderId(MediaFile mediaFile, int libraryFolderId);
|
|
Task UpdatePath(LibraryPath libraryPath, string normalizedLibraryPath);
|
|
}
|