Build ErsatzTV Image / CI image pin matches docker/ci (pull_request) Successful in 5s
Build ErsatzTV Image / Docs update reminder (pull_request) Successful in 8s
Build ErsatzTV Image / decisions.md append-only (pull_request) Successful in 54s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 5m48s
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 12m49s
Build ErsatzTV Image / Functional E2E (curl contracts) (pull_request) Successful in 14m35s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 18m11s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 13m23s
Make the ~14 health checks actionable: each check that has a fix now declares
where to go, and the SPA acts on it.
Backend:
- Widen domain HealthCheckLink (string Link) -> (string Target, HealthCheckLinkKind
Kind) with ExternalDoc|AppRoute + factories; only the 4 link-building checks and
the API mapper touched .Link.
- Evolve HealthCheckResponseModel additively (/api/v1 frozen-additive): keep
deprecated string? Link (still populated), add Brief (the BriefMessage the mapper
was silently dropping) and nested Remediation {Kind, Target}. Kind is a mapped
string, not a wire enum.
- Make Mapper.GetStatus total: NotApplicable no longer throws (defensive; handler
still filters it). InternalsVisibleTo(ErsatzTV.Tests) added to unit-test totality.
- Fix 2 stale Blazor route links (media/trash -> /app/trash, search?query ->
/app/search); add AppRoute remediation to actionable checks that had none
(libraries / schedules / ffmpeg-profiles / settings).
SPA:
- DashboardScreen health panel renders remediation: AppRoute -> client-side nav
button, ExternalDoc -> new-tab anchor; detail text truncates with title-hover.
- Remove the dead "Open Classic UI" -> /system/health row from SettingsScreen
(a #91b leftover that just 302'd to /app); update its regression test.
Docs: decisions.md (#164), api-conventions.md (deprecate-in-place DTO evolution),
blazor-route-parity.md (Section 4 correction); v1.json/v1.d.ts/endpoint-index
regenerated.
fixes #164
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
75 lines
3.0 KiB
C#
75 lines
3.0 KiB
C#
using ErsatzTV.Core.Domain;
|
|
using ErsatzTV.Core.Extensions;
|
|
using ErsatzTV.Core.Health;
|
|
using ErsatzTV.Core.Health.Checks;
|
|
using ErsatzTV.Infrastructure.Data;
|
|
using Microsoft.EntityFrameworkCore;
|
|
|
|
namespace ErsatzTV.Infrastructure.Health.Checks;
|
|
|
|
public class ZeroDurationHealthCheck : BaseHealthCheck, IZeroDurationHealthCheck
|
|
{
|
|
private readonly IDbContextFactory<TvContext> _dbContextFactory;
|
|
|
|
public ZeroDurationHealthCheck(IDbContextFactory<TvContext> dbContextFactory) =>
|
|
_dbContextFactory = dbContextFactory;
|
|
|
|
public override string Title => "Zero Duration";
|
|
|
|
public async Task<HealthCheckResult> Check(CancellationToken cancellationToken)
|
|
{
|
|
await using TvContext dbContext = await _dbContextFactory.CreateDbContextAsync(cancellationToken);
|
|
|
|
List<Episode> episodes = await dbContext.Episodes
|
|
.Filter(e => e.MediaVersions.Any(mv => mv.Duration == TimeSpan.Zero))
|
|
.Include(e => e.MediaVersions)
|
|
.ThenInclude(mv => mv.MediaFiles)
|
|
.ToListAsync(cancellationToken);
|
|
|
|
List<Movie> movies = await dbContext.Movies
|
|
.Filter(m => m.MediaVersions.Any(mv => mv.Duration == TimeSpan.Zero))
|
|
.Include(m => m.MediaVersions)
|
|
.ThenInclude(mv => mv.MediaFiles)
|
|
.ToListAsync(cancellationToken);
|
|
|
|
List<MusicVideo> musicVideos = await dbContext.MusicVideos
|
|
.Filter(mv => mv.MediaVersions.Any(v => v.Duration == TimeSpan.Zero))
|
|
.Include(mv => mv.MediaVersions)
|
|
.ThenInclude(mv => mv.MediaFiles)
|
|
.ToListAsync(cancellationToken);
|
|
|
|
List<OtherVideo> otherVideos = await dbContext.OtherVideos
|
|
.Filter(ov => ov.MediaVersions.Any(mv => mv.Duration == TimeSpan.Zero))
|
|
.Include(ov => ov.MediaVersions)
|
|
.ThenInclude(mv => mv.MediaFiles)
|
|
.ToListAsync(cancellationToken);
|
|
|
|
List<Song> songs = await dbContext.Songs
|
|
.Filter(s => s.MediaVersions.Any(mv => mv.Duration == TimeSpan.Zero))
|
|
.Include(s => s.MediaVersions)
|
|
.ThenInclude(mv => mv.MediaFiles)
|
|
.ToListAsync(cancellationToken);
|
|
|
|
var all = movies.Map(m => m.MediaVersions.Head().MediaFiles.Head().Path)
|
|
.Append(episodes.Map(e => e.MediaVersions.Head().MediaFiles.Head().Path))
|
|
.Append(musicVideos.Map(mv => mv.GetHeadVersion().MediaFiles.Head().Path))
|
|
.Append(otherVideos.Map(ov => ov.GetHeadVersion().MediaFiles.Head().Path))
|
|
.Append(songs.Map(s => s.GetHeadVersion().MediaFiles.Head().Path))
|
|
.ToList();
|
|
|
|
if (all.Count != 0)
|
|
{
|
|
var paths = all.Take(5).ToList();
|
|
|
|
var files = string.Join(", ", paths);
|
|
|
|
return WarningResult(
|
|
$"There are {all.Count} files with zero duration, including the following: {files}",
|
|
$"There are {all.Count} files with zero duration",
|
|
HealthCheckLink.AppRoute("/app/libraries"));
|
|
}
|
|
|
|
return OkResult();
|
|
}
|
|
}
|