Extends MediaServerReconciliationGuard (#477) with a second deterministic refusal: when the enumeration that produced the incoming set silently dropped items whose projection THREW, the file-not-found sweep is refused. A dropped item the server did return is indistinguishable from a deletion at the reconcile step, so a projection regression could otherwise mass-flag a healthy library FileNotFound (which EmptyTrash then deletes permanently). Deliberate guard-clause skips (STRM files, virtual items, unsupported types) are explicitly NOT failures and never suppress a sweep — counting them would permanently disable reconciliation for any library holding a single STRM file. The ratio / missing-fraction threshold is REJECTED, not deferred: it is a two-sided heuristic with no tunable default and no telemetry, and the failure it approximates is exactly observable via the projection-failure count (a genuine bulk deletion produces zero failures). Seam is deliberately narrow — the private ProjectTo* contract inside each api client changed from Option<T> to MediaServerProjectionResult<T> (projected/skipped/failed), the paged helper counts IsFailure in one place, and the scanner reads it through an optional trailing MediaServerProjectionFailureCounter on only the five library-level methods that feed a sweep. The counter is per-enumeration state created by the scanner, never a field on an api client. fixes #484
141 lines
5.2 KiB
C#
141 lines
5.2 KiB
C#
using System.IO.Abstractions;
|
|
using ErsatzTV.Core;
|
|
using ErsatzTV.Core.Domain;
|
|
using ErsatzTV.Core.Emby;
|
|
using ErsatzTV.Core.Extensions;
|
|
using ErsatzTV.Core.Interfaces.Emby;
|
|
using ErsatzTV.Core.Interfaces.Repositories;
|
|
using ErsatzTV.Core.Metadata;
|
|
using ErsatzTV.Scanner.Core.Interfaces;
|
|
using ErsatzTV.Scanner.Core.Interfaces.Metadata;
|
|
using ErsatzTV.Scanner.Core.Metadata;
|
|
using Microsoft.Extensions.Logging;
|
|
|
|
namespace ErsatzTV.Scanner.Core.Emby;
|
|
|
|
public class EmbyMovieLibraryScanner :
|
|
MediaServerMovieLibraryScanner<EmbyConnectionParameters, EmbyLibrary, EmbyMovie, EmbyItemEtag>,
|
|
IEmbyMovieLibraryScanner
|
|
{
|
|
private readonly IEmbyApiClient _embyApiClient;
|
|
private readonly IEmbyMovieRepository _embyMovieRepository;
|
|
private readonly ILogger<EmbyMovieLibraryScanner> _logger;
|
|
private readonly IMediaSourceRepository _mediaSourceRepository;
|
|
private readonly IEmbyPathReplacementService _pathReplacementService;
|
|
|
|
public EmbyMovieLibraryScanner(
|
|
IScannerProxy scannerProxy,
|
|
IEmbyApiClient embyApiClient,
|
|
IMediaSourceRepository mediaSourceRepository,
|
|
IEmbyMovieRepository embyMovieRepository,
|
|
IEmbyPathReplacementService pathReplacementService,
|
|
IFileSystem fileSystem,
|
|
ILocalChaptersProvider localChaptersProvider,
|
|
IMetadataRepository metadataRepository,
|
|
ILogger<EmbyMovieLibraryScanner> logger)
|
|
: base(
|
|
scannerProxy,
|
|
fileSystem,
|
|
localChaptersProvider,
|
|
metadataRepository,
|
|
logger)
|
|
{
|
|
_embyApiClient = embyApiClient;
|
|
_mediaSourceRepository = mediaSourceRepository;
|
|
_embyMovieRepository = embyMovieRepository;
|
|
_pathReplacementService = pathReplacementService;
|
|
_logger = logger;
|
|
}
|
|
|
|
protected override bool ServerSupportsRemoteStreaming => true;
|
|
|
|
public async Task<Either<BaseError, Unit>> ScanLibrary(
|
|
string address,
|
|
string apiKey,
|
|
EmbyLibrary library,
|
|
bool deepScan,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
List<EmbyPathReplacement> pathReplacements =
|
|
await _mediaSourceRepository.GetEmbyPathReplacements(library.MediaSourceId);
|
|
|
|
string GetLocalPath(EmbyMovie movie)
|
|
{
|
|
return _pathReplacementService.GetReplacementEmbyPath(
|
|
pathReplacements,
|
|
movie.GetHeadVersion().MediaFiles.Head().Path,
|
|
false);
|
|
}
|
|
|
|
return await ScanLibrary(
|
|
_embyMovieRepository,
|
|
new EmbyConnectionParameters(address, apiKey),
|
|
library,
|
|
GetLocalPath,
|
|
deepScan,
|
|
cancellationToken);
|
|
}
|
|
|
|
protected override string MediaServerItemId(EmbyMovie movie) => movie.ItemId;
|
|
protected override string MediaServerEtag(EmbyMovie movie) => movie.Etag;
|
|
|
|
protected override IAsyncEnumerable<Tuple<EmbyMovie, int>> GetMovieLibraryItems(
|
|
EmbyConnectionParameters connectionParameters,
|
|
EmbyLibrary library,
|
|
MediaServerProjectionFailureCounter projectionFailures) =>
|
|
_embyApiClient.GetMovieLibraryItems(
|
|
connectionParameters.Address,
|
|
connectionParameters.ApiKey,
|
|
library,
|
|
projectionFailures);
|
|
|
|
protected override Task<Option<MovieMetadata>> GetFullMetadata(
|
|
EmbyConnectionParameters connectionParameters,
|
|
EmbyLibrary library,
|
|
MediaItemScanResult<EmbyMovie> result,
|
|
EmbyMovie incoming,
|
|
bool deepScan) =>
|
|
Task.FromResult<Option<MovieMetadata>>(None);
|
|
|
|
protected override Task<Option<Tuple<MovieMetadata, MediaVersion>>> GetFullMetadataAndStatistics(
|
|
EmbyConnectionParameters connectionParameters,
|
|
EmbyLibrary library,
|
|
MediaItemScanResult<EmbyMovie> result,
|
|
EmbyMovie incoming) => Task.FromResult(Option<Tuple<MovieMetadata, MediaVersion>>.None);
|
|
|
|
protected override async Task<Option<MediaVersion>> GetMediaServerStatistics(
|
|
EmbyConnectionParameters connectionParameters,
|
|
EmbyLibrary library,
|
|
MediaItemScanResult<EmbyMovie> result,
|
|
EmbyMovie incoming)
|
|
{
|
|
_logger.LogDebug("Refreshing {Attribute} for {Path}", "Emby Statistics", result.LocalPath);
|
|
|
|
Either<BaseError, MediaVersion> maybeVersion =
|
|
await _embyApiClient.GetPlaybackInfo(
|
|
connectionParameters.Address,
|
|
connectionParameters.ApiKey,
|
|
library,
|
|
incoming.ItemId);
|
|
|
|
foreach (BaseError error in maybeVersion.LeftToSeq())
|
|
{
|
|
_logger.LogWarning("Failed to get movie statistics from Emby: {Error}", error.ToString());
|
|
}
|
|
|
|
// chapters are pulled with metadata, not with statistics, but we need to save them here
|
|
foreach (MediaVersion version in maybeVersion.RightToSeq())
|
|
{
|
|
version.Chapters = result.Item.GetHeadVersion().Chapters;
|
|
}
|
|
|
|
return maybeVersion.ToOption();
|
|
}
|
|
|
|
protected override Task<Either<BaseError, MediaItemScanResult<EmbyMovie>>> UpdateMetadata(
|
|
MediaItemScanResult<EmbyMovie> result,
|
|
MovieMetadata fullMetadata,
|
|
CancellationToken cancellationToken) =>
|
|
Task.FromResult<Either<BaseError, MediaItemScanResult<EmbyMovie>>>(result);
|
|
}
|