The global Trakt lock is acquired by SchedulerService.RefreshTraktLists / MatchTraktLists (and TraktController) and released only when the *terminal* message of a batch — the one carrying Unlock: true (list == traktLists.Last()) — is processed by WorkerService, whose handler (AddTraktListHandler / MatchTraktListItemsHandler) calls IEntityLocker.UnlockTrakt() in a finally. WorkerService.ExecuteAsync breaks out of the read loop on stoppingToken.IsCancellationRequested (and exits on channel completion / reader cancellation) BEFORE processing the next message. If shutdown lands after a batch is enqueued but before its terminal Unlock: true message is handled, UnlockTrakt() never runs and the in-memory Trakt lock leaks for the rest of the process lifetime (subsequent Trakt operations 409 forever). Fix (option a): make the batch-release loss-tolerant with a compensating release in a finally around the read loop — if the Trakt lock is still held when the worker stops, release it. Chosen over tracking pending ownership (b) because the lock is a global singleton and WorkerService is its sole batch-release site, so "held at shutdown" unambiguously means "the terminal release was lost"; covers all three exit paths (break / channel completion / cancellation) in one place. Same lock-lifecycle class as #231/#233/#234. Regression test: WorkerServiceTests gates the first (non-terminal) batch message on the stopping token, then StopAsync-cancels so the worker breaks before the terminal Unlock: true message — asserts the lock is released and the terminal message was never processed. Proven non-vacuous: inverting the finally condition fails the test. Backend-only; no controller/DTO/SPA/OpenAPI impact. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
166 lines
7.7 KiB
C#
166 lines
7.7 KiB
C#
using System.Diagnostics;
|
|
using System.Threading.Channels;
|
|
using ErsatzTV.Application;
|
|
using ErsatzTV.Application.Channels;
|
|
using ErsatzTV.Application.FFmpeg;
|
|
using ErsatzTV.Application.Graphics;
|
|
using ErsatzTV.Application.Maintenance;
|
|
using ErsatzTV.Application.MediaCollections;
|
|
using ErsatzTV.Application.Playouts;
|
|
using ErsatzTV.Application.Subtitles;
|
|
using ErsatzTV.Core;
|
|
using ErsatzTV.Core.Interfaces.Locking;
|
|
using MediatR;
|
|
|
|
namespace ErsatzTV.Services;
|
|
|
|
public class WorkerService : BackgroundService
|
|
{
|
|
private readonly ChannelReader<IBackgroundServiceRequest> _channel;
|
|
private readonly IEntityLocker _entityLocker;
|
|
private readonly ILogger<WorkerService> _logger;
|
|
private readonly IServiceScopeFactory _serviceScopeFactory;
|
|
|
|
public WorkerService(
|
|
ChannelReader<IBackgroundServiceRequest> channel,
|
|
IServiceScopeFactory serviceScopeFactory,
|
|
IEntityLocker entityLocker,
|
|
ILogger<WorkerService> logger)
|
|
{
|
|
_channel = channel;
|
|
_serviceScopeFactory = serviceScopeFactory;
|
|
_entityLocker = entityLocker;
|
|
_logger = logger;
|
|
}
|
|
|
|
protected override async Task ExecuteAsync(CancellationToken stoppingToken)
|
|
{
|
|
await Task.Yield();
|
|
|
|
try
|
|
{
|
|
_logger.LogInformation("Worker service started");
|
|
|
|
await foreach (IBackgroundServiceRequest request in _channel.ReadAllAsync(stoppingToken))
|
|
{
|
|
if (stoppingToken.IsCancellationRequested)
|
|
{
|
|
break;
|
|
}
|
|
|
|
using IServiceScope scope = _serviceScopeFactory.CreateScope();
|
|
|
|
try
|
|
{
|
|
IMediator mediator = scope.ServiceProvider.GetRequiredService<IMediator>();
|
|
|
|
switch (request)
|
|
{
|
|
case RefreshFFmpegCapabilities refreshFFmpegCapabilities:
|
|
await mediator.Send(refreshFFmpegCapabilities, stoppingToken);
|
|
break;
|
|
case RefreshChannelList refreshChannelList:
|
|
await mediator.Send(refreshChannelList, stoppingToken);
|
|
break;
|
|
case RefreshChannelData refreshChannelData:
|
|
await mediator.Send(refreshChannelData, stoppingToken);
|
|
break;
|
|
case BuildPlayout buildPlayout:
|
|
{
|
|
CancellationTokenSource cts = Debugger.IsAttached
|
|
? new CancellationTokenSource(TimeSpan.FromMinutes(10))
|
|
: new CancellationTokenSource(TimeSpan.FromMinutes(2));
|
|
|
|
var linkedTokenSource =
|
|
CancellationTokenSource.CreateLinkedTokenSource(cts.Token, stoppingToken);
|
|
|
|
Either<BaseError, Unit> buildPlayoutResult = await mediator.Send(
|
|
buildPlayout,
|
|
linkedTokenSource.Token);
|
|
buildPlayoutResult.BiIter(
|
|
_ => _logger.LogDebug("Built playout {PlayoutId}", buildPlayout.PlayoutId),
|
|
error => _logger.LogWarning(
|
|
"Unable to build playout {PlayoutId}: {Error}",
|
|
buildPlayout.PlayoutId,
|
|
error.Value));
|
|
break;
|
|
}
|
|
case CheckForOverlappingPlayoutItems checkForOverlappingPlayoutItems:
|
|
await mediator.Send(checkForOverlappingPlayoutItems, stoppingToken);
|
|
break;
|
|
case InsertPlayoutGaps insertPlayoutGaps:
|
|
await mediator.Send(insertPlayoutGaps, stoppingToken);
|
|
break;
|
|
case TimeShiftOnDemandPlayout timeShiftOnDemandPlayout:
|
|
await mediator.Send(timeShiftOnDemandPlayout, stoppingToken);
|
|
break;
|
|
case DeleteOrphanedArtwork deleteOrphanedArtwork:
|
|
await mediator.Send(deleteOrphanedArtwork, stoppingToken);
|
|
break;
|
|
case DeleteOrphanedSubtitles deleteOrphanedSubtitles:
|
|
await mediator.Send(deleteOrphanedSubtitles, stoppingToken);
|
|
break;
|
|
case AddTraktList addTraktList:
|
|
Either<BaseError, Unit> result = await mediator.Send(addTraktList, stoppingToken);
|
|
foreach (BaseError error in result.LeftToSeq())
|
|
{
|
|
_logger.LogWarning(
|
|
"Unable to add trakt list {Url}: {Error}",
|
|
addTraktList.TraktListUrl,
|
|
error.Value);
|
|
}
|
|
|
|
break;
|
|
case DeleteTraktList deleteTraktList:
|
|
await mediator.Send(deleteTraktList, stoppingToken);
|
|
break;
|
|
case MatchTraktListItems matchTraktListItems:
|
|
await mediator.Send(matchTraktListItems, stoppingToken);
|
|
break;
|
|
case RefreshGraphicsElements refreshGraphicsElements:
|
|
await mediator.Send(refreshGraphicsElements, stoppingToken);
|
|
break;
|
|
#if !DEBUG_NO_SYNC
|
|
case ExtractEmbeddedSubtitles extractEmbeddedSubtitles:
|
|
await mediator.Send(extractEmbeddedSubtitles, stoppingToken);
|
|
break;
|
|
case ExtractEmbeddedShowSubtitles extractEmbeddedShowSubtitles:
|
|
await mediator.Send(extractEmbeddedShowSubtitles, stoppingToken);
|
|
break;
|
|
#endif
|
|
case ReleaseMemory aggressivelyReleaseMemory:
|
|
await mediator.Send(aggressivelyReleaseMemory, stoppingToken);
|
|
break;
|
|
}
|
|
}
|
|
catch (ObjectDisposedException) when (stoppingToken.IsCancellationRequested)
|
|
{
|
|
// this can happen when we're shutting down
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
_logger.LogWarning(ex, "Failed to process background service request");
|
|
}
|
|
}
|
|
}
|
|
catch (Exception ex) when (ex is TaskCanceledException or OperationCanceledException)
|
|
{
|
|
_logger.LogInformation("Worker service shutting down");
|
|
}
|
|
finally
|
|
{
|
|
// The global Trakt lock is acquired by SchedulerService/TraktController and released only
|
|
// when the *terminal* (Unlock: true) message of a batch is processed here. If this loop
|
|
// stops before reaching that message - shutdown break above, channel completion, or the
|
|
// reader throwing on cancellation - the release never fires and the in-memory Trakt lock
|
|
// leaks for the remaining life of the process (subsequent Trakt operations 409 forever).
|
|
// Make the batch-release loss-tolerant with a compensating release on worker shutdown.
|
|
if (_entityLocker.IsTraktLocked())
|
|
{
|
|
_logger.LogDebug("Releasing held Trakt lock during worker shutdown");
|
|
_entityLocker.UnlockTrakt();
|
|
}
|
|
}
|
|
}
|
|
}
|