AddItemsToPlaylistHandler only validated existence for movies/shows/ seasons/episodes, leaving artist/music-video/other-video/song/image/ remote-stream ids unchecked (silently accepted, or in RemoteStream's case silently dropped entirely - the apply dictionary never included CollectionType.RemoteStream). Mirror AddItemsToCollectionHandler's established pattern: add RemoteStream to the apply dictionary, and add an aggregate existence check (ValidateMediaItems/GetRequestedMediaItemIds) across all ten kinds against dbContext.MediaItems. Add ErsatzTV.Tests/Application/MediaCollections/PlaylistHandlerTests.cs covering: a bogus id of each of the ten kinds fails validation; a valid RemoteStream id is actually persisted to the playlist (regression test for the drop bug). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
158 lines
6.4 KiB
C#
158 lines
6.4 KiB
C#
using ErsatzTV.Core;
|
|
using ErsatzTV.Core.Domain;
|
|
using ErsatzTV.Core.Interfaces.Repositories;
|
|
using ErsatzTV.Infrastructure.Data;
|
|
using ErsatzTV.Infrastructure.Extensions;
|
|
using Microsoft.EntityFrameworkCore;
|
|
|
|
namespace ErsatzTV.Application.MediaCollections;
|
|
|
|
public class AddItemsToPlaylistHandler : IRequestHandler<AddItemsToPlaylist, Either<BaseError, Unit>>
|
|
{
|
|
private readonly IDbContextFactory<TvContext> _dbContextFactory;
|
|
private readonly IMovieRepository _movieRepository;
|
|
private readonly ITelevisionRepository _televisionRepository;
|
|
|
|
public AddItemsToPlaylistHandler(
|
|
IDbContextFactory<TvContext> dbContextFactory,
|
|
IMovieRepository movieRepository,
|
|
ITelevisionRepository televisionRepository)
|
|
{
|
|
_dbContextFactory = dbContextFactory;
|
|
_movieRepository = movieRepository;
|
|
_televisionRepository = televisionRepository;
|
|
}
|
|
|
|
public async Task<Either<BaseError, Unit>> Handle(AddItemsToPlaylist request, CancellationToken cancellationToken)
|
|
{
|
|
await using TvContext dbContext = await _dbContextFactory.CreateDbContextAsync(cancellationToken);
|
|
Validation<BaseError, Playlist> validation = await Validate(dbContext, request, cancellationToken);
|
|
return await validation.Apply(c => ApplyAddItemsRequest(dbContext, c, request, cancellationToken));
|
|
}
|
|
|
|
private static async Task<Unit> ApplyAddItemsRequest(
|
|
TvContext dbContext,
|
|
Playlist playlist,
|
|
AddItemsToPlaylist request,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
var allItems = new Dictionary<CollectionType, List<int>>
|
|
{
|
|
{ CollectionType.Movie, request.MovieIds },
|
|
{ CollectionType.TelevisionShow, request.ShowIds },
|
|
{ CollectionType.TelevisionSeason, request.SeasonIds },
|
|
{ CollectionType.Episode, request.EpisodeIds },
|
|
{ CollectionType.Artist, request.ArtistIds },
|
|
{ CollectionType.MusicVideo, request.MusicVideoIds },
|
|
{ CollectionType.OtherVideo, request.OtherVideoIds },
|
|
{ CollectionType.Song, request.SongIds },
|
|
{ CollectionType.Image, request.ImageIds },
|
|
{ CollectionType.RemoteStream, request.RemoteStreamIds }
|
|
};
|
|
|
|
int index = playlist.Items.Count > 0 ? playlist.Items.Max(i => i.Index) + 1 : 0;
|
|
|
|
foreach ((CollectionType collectionType, List<int> ids) in allItems)
|
|
{
|
|
foreach (int id in ids)
|
|
{
|
|
var item = new PlaylistItem
|
|
{
|
|
Index = index++,
|
|
CollectionType = collectionType,
|
|
MediaItemId = id,
|
|
PlaybackOrder = PlaybackOrder.Shuffle,
|
|
IncludeInProgramGuide = true
|
|
};
|
|
|
|
playlist.Items.Add(item);
|
|
}
|
|
}
|
|
|
|
await dbContext.SaveChangesAsync(cancellationToken);
|
|
|
|
return Unit.Default;
|
|
}
|
|
|
|
private async Task<Validation<BaseError, Playlist>> Validate(
|
|
TvContext dbContext,
|
|
AddItemsToPlaylist request,
|
|
CancellationToken cancellationToken) =>
|
|
(await PlaylistMustExist(dbContext, request, cancellationToken),
|
|
await ValidateMovies(request),
|
|
await ValidateShows(request),
|
|
await ValidateSeasons(request),
|
|
await ValidateEpisodes(request),
|
|
await ValidateMediaItems(dbContext, request, cancellationToken))
|
|
.Apply((collection, _, _, _, _, _) => collection);
|
|
|
|
private static async Task<Validation<BaseError, Playlist>> PlaylistMustExist(
|
|
TvContext dbContext,
|
|
AddItemsToPlaylist request,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
Option<Playlist> maybePlaylist = await dbContext.Playlists
|
|
.Include(c => c.Items)
|
|
.SelectOneAsync(c => c.Id, c => c.Id == request.PlaylistId, cancellationToken);
|
|
|
|
return maybePlaylist.ToValidation<BaseError>("Playlist does not exist.")
|
|
.Bind(playlist => playlist.IsSystem
|
|
? BaseError.New("Cannot add items to system (generated) playlist")
|
|
: Success<BaseError, Playlist>(playlist));
|
|
}
|
|
|
|
private Task<Validation<BaseError, Unit>> ValidateMovies(AddItemsToPlaylist request) =>
|
|
_movieRepository.AllMoviesExist(request.MovieIds)
|
|
.Map(Optional)
|
|
.Filter(v => v == true)
|
|
.MapT(_ => Unit.Default)
|
|
.Map(v => v.ToValidation<BaseError>("Movie does not exist"));
|
|
|
|
private Task<Validation<BaseError, Unit>> ValidateShows(AddItemsToPlaylist request) =>
|
|
_televisionRepository.AllShowsExist(request.ShowIds)
|
|
.Map(Optional)
|
|
.Filter(v => v == true)
|
|
.MapT(_ => Unit.Default)
|
|
.Map(v => v.ToValidation<BaseError>("Show does not exist"));
|
|
|
|
private Task<Validation<BaseError, Unit>> ValidateSeasons(AddItemsToPlaylist request) =>
|
|
_televisionRepository.AllSeasonsExist(request.SeasonIds)
|
|
.Map(Optional)
|
|
.Filter(v => v == true)
|
|
.MapT(_ => Unit.Default)
|
|
.Map(v => v.ToValidation<BaseError>("Season does not exist"));
|
|
|
|
private Task<Validation<BaseError, Unit>> ValidateEpisodes(AddItemsToPlaylist request) =>
|
|
_televisionRepository.AllEpisodesExist(request.EpisodeIds)
|
|
.Map(Optional)
|
|
.Filter(v => v == true)
|
|
.MapT(_ => Unit.Default)
|
|
.Map(v => v.ToValidation<BaseError>("Episode does not exist"));
|
|
|
|
private static async Task<Validation<BaseError, Unit>> ValidateMediaItems(
|
|
TvContext dbContext,
|
|
AddItemsToPlaylist request,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
List<int> ids = GetRequestedMediaItemIds(request).Distinct().ToList();
|
|
int existingCount = await dbContext.MediaItems
|
|
.CountAsync(mi => ids.Contains(mi.Id), cancellationToken);
|
|
|
|
return existingCount == ids.Count
|
|
? Unit.Default
|
|
: BaseError.New("Media item does not exist");
|
|
}
|
|
|
|
private static IEnumerable<int> GetRequestedMediaItemIds(AddItemsToPlaylist request) =>
|
|
request.MovieIds
|
|
.Append(request.ShowIds)
|
|
.Append(request.SeasonIds)
|
|
.Append(request.EpisodeIds)
|
|
.Append(request.ArtistIds)
|
|
.Append(request.MusicVideoIds)
|
|
.Append(request.OtherVideoIds)
|
|
.Append(request.SongIds)
|
|
.Append(request.ImageIds)
|
|
.Append(request.RemoteStreamIds);
|
|
}
|