timothy
fba5233caf
168 records -> docs/decisions/records/<area>/<topic>.md (163 active, 23 dirs) and docs/decisions/archive/<area>/<topic>.md (5 archived). The filename IS the key, so one-active-record-per-key becomes a filesystem property rather than a validator check, and supersession becomes a `git mv`. WHY: the monolith was a concurrency problem before an aesthetic one. A 3,900-line append target made parallel sessions collide -- PR #605 and PR #614 both hit append-vs-append conflicts during routine rebases, and hand-resolving those inside the corpus is exactly the operation the rationale-rewrite guard exists to police. HOW IT IS VERIFIED: a ~170-file diff cannot be meaningfully read, so correctness does not rest on reading it. The parser was taught BOTH formats first, so the body-diff guard parses the old form at the merge-base and the new form at head -- the migration validates itself, no bypass. The proof is a field-level equivalence harness: 168 records before and after, zero lost, zero gained, zero field mismatches, zero rationale bodies differing. Reviewers should scrutinise the harness; it is the actual evidence. What measuring caught that reading would not have: - ~500 lines sit OUTSIDE any record -- decisions.md's lifecycle schema and each topic file's preamble, mostly the only copy. Source files are kept and stripped, never deleted. They also cannot be filed per-area: topic files hold several areas and 4 of 23 areas span several files. - Archive discovery was a non-recursive glob; after the split it found ZERO archived records, surfacing as four bogus "supersedes points to unknown key" errors rather than an obvious failure. - ~32 live docs point into the corpus BY DATE, which the split dangles. Each stripped file now ends with a generated "Records formerly in this file" index, which also rescues the identical breadcrumbs in old issue comments. - decisions.md's "In this file:" list was 97 same-file anchor bullets that the split makes WRONG, not merely stale. Dropped; the generated index replaces them with links that resolve. The equivalence harness now runs against a checked-in FIXTURE, not the live corpus. The earlier version migrated the real tree, which made it a one-shot: the moment the migration landed there was nothing left to move and the tests failed for reasons unrelated to the code. A fixture keeps them testing the SCRIPT rather than the repo's current state. Keys preserved verbatim, warts included: `sched` (12) and `scheduling` (1) remain two directories for one concept. Renaming a key is not a move -- it changes identity, breaks the equivalence proof, and invalidates MemPalace's per-key drawers. Taxonomy normalisation is separate work. refs #610
3.3 KiB
key, title, status, since, supersedes, superseded-by, rule, signals, mechanics
| key | title | status | since | supersedes | superseded-by | rule | signals | mechanics |
|---|---|---|---|---|---|---|---|---|
| concurrency.ifmatch-rfc7232 | 2026-07-12 — If-Match evaluates per RFC 7232: valid-but-non-matching → 412, only grammar violations → 400 (#265) | active | 2026-07-12 | none | none | `ConcurrencyHeaders.ParseIfMatch` is a real RFC 7232 entity-tag/list parser: a syntactically-valid tag that doesn't strong-match (weak/empty/non-canonical/out-of-range/list) returns 412, and only a genuine grammar violation returns 400. | RFC 7232, If-Match parsing, strong-tag matching · paths: `ConcurrencyHeaders`, `IfMatchCondition`, `VersionedAggregateExtensions.CheckVersion` · issues: #265, #253, #197 | `docs/api-conventions.md` §7a |
Closing the last #253 concurrency-contract piece. ConcurrencyHeaders.ParseIfMatch previously classified
any non-canonical/weak/list If-Match value as Malformed → 400 (a deliberate fail-safe: reject rather
than risk a stale write, deferred from the reference-aggregate PR). That was RFC-incorrect. Per RFC 7232
§3.1, a syntactically-valid entity-tag that simply doesn't strong-match must return 412 Precondition
Failed, and 400 is reserved for a genuine grammar violation.
What changed. The parser is now a real RFC 7232 entity-tag/list parser (If-Match = "*" / 1#entity-tag).
It scans the list (it does not Split(',') — a comma is a valid etagc, so it can appear inside a quoted
opaque-tag: "3,5" is ONE tag, and a comma separates members only outside the quotes), trims only RFC OWS
(SP/HTAB — not string.Trim(), which would strip NBSP and let " * " masquerade as the * force-write),
validates each member as [ "W/" ] DQUOTE *etagc DQUOTE, and collects the versions of the strong members
whose opaque text is the exact canonical decimal we emit. Outcomes:
- weak (
W/"3"), empty (""), non-canonical ("03","3.0","+3"), out-of-range ("99999999999999999999") → valid tags that contribute no version → 412 (aVersion-kind with an empty candidate set is a guaranteed no-match). - list (
"3", "5") → any strong member that matches proceeds; weak/non-canonical members drop out. - genuine grammar violations (unquoted
3, SP inside the tag" 3 ", unterminated"3,garbage, a separator-only header) → 400.
Type reshape. IfMatchCondition.ExpectedVersion : Option<int> → ExpectedVersions : Option<Seq<int>>
(None = force-write; Some(set) = strong-match against the set, empty ⇒ always 412), and
VersionedAggregateExtensions.CheckVersion(Option<int>) → CheckVersion(Option<Seq<int>>) = set membership.
This threads through all 10 replace/update commands + handlers + request mappers + 9 controllers uniformly; no
wire-contract change (400 and 412 were already declared on every PUT; the field is header-derived and internal,
so no OpenAPI/DTO change).
Why now, not #197: it is the shared parser all replace-all PUTs copy, and the 412-vs-404 ordering the issue
worried about was already correct (each handler loads/validates → 404 before CheckVersion). Why safe: the
first-party SPA only ever echoes the single canonical strong tag we emit, so no shipped client changes behavior;
the change only makes a hand-written/tooling If-Match get the RFC-correct status. Docs: api-conventions.md
§7a. Refs #265 #253 #197.