timothyandClaude Fable 5
c038e13a99
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 7m27s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Failing after 2s
Build ErsatzTV Image / Docs update reminder (pull_request) Successful in 12s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
Three PR #222 adversarial-review findings fixed: 1. SearchScreen's `refreshing` derivation compared the last success `state.query` against the current query even when the query was cleared to empty — `load()` early-returns on a blank query, so `state` never updates and the "Refreshing…" cue got stuck forever over the empty-query card. Gate on `hasQuery`. 2. `MediaPosterCard` falls back to `onOpen` whenever `onToggleSelect` is undefined, so `selectMode && refreshing` (onToggleSelect withheld but onOpen still derived from `!canSelect`) made a mid-select click navigate away instead of no-op'ing. Both screens now withhold `onOpen` for the whole of select mode, not just the "live" part of it. 3. The Select/Done toggle was `disabled={refreshing}`, which also blocked *exiting* select mode — but exiting only clears selection, it isn't a mutation against the stale result set. Disable only when entering (`refreshing && !selectMode`). Also corrected the "can never get stuck" over-claim in docs/spa-conventions.md §3a: the param-keyed refreshing derivation is only self-correcting when every param value actually triggers a fetch; params that suppress fetching (like an empty search query) must be excluded from the comparison or the whole flag gated on the same condition. Tests added: query-cleared-to-empty shows no refreshing cue (both screens' existing 3 race tests still green); select-mode+refreshing card click neither selects nor navigates; select toggle disabled only while entering, not exiting. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
docs/ — reading order
Purpose: index of docs/ so a fresh contributor/agent knows what to read and in what order.
Update this doc in the same PR that adds, removes, or retitles a doc below.
Read in this order at session start:
CLAUDE.md(repo root) — project intro: architecture, layout, dev commands, conventions.docs/contributing.md— established code patterns (CQRS/MediatR, LanguageExt, Blazor/ MudBlazor, EF Core dual-provider migrations, FFmpeg pipeline, analyzers, testing). Read before any non-trivial change.docs/domain-model.md— what the app IS: entity glossary, channel→playout→schedule/block concept map, where each concept is edited in the SPA.docs/api-conventions.md— checklist for adding/changing a/api/*endpoint (controllers, DTOs, error mapping, auth, OpenAPI regen, tests).docs/spa-conventions.md— playbook for adding a screen to the ChicoryTV React SPA.docs/e2e-local.md(+scripts/e2e-local.sh) — how to run a live local instance for manual or Playwright-MCP verification.docs/testing.md— testing map: what each*.Testsproject /websuite covers, golden-file nets, the timezone-independence rule, how to run subsets, the per-PR verification gate.docs/blazor-route-parity.md— the #91 phase (b) tracker: which Blazor routes are redirected, SPA-ready-but-not-redirected, or still Blazor-only (and which issue blocks each).docs/decisions.md— append-only "why" log. Check here before challenging an existing convention.docs/ci-cd.md— build/test/release pipeline, versioning, dependency management.
Also present in docs/:
docs/rest-api.md— REST API design doc for ersatztv#2 (goals, conventions, per-slice plan). Largely superseded day-to-day bydocs/api-conventions.md; read this for the original rationale.docs/channels.md— Channel entity field reference.docs/m3u-xmltv.md— M3U/XMLTV generation overview (ChannelPlaylist,GetChannelGuideHandler).docs/fork-strategy.md— divergence policy vs upstream ErsatzTV.docs/design-sync.md— Claude Design ↔ repo screen workflow (#92).docs/endpoint-index.md— generated REST endpoint index (method/path/operationId/summary per OpenAPI tag). Do not edit by hand; regenerated byscripts/generate-endpoint-index.py/scripts/update-openapi.sh.docs/handoffs/chicorytv-issue-queue.md— living session-to-session handoff: current queue state, what's next. Check this for what's actively in flight before starting new work.docs/handoffs/rest-api.md— original handoff prompt for kicking off the REST API work (#2).