Review round 4, both reviewers. Both report the code path SOUND and the #688 coupling
class analytically gone (rows proved, not merely observed green); one caught 28 of 30
mutations. What blocked was one over-tight test, two unpinned mutations, and prose —
including two defects the PREVIOUS commit introduced while claiming to fix numbers.
TESTS
- Deleted test_adding_ordinary_records_cannot_RED_the_blocking_property. It appended two
long records to the LIVE corpus and asserted flags_minority on the RESULT, so it crossed
the cap two records before production does (56/221 vs 54/219) — a test named "cannot RED
the blocking property" being a tighter tripwire than the property. Fourth instance of the
#688 defect in this change. Deleted rather than tuned: both its jobs are already covered
off live data (the synthetic v4/v5 contrast, and the deliberate live guard at the
production threshold).
- test_main_FEEDS_the_crosscheck_the_REAL_wing_files closes a mutation hole found by
review: replacing `pyyaml_frontmatter_faults(record_wing_files())` with `...([])` in
main() left the ENTIRE suite green. Both existing wiring tests monkeypatch the function,
so they pinned that its RETURN reaches errs, never that its ARGUMENT is the corpus —
the '#609 marker that printed OK while doing nothing' defect one level up, which is the
exact thing the new record indicts. Verified: the mutation now fails this test.
- test_main_actually_REPORTS_... went vacuous whenever the ceiling legitimately goes green
(`False is False` passes with the whole warning branch deleted). Added an arm at
--record-ceiling 0, which no non-empty corpus can make vacuous.
- Pinned two surviving mutations: ceiling_calibration's n_over boundary (it recomputes the
count, so oversized_records' exclusivity test does not cover it — `>` vs `>=` differs by
the 3 records sitting exactly on the ceiling) and p95's quantile (the 95/5 fixture cannot
tell 0.95 from 0.99).
PROSE — two of these were introduced by the previous commit, whose stated job was fixing
numbers. That is the pattern worth naming, not the individual typos.
- "so ONE new record could move p90 lines" — the previous commit deleted the magnitude and
left the sentence ungrammatical. Now "by 21 lines".
- It also introduced a THIRD variant of the sequence it was correcting ("60, 60, 60") and
missed a FOURTH site in ci-cd.md still saying "twenty lines". All four sites now read the
measured 59, 59, 60, 60 -> 81, and 21 lines.
- 59- and 60-line records were described as "above the ceiling"; they are at or below it.
- "routine growth cannot cross it" overstated the bound: it is deliberately less sensitive,
not immune. Reworded, and the THIRD and tightest arm is now documented wherever the other
two appear: consolidating 15 of the 18 offenders drops below the 2% floor (verified:
3/183 = 1.64%). That is in real tension with test_oversized_records_can_go_green and is
stated as accepted — at 3/183 the constant genuinely is mis-calibrated — with the remedy
named: a consolidation PR that large should re-derive the ceiling in the same change.
- Corrected a docstring that called the 999-ceiling failure "silently deleting the
assertion"; it would go red, not silent.
Verification: 430 scripts/tests pass; ruff at baseline parity (47); validator exits 0 with
no drift notice; corpus at p90=60, 18/183, calibrated. The two new claims were measured,
not assumed: the empty-list mutation fails the new test, and 15 consolidations reaches
1.64%.
Decisions-Edit: yes
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
timothyandClaude Opus 5
c56dfdd539