timothyandClaude Fable 5
bef33c2950
Live E2E found PUT/DELETE on a missing filler preset or watermark returned 422 instead of 404. Root cause: the must-exist checks fed a NotFoundError through LanguageExt Validation, whose aggregation to Either flattens the BaseError subtype, so ApiResults.ToErrorResult never saw a NotFoundError. The precedent handlers (DeleteProgramSchedule, DeleteFFmpegProfile, UpdateProgramSchedule) avoid this by resolving must-exist as an Option and returning the NotFoundError directly as an Either Left via Option.Match — restructured the four filler/watermark Update/Delete handlers to that pattern (remaining name validation still 422s). No Blazor behavior change (it only reads error.Value). Verified live: PUT/DELETE missing → 404, GET missing → 404, empty-name POST → 422; happy-path CRUD unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
45 lines
1.9 KiB
C#
45 lines
1.9 KiB
C#
using ErsatzTV.Core;
|
|
using ErsatzTV.Core.Domain.Filler;
|
|
using ErsatzTV.Core.Errors;
|
|
using ErsatzTV.Infrastructure.Data;
|
|
using ErsatzTV.Infrastructure.Extensions;
|
|
using Microsoft.EntityFrameworkCore;
|
|
|
|
namespace ErsatzTV.Application.Filler;
|
|
|
|
public class DeleteFillerPresetHandler : IRequestHandler<DeleteFillerPreset, Either<BaseError, Unit>>
|
|
{
|
|
private readonly IDbContextFactory<TvContext> _dbContextFactory;
|
|
|
|
public DeleteFillerPresetHandler(IDbContextFactory<TvContext> dbContextFactory) =>
|
|
_dbContextFactory = dbContextFactory;
|
|
|
|
public async Task<Either<BaseError, Unit>> Handle(
|
|
DeleteFillerPreset request,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
await using TvContext dbContext = await _dbContextFactory.CreateDbContextAsync(cancellationToken);
|
|
Option<FillerPreset> maybeFillerPreset = await FillerPresetMustExist(dbContext, request, cancellationToken);
|
|
|
|
// must-exist maps to a NotFoundError Either directly (not via Validation, which
|
|
// aggregates errors and loses the subtype the API layer maps to 404)
|
|
return await maybeFillerPreset.Match(
|
|
Some: fillerPreset => DoDeletion(dbContext, fillerPreset).Map(Right<BaseError, Unit>),
|
|
None: () => Task.FromResult<Either<BaseError, Unit>>(
|
|
new NotFoundError($"FillerPreset {request.FillerPresetId} does not exist.")));
|
|
}
|
|
|
|
private static Task<Unit> DoDeletion(TvContext dbContext, FillerPreset fillerPreset)
|
|
{
|
|
dbContext.FillerPresets.Remove(fillerPreset);
|
|
return dbContext.SaveChangesAsync().ToUnit();
|
|
}
|
|
|
|
private static Task<Option<FillerPreset>> FillerPresetMustExist(
|
|
TvContext dbContext,
|
|
DeleteFillerPreset request,
|
|
CancellationToken cancellationToken) =>
|
|
dbContext.FillerPresets
|
|
.SelectOneAsync(fp => fp.Id, ps => ps.Id == request.FillerPresetId, cancellationToken);
|
|
}
|