POST /api/artwork/uploads (multipart/form-data) accepting logo and
watermark images. Validates content type (png/jpeg/gif/webp) and size
(SystemEnvironment.MaximumUploadMb, default 10MB) mirroring the Blazor
upload path; stores via IImageCache.SaveArtworkToCache; returns
{ path, contentType } consumable by channel create/update.
Includes handler + controller tests, OpenAPI 422 contract-test entry,
and regenerated v1.json.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
165 lines
6.6 KiB
C#
165 lines
6.6 KiB
C#
using System.Reflection;
|
|
using ErsatzTV.Application.Artworks;
|
|
using ErsatzTV.Controllers.Api;
|
|
using ErsatzTV.Core;
|
|
using ErsatzTV.Core.Api.Artwork;
|
|
using ErsatzTV.Core.Domain;
|
|
using MediatR;
|
|
using Microsoft.AspNetCore.Http;
|
|
using Microsoft.AspNetCore.Mvc;
|
|
using Microsoft.AspNetCore.Mvc.Routing;
|
|
using NSubstitute;
|
|
using NUnit.Framework;
|
|
using Shouldly;
|
|
using static LanguageExt.Prelude;
|
|
|
|
namespace ErsatzTV.Tests.Controllers;
|
|
|
|
[TestFixture]
|
|
public class ArtworkUploadControllerTests
|
|
{
|
|
private ArtworkUploadController _controller = null!;
|
|
private IMediator _mediator = null!;
|
|
|
|
[SetUp]
|
|
public void SetUp()
|
|
{
|
|
_mediator = Substitute.For<IMediator>();
|
|
_controller = new ArtworkUploadController(_mediator);
|
|
}
|
|
|
|
[Test]
|
|
public void Controller_Should_Expose_Idiomatic_Rest_Route()
|
|
{
|
|
MethodInfo action = typeof(ArtworkUploadController).GetMethod(nameof(ArtworkUploadController.Upload))
|
|
?? throw new AssertionException("Missing action Upload");
|
|
|
|
HttpMethodAttribute attribute = action.GetCustomAttributes<HttpMethodAttribute>(inherit: true).Single();
|
|
attribute.HttpMethods.ShouldContain("POST");
|
|
attribute.Template.ShouldBe("/api/artwork/uploads");
|
|
attribute.Name.ShouldBe("UploadArtwork");
|
|
}
|
|
|
|
[Test]
|
|
public void Action_Should_Consume_Multipart_Form_Data()
|
|
{
|
|
MethodInfo action = typeof(ArtworkUploadController).GetMethod(nameof(ArtworkUploadController.Upload))
|
|
?? throw new AssertionException("Missing action Upload");
|
|
|
|
var consumes = action.GetCustomAttribute<ConsumesAttribute>();
|
|
consumes.ShouldNotBeNull();
|
|
consumes.ContentTypes.ShouldContain("multipart/form-data");
|
|
}
|
|
|
|
[Test]
|
|
public async Task Upload_Should_Return_422_When_File_Missing()
|
|
{
|
|
IActionResult result = await _controller.Upload(null!, "logo", CancellationToken.None);
|
|
|
|
var unprocessable = result.ShouldBeOfType<UnprocessableEntityObjectResult>();
|
|
var problem = unprocessable.Value.ShouldBeOfType<ProblemDetails>();
|
|
problem.Status.ShouldBe(422);
|
|
problem.Title.ShouldBe("Validation failed");
|
|
await _mediator.DidNotReceive().Send(Arg.Any<UploadArtwork>(), Arg.Any<CancellationToken>());
|
|
}
|
|
|
|
[Test]
|
|
public async Task Upload_Should_Return_422_When_File_Empty()
|
|
{
|
|
IFormFile emptyFile = MakeFormFile([], "image/png");
|
|
|
|
IActionResult result = await _controller.Upload(emptyFile, "logo", CancellationToken.None);
|
|
|
|
result.ShouldBeOfType<UnprocessableEntityObjectResult>();
|
|
await _mediator.DidNotReceive().Send(Arg.Any<UploadArtwork>(), Arg.Any<CancellationToken>());
|
|
}
|
|
|
|
[Test]
|
|
public async Task Upload_Should_Return_422_When_File_Exceeds_Maximum_Size()
|
|
{
|
|
var oversizeBytes = new byte[(SystemEnvironment.MaximumUploadMb * 1024 * 1024) + 1];
|
|
IFormFile oversizeFile = MakeFormFile(oversizeBytes, "image/png");
|
|
|
|
IActionResult result = await _controller.Upload(oversizeFile, "logo", CancellationToken.None);
|
|
|
|
var unprocessable = result.ShouldBeOfType<UnprocessableEntityObjectResult>();
|
|
var problem = unprocessable.Value.ShouldBeOfType<ProblemDetails>();
|
|
problem.Detail.ShouldContain("maximum allowed size");
|
|
await _mediator.DidNotReceive().Send(Arg.Any<UploadArtwork>(), Arg.Any<CancellationToken>());
|
|
}
|
|
|
|
[Test]
|
|
public async Task Upload_Should_Return_422_For_Unknown_Target()
|
|
{
|
|
IFormFile file = MakeFormFile([1, 2, 3], "image/png");
|
|
|
|
IActionResult result = await _controller.Upload(file, "poster", CancellationToken.None);
|
|
|
|
var unprocessable = result.ShouldBeOfType<UnprocessableEntityObjectResult>();
|
|
var problem = unprocessable.Value.ShouldBeOfType<ProblemDetails>();
|
|
problem.Detail.ShouldContain("Unknown upload target");
|
|
await _mediator.DidNotReceive().Send(Arg.Any<UploadArtwork>(), Arg.Any<CancellationToken>());
|
|
}
|
|
|
|
[Test]
|
|
public async Task Upload_Should_Send_UploadArtwork_With_Logo_Kind_And_Return_201()
|
|
{
|
|
IFormFile file = MakeFormFile([1, 2, 3], "image/png");
|
|
_mediator.Send(Arg.Any<UploadArtwork>(), Arg.Any<CancellationToken>())
|
|
.Returns(Right<BaseError, ArtworkUploadResponseModel>(
|
|
new ArtworkUploadResponseModel("iptv/logos/abc.png", "image/png")));
|
|
|
|
IActionResult result = await _controller.Upload(file, "logo", CancellationToken.None);
|
|
|
|
var created = result.ShouldBeOfType<CreatedResult>();
|
|
created.StatusCode.ShouldBe(201);
|
|
created.Location.ShouldBe("/iptv/logos/abc.png?contentType=image%2Fpng");
|
|
created.Value.ShouldBeOfType<ArtworkUploadResponseModel>()
|
|
.Path.ShouldBe("iptv/logos/abc.png");
|
|
|
|
await _mediator.Received(1).Send(
|
|
Arg.Is<UploadArtwork>(c => c.ArtworkKind == ArtworkKind.Logo && c.ContentType == "image/png"),
|
|
Arg.Any<CancellationToken>());
|
|
}
|
|
|
|
[Test]
|
|
public async Task Upload_Should_Send_UploadArtwork_With_Watermark_Kind_And_Return_201()
|
|
{
|
|
IFormFile file = MakeFormFile([1, 2, 3], "image/webp");
|
|
_mediator.Send(Arg.Any<UploadArtwork>(), Arg.Any<CancellationToken>())
|
|
.Returns(Right<BaseError, ArtworkUploadResponseModel>(
|
|
new ArtworkUploadResponseModel("def.webp", "image/webp")));
|
|
|
|
IActionResult result = await _controller.Upload(file, "watermark", CancellationToken.None);
|
|
|
|
var created = result.ShouldBeOfType<CreatedResult>();
|
|
created.Location.ShouldBe("/artwork/watermarks/def.webp?contentType=image%2Fwebp");
|
|
|
|
await _mediator.Received(1).Send(
|
|
Arg.Is<UploadArtwork>(c => c.ArtworkKind == ArtworkKind.Watermark),
|
|
Arg.Any<CancellationToken>());
|
|
}
|
|
|
|
[Test]
|
|
public async Task Upload_Should_Return_422_On_Handler_Validation_Error()
|
|
{
|
|
IFormFile file = MakeFormFile([1, 2, 3], "image/bmp");
|
|
_mediator.Send(Arg.Any<UploadArtwork>(), Arg.Any<CancellationToken>())
|
|
.Returns(Left<BaseError, ArtworkUploadResponseModel>(BaseError.New("unsupported content type")));
|
|
|
|
IActionResult result = await _controller.Upload(file, "logo", CancellationToken.None);
|
|
|
|
var unprocessable = result.ShouldBeOfType<UnprocessableEntityObjectResult>();
|
|
var problem = unprocessable.Value.ShouldBeOfType<ProblemDetails>();
|
|
problem.Status.ShouldBe(422);
|
|
problem.Title.ShouldBe("Validation failed");
|
|
}
|
|
|
|
private static IFormFile MakeFormFile(byte[] bytes, string contentType) =>
|
|
new FormFile(new MemoryStream(bytes), 0, bytes.Length, "file", "upload.bin")
|
|
{
|
|
Headers = new HeaderDictionary(),
|
|
ContentType = contentType
|
|
};
|
|
}
|