Round 2, all five findings plus the guard gap.
HIGH — `docs/ci-cd.md` (review-verdict gate section) still asserted "Gitea
injects a write-capable GITEA_TOKEN into every job" and that only a Restricted
flip binds it. Both are false for this repo after this change, and that copy
sits in the section someone reads WHILE editing the gate — i.e. the copy most
likely to be believed, arguing that the five new `code: read` blocks are
decorative. Rewritten to point at "Workflow token scope".
MEDIUM — "the five read-only declarations bind today" was inferred from a
JOB-LEVEL probe while the five use TOP-LEVEL. Both docs now state the level the
probe carried (job-level, on `set-verdict-status`, the shipped shape), and mark
the top-level form as inferred — noting it fails safe and that
docker-build/pr-checks are `on: pull_request`, so this PR's own CI exercises it.
MEDIUM — the new 1.27.1 measurement had been inserted ABOVE the paragraph saying
"everything above is pinned to 1.25.4", which swept it into a caveat it
contradicts. Moved below, and labelled as the re-probe that caveat asks for.
MEDIUM — the record claimed the fence and the start marker showed both read
units were exercised. The fence shows `issues: read`; what shows
`pull-requests: read` is the `=success`, which is reachable only via
`complete=yes`. Warrants now stated per unit.
MEDIUM — `docker-build.yml`'s comment said "one commit-status GET" (three, at
:186/:456/:617) and omitted `ETV_REGISTRY_AUTH` at :144 entirely. Enumeration
corrected; the conclusion it supports was already right.
LOW — `ci-image.yml`'s comment said read-only-persisted was "a gain this file
gets and the others already had". The others persist NO credential; the two are
not interchangeable and this file has the weaker property.
GUARD — nothing pinned `code: write` on the gate job, and by that workflow's own
base-resolved property the editing PR can never catch its removal. Two tests in
`test_pr_changed_files.py`, both over the git-derived `_workflow_files()`
population: the gate job's units by EQUALITY (an extra unit is a finding too —
this is the repo's only CI repo-write), and every tracked workflow declaring a
block at some level.
Mutation-proved, all four reddening the intended test and the tree restoring
green: code:write->read; drop pull-requests:read; add a top-level block to
review-verdict.yml; drop dependency-scan.yml's block.
Decisions-Edit: yes
Refs: #748