timothy f6d01c4924 fix(622): make the exemption paging fail CLOSED; read statuses latest-per-context ...

Cross-family re-review returned BLOCKED on the fix commit, correctly. Two of the
three findings were on the FAILURE path, which is why every happy-path run and
the whole first test suite looked fine.

1. (High/Medium) Both paging loops treated a failed or non-array page as a
   legitimate short final page: empty output counts as zero rows, zero rows reads
   as "end of list", and the enumeration completed from a PARTIAL list — failing
   OPEN at exactly the point the guard exists to fail closed, while the decision
   record claimed the opposite. Each page is now validated as a JSON array before
   its rows are counted; anything else withholds the exemption.

2. (High) The workflow's "is there already a verdict" pre-check read
   `/statuses/{sha}`, which returns one row per status POST rather than per
   context and pages at 50 — so a head with a few CI reruns can push a real
   verdict off the first page (this PR's head already carries 15 rows for 11
   contexts). Missing it there is not benign: the job would post `pending`, or an
   exemption `success`, OVER a human verdict. Both the workflow and the hook now
   read `/commits/{sha}/status` (latest-per-context), and the workflow refuses to
   post anything when that read fails rather than inferring "no verdict yet".
   Credit: raised independently by the parallel session on this issue.

3. (Low) The record claimed both callers withhold the exemption when enumeration
   cannot complete. True only after (1); the claim and the code now agree.

Adds scripts/tests/test_merge_consent_exemption.py — 9 tests over the hook's
exemption path via a curl shim, asserting behaviour when a page ERRORS or returns
a non-array body, not merely when it returns data. Mutation-proven: reverting the
array validation fails both failure-path tests; dropping `previous_filename`
fails the rename test.

One test I wrote was wrong and the run caught it: I asserted a
`.gitea/... -> docs/...` rename must break the hook's exemption, but that hook
deliberately exempts `.claude/`/`.gitea/`/`.husky/` too (to a human PROMPT, never
an auto-grant), so both sides legitimately match. The rename guard matters there
for a genuinely non-exempt source; the stricter PROTECTED semantics belong to the
workflow. Both cases are now pinned, including a positive control that a
docs->docs rename stays exempt.

Decisions-Edit: yes

2026-07-25 22:04:18 +02:00

..

fixtures

feat(610): split the decision corpus into one YAML-frontmatter file per record

2026-07-25 19:45:09 +02:00

__init__.py

feat(521): decision-record parser (decisions_lib)

2026-07-21 02:58:58 +02:00

test_build_catalog.py

fix(603): close four defects found in adversarial review of the stale-after fields

2026-07-25 15:22:50 +02:00

test_decisions_lib.py

fix(610): make the frontmatter READ path dependency-free — CI has no PyYAML

2026-07-25 19:57:22 +02:00

test_decisions_validate.py

feat(610): re-key the body-diff guard to key; enforce path<->key; pin the filesystem invariant

2026-07-25 19:53:08 +02:00

test_merge_consent_exemption.py

fix(622): make the exemption paging fail CLOSED; read statuses latest-per-context

2026-07-25 22:04:18 +02:00

test_migration_equivalence.py

feat(610): split the decision corpus into one YAML-frontmatter file per record

2026-07-25 19:45:09 +02:00

test_post_review_verdict.py

fix(622): bind H10 merge consent to the reviewed sha via a required commit status

2026-07-25 21:51:02 +02:00