RerunCollectionRequestMapping.ResolveSelection builds an id-only VM with no existence check, so CreateRerunCollectionHandler and UpdateRerunCollectionHandler blindly copied CollectionId / MultiCollectionId / SmartCollectionId / MediaItemId from the request onto the RerunCollection FK columns. A bad id persisted a dangling FK or 500'd at SaveChanges. Add RerunCollectionSelectionValidation, a shared per-CollectionType existence check (Collection/MultiCollection/SmartCollection sets, and subtype-accurate media-item sets: Shows/Seasons/Artists/Movies/ Episodes/MusicVideos/OtherVideos/Songs/Images/RemoteStreams), composed into both handlers' Validate via the existing .Apply(...) pattern so a missing/mismatched id now fails validation (422) with a clear message instead of persisting or 500ing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
98 lines
4.1 KiB
C#
98 lines
4.1 KiB
C#
using System.Threading.Channels;
|
|
using ErsatzTV.Application.Playouts;
|
|
using ErsatzTV.Core;
|
|
using ErsatzTV.Core.Domain;
|
|
using ErsatzTV.Core.Interfaces.Repositories;
|
|
using ErsatzTV.Core.Scheduling;
|
|
using ErsatzTV.Infrastructure.Data;
|
|
using ErsatzTV.Infrastructure.Extensions;
|
|
using Microsoft.EntityFrameworkCore;
|
|
|
|
namespace ErsatzTV.Application.MediaCollections;
|
|
|
|
public class UpdateRerunCollectionHandler(
|
|
IDbContextFactory<TvContext> dbContextFactory,
|
|
IMediaCollectionRepository mediaCollectionRepository,
|
|
ChannelWriter<IBackgroundServiceRequest> channel)
|
|
: IRequestHandler<UpdateRerunCollection, Either<BaseError, Unit>>
|
|
{
|
|
public async Task<Either<BaseError, Unit>> Handle(
|
|
UpdateRerunCollection request,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
await using TvContext dbContext = await dbContextFactory.CreateDbContextAsync(cancellationToken);
|
|
Validation<BaseError, RerunCollection> validation = await Validate(dbContext, request, cancellationToken);
|
|
return await validation.Apply(c => ApplyUpdateRequest(dbContext, c, request, cancellationToken));
|
|
}
|
|
|
|
private async Task<Unit> ApplyUpdateRequest(
|
|
TvContext dbContext,
|
|
RerunCollection c,
|
|
UpdateRerunCollection request,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
c.Name = request.Name;
|
|
c.CollectionType = request.CollectionType;
|
|
c.CollectionId = request.Collection?.Id;
|
|
c.MultiCollectionId = request.MultiCollection?.Id;
|
|
c.SmartCollectionId = request.SmartCollection?.Id;
|
|
c.MediaItemId = request.MediaItem?.MediaItemId;
|
|
c.FirstRunPlaybackOrder = request.FirstRunPlaybackOrder;
|
|
c.RerunPlaybackOrder = request.RerunPlaybackOrder;
|
|
|
|
// rebuild playouts
|
|
if (await dbContext.SaveChangesAsync(cancellationToken) > 0)
|
|
{
|
|
// refresh all playouts that use this rerun collection
|
|
foreach (int playoutId in await mediaCollectionRepository.PlayoutIdsUsingRerunCollection(
|
|
request.RerunCollectionId))
|
|
{
|
|
await channel.WriteAsync(new BuildPlayout(playoutId, PlayoutBuildMode.Refresh), cancellationToken);
|
|
}
|
|
}
|
|
|
|
return Unit.Default;
|
|
}
|
|
|
|
private static async Task<Validation<BaseError, RerunCollection>> Validate(
|
|
TvContext dbContext,
|
|
UpdateRerunCollection request,
|
|
CancellationToken cancellationToken) =>
|
|
(await RerunCollectionMustExist(dbContext, request, cancellationToken),
|
|
await ValidateName(dbContext, request),
|
|
await RerunCollectionSelectionValidation.SelectedEntityMustExist(
|
|
dbContext,
|
|
request.CollectionType,
|
|
request.Collection?.Id,
|
|
request.MultiCollection?.Id,
|
|
request.SmartCollection?.Id,
|
|
request.MediaItem?.MediaItemId,
|
|
cancellationToken))
|
|
.Apply((collectionToUpdate, _, _) => collectionToUpdate);
|
|
|
|
private static Task<Validation<BaseError, RerunCollection>> RerunCollectionMustExist(
|
|
TvContext dbContext,
|
|
UpdateRerunCollection updateCollection,
|
|
CancellationToken cancellationToken) =>
|
|
dbContext.RerunCollections
|
|
.SelectOneAsync(c => c.Id, c => c.Id == updateCollection.RerunCollectionId, cancellationToken)
|
|
.Map(o => o.ToValidation<BaseError>("Rerun collection does not exist."));
|
|
|
|
private static async Task<Validation<BaseError, string>> ValidateName(
|
|
TvContext dbContext,
|
|
UpdateRerunCollection updateCollection)
|
|
{
|
|
Validation<BaseError, string> result1 = updateCollection.NotEmpty(c => c.Name)
|
|
.Bind(_ => updateCollection.NotLongerThan(50)(c => c.Name));
|
|
|
|
bool duplicateName = await dbContext.RerunCollections
|
|
.AnyAsync(c => c.Id != updateCollection.RerunCollectionId && c.Name == updateCollection.Name);
|
|
|
|
Validation<BaseError, Unit> result2 = duplicateName
|
|
? Fail<BaseError, Unit>("Rerun collection name must be unique")
|
|
: Success<BaseError, Unit>(Unit.Default);
|
|
|
|
return (result1, result2).Apply((_, _) => updateCollection.Name);
|
|
}
|
|
}
|