timothy fc547b2d46 fix(622): validate file pages per ROW, and de-vacuum the exemption tests ...

Second BLOCKED verdict, also correct. My previous fix validated only the
TOP-LEVEL type of each page, which left the same hole one level down: `[{}]` is
a well-formed JSON array whose rows carry no `filename`, so it contributes zero
paths, looks like a short final page, and completes the enumeration from a
PARTIAL list — the exact failure the guard exists to prevent, just wearing a
valid-looking wrapper. An array of scalars additionally tripped `set -e` during
extraction without producing a decision.

Both call sites now require every row to carry a non-empty string `filename`.
An empty array remains valid, since that is what a real end-of-pagination is.
Predicate checked against nine shapes before adopting: `[]` and well-formed rows
valid; `[{}]`, `[{"filename":""}]`, `[{"filename":null}]`, `["x"]`, `[1,2]`, a
bare error object, and a mixed good/bad array all rejected.

The reviewer also caught that my `test_first_page_failure_*` was VACUOUS: with
page 1 failing the path list is empty, and the hook independently withholds the
exemption on an empty list, so it passed with the guard removed. It is kept as a
smoke case with that limitation stated in its docstring, and three tests that
actually pin the behaviour were added — malformed rows and scalar rows after a
FULL page 1 (so the path list is non-empty and the exemption would really fire),
plus MAX_PAGES exhaustion.

Added a positive control too: an empty final page must still exempt. Without it,
an over-strict guard would make every "withholds the exemption" test pass for the
wrong reason — the suite would be asserting "never exempt", which is not the
contract. Verified by mutation: top-level-only validation fails 2 tests,
an over-strict guard fails the positive control, and widening MAX_PAGES fails the
exhaustion test.

Decisions-Edit: yes

2026-07-25 22:23:54 +02:00

..

fixtures

feat(610): split the decision corpus into one YAML-frontmatter file per record

2026-07-25 19:45:09 +02:00

__init__.py

feat(521): decision-record parser (decisions_lib)

2026-07-21 02:58:58 +02:00

test_build_catalog.py

fix(603): close four defects found in adversarial review of the stale-after fields

2026-07-25 15:22:50 +02:00

test_decisions_lib.py

fix(610): make the frontmatter READ path dependency-free — CI has no PyYAML

2026-07-25 19:57:22 +02:00

test_decisions_validate.py

feat(610): re-key the body-diff guard to key; enforce path<->key; pin the filesystem invariant

2026-07-25 19:53:08 +02:00

test_merge_consent_exemption.py

fix(622): validate file pages per ROW, and de-vacuum the exemption tests

2026-07-25 22:23:54 +02:00

test_migration_equivalence.py

feat(610): split the decision corpus into one YAML-frontmatter file per record

2026-07-25 19:45:09 +02:00

test_post_review_verdict.py

fix(622): bind H10 merge consent to the reviewed sha via a required commit status

2026-07-25 21:51:02 +02:00