11 Commits

Include renames

Author	SHA1	Message	Date
timothyandClaude Opus 4.8	b6f12f7e2c	security(#283): clamp served artwork MIME type to the image allow-list ... Cold-review LOW (defense-in-depth): the serve path derived the Content-Type from the stored file via Winista but only defaulted application/octet-stream on a NULL sniff. A cache file whose bytes are HTML — a legacy entry poisoned before the upload-sniff landed, or a hypothetical image/script polyglot — could still be sniffed as text/html and served renderable (nosniff does not stop an explicitly declared text/html). Clamp the sniffed type to ImageContentTypes.IsAccepted, serving application/octet-stream for anything else, so the serve path can never emit a renderable non-image type regardless of what bytes are on disk. Refs #283 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-12 00:15:56 +02:00
timothyandClaude Opus 4.8	cf834d8b60	security(#283): sniff artwork content type from bytes, remove serve-side ?contentType= reflection ... S4 stored-XSS + S9 upload-size DoS from the #197 cold API review. The artwork path trusted client-supplied content types at both ends: upload validated only the declared multipart Content-Type (never decoded the bytes), and serving reflected a client `?contentType=` straight into the response Content-Type on unauthenticated GET sinks (/iptv/logos, /artwork/watermarks). Chain: upload <script> bytes as image/png -> GET ...?contentType=text/html serves them as HTML in-origin. nosniff (#279) does not help because the server explicitly declares text/html. - Upload: derive the content type from the bytes via SkiaSharp SKCodec (header-only, no decode -> no decompression-bomb path); reject non-images 422. New ErsatzTV.Core/Images/ImageContentTypes as the single allow-list source. Dropped the untrusted declared Content-Type from the UploadArtwork command. - Serve: removed the ?contentType= reflection structurally -- dropped ContentType from GetCachedImagePath and the [FromQuery] binding on GetImage/GetWatermark; the handler always sniffs the file, defaulting application/octet-stream. ArtworkContentTypeModel.UrlWithContentType is now the bare path; SPA previews no longer append the query. - Defense-in-depth: channel-logo / watermark {path, contentType} DTOs run through ArtworkContentTypeModel.Sanitized(), blanking non-allow-listed types on write. - S9: Kestrel MaxRequestBodySize from ETV_MAXIMUM_UPLOAD_MB rejects oversized bodies during read (controller file.Length check kept as friendly-error backstop). Both serve sinks are IgnoreApi, so no OpenAPI change. Tests: byte-sniff accept/ reject, Sanitized() allow-list, Location no longer carries ?contentType=. Docs: api-conventions §4a + decisions.md 2026-07-12. Refs #283 #197 #66 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-12 00:07:55 +02:00
Jason DoveandGitHub	0c30c47ba9	nvidia - decode 10-bit h264 in software (#2833) ... * output progress/speed even when copying video * nvidia - decode 10-bit h264 in software * fixes * fix tests	2026-02-20 23:00:15 -06:00
Jason DoveandGitHub	1c07df5bc3	use cancellation tokens in many places (#2350) ... * use cancellation tokens everywhere * more cancellation tokens	2025-08-27 03:20:35 +00:00
Jason DoveandGitHub	f6249d9fa4	channel logo and watermark fixes (#2100) ... * channel logo and watermark fixes * update changelog	2025-07-01 13:40:30 +00:00
Jason DoveandGitHub	dd7f77751c	detect nvidia capabilities (#853) ... * fallback to software codecs for old nvidia cards * update dependencies	2022-06-14 19:44:34 -05:00
Jason DoveandGitHub	c02b83d0d6	code cleanup (#743) ... * update tools * run code cleanup * update dependencies	2022-04-19 17:47:18 -05:00
Jason DoveandGitHub	7e55681916	fix cliwrap usage (#737)	2022-04-16 20:12:18 -05:00
Jason DoveandGitHub	d54766866e	optimize image manipulation (#722) ... * update dependencies * use ffmpeg to resize images * use ffprobe to check for animated logos and watermarks * remove last use of imagesharp	2022-04-03 22:43:11 -05:00
Jason DoveandGitHub	1ab98578ab	refactor namespaces and imports (#670) ... * re-namespace * optimize usings * more usings * more of the same * more implicit/global usings * cleanup all usings * minor fixes	2022-03-03 15:36:07 -06:00
Jason DoveandGitHub	6504ca10a8	cache local artwork on disk (#217)	2021-05-26 19:49:08 -05:00