#197 S4+S9 [HIGH]: stored XSS via unvalidated upload content-type reflected on serve (supersedes #66) #283
Closed
opened 2026-07-11 23:20:45 +02:00 by timothy
·
3 comments
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#283
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
From the #197 cold API security review. Phase 1 hard gate. Supersedes #66.
Finding (HIGH): the artwork upload validates only the client-declared content-type (no magic-byte/decode check);
ImageCachestores bytes verbatim; serving reflects a client-supplied?contentType=query straight into thePhysicalFileResultContent-Type on unauthenticated GET sinks (/iptv/logos,/artwork/watermarks). Chain: upload<script>bytes asimage/png→GET /iptv/logos/{hash}?contentType=text/htmlserves it as HTML in the ErsatzTV origin → stored XSS. The{path,contentType}JSON DTOs (channel logo, watermark) also persist contentType verbatim. S9: upload size is checked only after multipart binding (no request-body limit tied toETV_MAXIMUM_UPLOAD_MB). (UploadArtworkHandler.cs:28,GetCachedImagePathHandler.cs:98,IptvController.cs:286,ArtworkUploadController.cs:33.)Fix (Phase-1 #4): derive content-type from decoded bytes (SkiaSharp), ignore the declared value; re-validate the JSON-DTO contentType against the allowlist; remove the serve-side
?contentType=reflection (use stored/sniffed type, defaultapplication/octet-stream); set KestrelMaxRequestBodySize+ upload[RequestSizeLimit].nosniffbackstop already landed in PR #279. Refs #197 #66.Bundling — Bundle B "content-type/upload XSS" (own session): #283 alone. Self-contained surface (artwork upload handler,
ImageCache,GetCachedImagePathHandler, image-serving controllers, Kestrel limits) — disjoint from the auth Bundle A (#280/#281/#282/#284/#285) and from #289, so it's parallel-safe and can run concurrently with them. Phase-1 remote-exposure gate. See #197 roadmap.claiming — session started 2026-07-11 (night). Branch
fix/283-artwork-content-type-xssoff origin/main.Plan (follows the Phase-1 #4 prescription):
SKCodec(header-only, no full decode → no decompression-bomb path), ignore the client-declaredContent-Type, reject non-images → 422. New allowlist/detect helper inErsatzTV.Core/Images.?contentType=reflection — dropContentTypefromGetCachedImagePath+ the[FromQuery] contentTypebinding onGetImage/GetWatermark; always sniff the file, defaultapplication/octet-stream. (Both controllers areIgnoreApi; M3U logo URLs use/iptv/logos/{path}.jpgwith no?contentType=, so unaffected.)contentTypeagainst the allowlist.MaxRequestBodySizefromETV_MAXIMUM_UPLOAD_MB(rejects during read, before buffering); keep the controllerfile.Lengthcheck as the friendly-error backstop.IgnoreApi) + docs (api-conventions §4,decisions.md).Closed — fixed on main (PR #291, merged FF)
What was done. Closed the artwork stored-XSS (S4) + upload-size DoS (S9) at both ends of the trust boundary:
SKCodec, header-only → no decompression-bomb path) and rejects non-images 422; the client-declaredContent-Typeis no longer read (dropped from theUploadArtworkcommand). NewErsatzTV.Core/Images/ImageContentTypesis the single allow-list source.GetCachedImagePath.ContentTypeand the[FromQuery] contentTypebindings onGetImage/GetWatermarkare deleted, so no request path can choose the servedContent-Type. The handler sniffs the stored file and clamps to the image allow-list, servingapplication/octet-streamotherwise (closes any legacy-poisoned-file / polyglot residue — the one cold-review LOW).{path, contentType}DTOs run throughArtworkContentTypeModel.Sanitized().MaxRequestBodySizefromETV_MAXIMUM_UPLOAD_MBrejects oversized bodies during read.Root cause. The artwork path trusted client-supplied content types at both the upload (declared-only validation, bytes stored verbatim) and serve (
?contentType=reflected into the responseContent-Type) ends.nosniff(#279) couldn't help because the server explicitly declaredtext/html.Files changed (13 source + 3 test + 3 doc):
ImageContentTypes.cs(new),UploadArtwork(Handler).cs,ArtworkContentTypeModel.cs,GetCachedImagePath(Handler).cs,IptvController/ArtworkController/ArtworkUploadController, the 5 watermark/channel request DTOs,Program.cs,web/src/api/watermarks.ts+WatermarksScreen.tsx; testsImageContentTypesTests,ArtworkContentTypeModelTests, rewrittenUploadArtworkHandlerTests+ updatedArtworkUploadControllerTests+watermarks.test.ts.Verification. ErsatzTV.Tests 1421, Core.Tests ImageContentTypes 14, web 20 + typecheck/lint/
check:api; live E2E 6/6 (upload sniff-accept/reject, serve?contentType=text/html→image/pngon both sinks, M3U.jpgroute unaffected, oversized→rejected). Cold adversarial review MERGEABLE; its one LOW folded in.Docs updated:
docs/api-conventions.md §4a,docs/decisions.md2026-07-12, anddocs/ci-cd.md(via the CI-hardening PR below).Deferred / follow-ups: none for #283. Separately filed & merged PR #294 — the
EF migration integrityMySQL apply-step was flaking on unrelated runner contention (two migration jobs sharing a host starve theirmysql:8.4containers →Command Timeout/MySqlEndOfStreamException); hardened withDefaultCommandTimeout=300+ a 3× resume-retry. That flake blocked this PR twice and is now de-flaked for all PRs.