Parity doc is unreliable as the deletion checklist: "SPA-READY" conflates screen-exists with functional parity #203

Closed
opened 2026-07-09 21:21:20 +02:00 by timothy · 2 comments
Owner

Severity: MUST-FIX (process gate for ersatztv#91 phase (b) Step 2)

What's wrong

docs/blazor-route-parity.md is the plan's single source of truth for "what can be deleted." Its SPA-READY classification means only "a screen with a matching route exists" — it does not verify the screen actually performs the Blazor page's create/edit/delete actions. The Libraries case (issue filed separately) proves this concretely: the doc marks /media/sources/* SPA-READY "merged into libraries screen," yet the SPA screen's create/edit buttons are hardcoded disabled stubs and no write API exists. A screen existing ≠ parity.

Because the same session that built the SPA also wrote and "E2E-verified" this doc (the exact shared-context blind spot this cold review was commissioned to catch), every SPA-READY row must be independently depth-verified before its Blazor page is deleted — not trusted from the table.

Also: the doc/issue counts don't reconcile cleanly (issue #91 says "124 @page routes / ~105 SPA-READY"; the actual @page grep is ~112 routes across the pages). Minor, but it signals the table was compiled loosely.

Required before gate clears

Treat the parity doc as a claim list, not a checklist. For each SPA-READY row, verify the SPA screen exercises the same mutations as the Blazor page (add/edit/delete/reorder, not just list/read) and that a backing REST endpoint exists for each mutation. Rows that fail depth-verification become blocking sub-issues (as #202 must). Do not run Step 2 deletion against the current table as-is.

Spot-checks done in this review: SmartCollection editing (query + preview) — real parity, OK. Media sources — stub, FAILS (#202). The remaining ~100 rows are unverified.

**Severity: MUST-FIX** (process gate for ersatztv#91 phase (b) Step 2) ## What's wrong `docs/blazor-route-parity.md` is the plan's single source of truth for "what can be deleted." Its **SPA-READY** classification means only "a screen with a matching route exists" — it does **not** verify the screen actually performs the Blazor page's create/edit/delete actions. The Libraries case (issue filed separately) proves this concretely: the doc marks `/media/sources/*` SPA-READY "merged into libraries screen," yet the SPA screen's create/edit buttons are hardcoded `disabled` stubs and no write API exists. A screen existing ≠ parity. Because the same session that built the SPA also wrote and "E2E-verified" this doc (the exact shared-context blind spot this cold review was commissioned to catch), **every SPA-READY row must be independently depth-verified before its Blazor page is deleted** — not trusted from the table. Also: the doc/issue counts don't reconcile cleanly (issue #91 says "124 @page routes / ~105 SPA-READY"; the actual `@page` grep is ~112 routes across the pages). Minor, but it signals the table was compiled loosely. ## Required before gate clears Treat the parity doc as a *claim list*, not a checklist. For each SPA-READY row, verify the SPA screen exercises the same mutations as the Blazor page (add/edit/delete/reorder, not just list/read) **and** that a backing REST endpoint exists for each mutation. Rows that fail depth-verification become blocking sub-issues (as #202 must). Do not run Step 2 deletion against the current table as-is. Spot-checks done in this review: SmartCollection editing (query + preview) — **real parity, OK**. Media sources — **stub, FAILS** (#202). The remaining ~100 rows are unverified.
timothy added the priority: highreview labels 2026-07-09 21:21:20 +02:00
Author
Owner

Starting work. Claim verified — the libraries row proved "SPA-READY" could mean read-only stub (see #202). A systematic mutation-depth sweep of every Section-2 row is running now: 7 parallel read-only verification passes (channels/search/logs, troubleshooting, scheduling editors, playout editors, collections/playlists/schedules, filler/trakt/ffmpeg/watermarks, media browse/detail), each enumerating the Blazor page's user-facing capabilities and checking the SPA screen + REST endpoint for each, with accepted deviations from docs/decisions.md excluded. Results will be posted here; functional gaps get promoted to blocking sub-issues on #91, and docs/blazor-route-parity.md will gain a "mutation-verified" status column in the fix PR.

Starting work. Claim verified — the libraries row proved "SPA-READY" could mean read-only stub (see #202). A systematic mutation-depth sweep of every Section-2 row is running now: 7 parallel read-only verification passes (channels/search/logs, troubleshooting, scheduling editors, playout editors, collections/playlists/schedules, filler/trakt/ffmpeg/watermarks, media browse/detail), each enumerating the Blazor page's user-facing capabilities and checking the SPA screen + REST endpoint for each, with accepted deviations from docs/decisions.md excluded. Results will be posted here; functional gaps get promoted to blocking sub-issues on #91, and docs/blazor-route-parity.md will gain a "mutation-verified" status column in the fix PR.
Author
Owner

Sweep complete — every Section-2 row re-verified at mutation depth (7 parallel capability-by-capability passes, Blazor page vs SPA screen vs REST endpoint, accepted decisions.md deviations excluded).

Results:

  • Disproven "SPA-READY" rows (moved to Section 3): schedule editors (→ #207, near read-only viewer) and media sources (→ #202, from the cold review).
  • Gap rows kept in Section 2 with blocking issues: search screen mutations (#208), media browse/detail mutations + per-show scan + episode info/troubleshoot entries (#209), playout delete/reset/erase/scheduling-context (#210), collections custom order + add-item kinds (#211).
  • SHOULD-FIX: channel editor gaps (#212), small-nits batch incl. block/watermark copy, trash/logs, stale UI notes, missing decision entries (#213).
  • Genuinely parity-OK at mutation depth: troubleshooting (all 4), blocks/templates/decos/deco-templates (except block-copy UI), filler presets, trakt lists, ffmpeg profiles, playout creation + alternate-schedules + playout-templates rows, multi/rerun collections, playlists, trash, image folder browser, all media read paths.

Root cause of the false claims: parity rows were marked from "screen exists + list renders" checks made in the same sessions that built the screens; disabled/stubbed mutation controls looked like UI polish debt rather than parity debt, and nothing forced a per-capability diff against the Blazor page. The corrected doc now embeds the verdict table and the rule that a row is only SPA-READY when its mutations are verified.

Files changed: docs/blazor-route-parity.md (verdict table added, 2 rows moved to Section 3 with rationale, gate cross-refs). Committing to main with the session handoff.

Resolution of this MUST-FIX: the un-trustworthy-doc problem is fixed (doc now carries verified verdicts + concrete blockers); the functional gaps it hid are individually tracked (#202, #207–#213) and gate #91 phase (b). Closing.

**Sweep complete — every Section-2 row re-verified at mutation depth** (7 parallel capability-by-capability passes, Blazor page vs SPA screen vs REST endpoint, accepted decisions.md deviations excluded). **Results:** - **Disproven "SPA-READY" rows (moved to Section 3)**: schedule editors (→ **#207**, near read-only viewer) and media sources (→ **#202**, from the cold review). - **Gap rows kept in Section 2 with blocking issues**: search screen mutations (**#208**), media browse/detail mutations + per-show scan + episode info/troubleshoot entries (**#209**), playout delete/reset/erase/scheduling-context (**#210**), collections custom order + add-item kinds (**#211**). - **SHOULD-FIX**: channel editor gaps (**#212**), small-nits batch incl. block/watermark copy, trash/logs, stale UI notes, missing decision entries (**#213**). - **Genuinely parity-OK at mutation depth**: troubleshooting (all 4), blocks/templates/decos/deco-templates (except block-copy UI), filler presets, trakt lists, ffmpeg profiles, playout creation + alternate-schedules + playout-templates rows, multi/rerun collections, playlists, trash, image folder browser, all media read paths. **Root cause** of the false claims: parity rows were marked from "screen exists + list renders" checks made in the same sessions that built the screens; disabled/stubbed mutation controls looked like UI polish debt rather than parity debt, and nothing forced a per-capability diff against the Blazor page. The corrected doc now embeds the verdict table and the rule that a row is only SPA-READY when its mutations are verified. **Files changed**: `docs/blazor-route-parity.md` (verdict table added, 2 rows moved to Section 3 with rationale, gate cross-refs). Committing to main with the session handoff. **Resolution of this MUST-FIX**: the un-trustworthy-doc problem is fixed (doc now carries verified verdicts + concrete blockers); the functional gaps it hid are individually tracked (#202, #207–#213) and gate #91 phase (b). Closing.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: timothy/ersatztv#203