SPA schedules editor is read-only at mutation depth — create/edit/delete + per-item editing missing (blocks #91 phase b) #207
Closed
opened 2026-07-09 21:39:55 +02:00 by timothy
·
3 comments
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
No labels
Milestone
No items
No Milestone
Blazor removal (#91 phase b)
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#207
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
From the #203 mutation-depth sweep (2026-07-09). The parity doc's "merged into schedules screen" claim for
/schedules/{id},/schedules/add,/schedules/{id}/itemsis false at mutation depth — the SPA schedules screen is a near read-only viewer:web/src/App.tsx:903); nocreateScheduleinweb/src/api/schedules.ts.POST /api/schedulesexists unused.disabledInput (App.tsx:2027); TreatCollectionsAsShows / ShuffleScheduleItems / RandomStartPoint / FixedStartTimeBehavior have no SPA surface; no delete UI.PUT/DELETE /api/schedules/{id}exist unused.disabled(App.tsx:2014–2060) — start type/time, collection type/picker, custom title, guide mode, playback order, playout mode, multiple count, all five filler slots, watermarks, subtitle mode, preferred audio/subtitle (placeholder "Deferred: no languages endpoint"). ~35 Blazor per-item fields (ScheduleItemsEditor.razor:160–748) are unchangeable even thoughScheduleItemRequest+PUT /api/schedules/{id}/itemsaccept them all.ScheduleItemsEditor.razor:134,994).LegacyUiRedirects.cs:30deliberately redirects only the/scheduleslist.Severity: MUST-FIX — deleting Blazor would leave schedule management with no working editor. Peer of #202 as a #91 phase (b) gate. Sub-need: a languages endpoint (
GetAllLanguageCodesequivalent) — shared with the channel-editor picker gap.Refs: #91, #203.
Starting implementation (branch
feat/207-212-schedules-channel-depth), incorporating the adversarial pre-review corrections from adversarial-reviewer#19 (slice 1/4). Approach:Editor architecture (review finding 1): full draft model — every per-item edit, add, copy, remove, reorder is local; one explicit Save issues the single destructive
PUT /api/schedules/{id}/itemsreplace (matching Blazor's SaveChanges). Dirty-state guard on navigation and schedule-switch; a 422/network failure retains the draft.Lossless round-trip (review finding 2): fixing #126 via its option 1 — the items endpoints (GET/POST/PUT) will return a new flat, non-polymorphic
ScheduleItemResponseModelwhose mutation fields are named 1:1 withScheduleItemRequest(plus display names and{id,name}watermark/graphics element lists), mapped from the VM hierarchy. The OpenAPI schema becomes truthful, the hand-widened TS type inweb/src/api/schedules.tsis deleted, and GET→draft→PUT is aligned by construction. A seeded mixed-schedule (One/Flood/Multiple/Duration + fixed start + marathon + playlist + rerun + fillers + overrides) no-op round-trip test asserting semantic equality across regenerated row ids is the release gate.New finding from recon (beyond the pre-review):
GetProgramScheduleItemsHandler.EnforceProperties(lines 59–87) rewritesStartType→Dynamic,Flood→One, andPlaybackOrder→None(playlist/rerun) in the GET response when the schedule has ShuffleScheduleItems — so any GET→PUT round-trip of a shuffled schedule persists the normalized values over the stored ones. Blazor has the identical behavior (same query feeds its editor), so this is parity-neutral, but it means un-shuffling a schedule cannot recover pre-shuffle Fixed/Flood settings. Will be covered by an explicit test + a decisions.md note rather than a behavior change in this PR.New API surface:
GET /api/languages(wrapsGetAllLanguageCodes; both the schedule-item and channel preferred-language pickers store the same three-letter ISO 639-2 code, so one endpoint serves both — the #212 shared endpoint),fillerKindadded toFillerPresetResponseModel+ a?fillerKind=filter (the five filler slots are unfilterable today), and the two channel enumeration endpoints (see #212). Shows/seasons/artists/multi/smart/rerun/playlists/watermarks/graphics pickers reuse existing endpoints — no new surface needed there.Parity standard: the exhaustive Blazor capability matrix (6 schedule-level fields, 43 per-item controls, all visibility/reset side-effect rules from
ProgramScheduleItemEditViewModelsetters, filler-kind filters, action semantics) is committed as the checklist; the close comment will map every row to SPA control + request key + test. Two deliberate deviations to record in decisions.md: (a) SPA Copy will also copy MultiCollection/SmartCollection/RerunCollection references — Blazor'sCopyItemomits them (ScheduleItemsEditor.razor:996–1036), which is a legacy bug, not a behavior to preserve; (b)RandomRotationplayback order andSlatetail mode stay excluded from the UI, matching Blazor.Conditional-rule engine (playback-order options per collection type, mode-gated fields, forced resets like MultiCollection→Shuffle and Playlist/Rerun→None,
MarathonShuffleGroupsdoubling as "Shuffle Playlist Items", FillWithGroup eligibility) will live in a pure, unit-tested reducer module rather than scattered through JSX.Protocol notice for the session working this issue (applies to #212 too): the handoff protocol changed while you were in flight (
main @ dfd2134c, decisions.md 2026-07-11). Your prompt's final step — "update docs/handoffs/chicorytv-issue-queue.md, pop the done items, print the next prompt" — is replaced:git pull --rebasefirst).in-progresslabel from #207/#212 when you close them (it marks your claim under the new parallel-session protocol).Done — closed via PR #229 (merged)
What was done: SPA schedules editor rebuilt to full Blazor mutation parity on a draft/explicit-Save architecture (adversarial-reviewer#19 slice-1 corrections implemented in full). Extracted from App.tsx into
web/src/screens/SchedulesScreen.tsx+web/src/schedules/(pureitemRules.tsrules module, inspector, pickers,ScheduleForm); schedule CRUD (create/edit/delete, unique-name 422 inline, flag gating); all ~43 per-item controls with every conditional/reset rule; source pickers for all 10 collection types; five kind-filtered filler slots; watermark/graphics multi-selects; language pickers; add/copy/remove/reorder draft-local with one destructive PUT on Save; dirty guards (schedule switch, in-app nav viaweb/src/navigationGuard.ts, beforeunload). Backend: flat 55-fieldScheduleItemResponseModel(fixes #126),GET /api/languages,fillerKindfilter on filler presets, lossless GET→PUT round-trip test as release gate.Root cause (of the parity gap): the original screen was built against the read-only viewer standard and verified same-session without a per-capability diff vs
ScheduleItemsEditor.razor(#203's finding). The rebuilt editor was driven from an exhaustive Blazor capability matrix (see approach comment above), verified by adversarial review + live E2E.Checked capability matrix (Blazor rule → SPA control → request key → test) — abridged to rule families; every row was implemented and is pinned by the named test:
itemRules.startTypeOptions, inspectoritemRules.test.tsgates +normalizeForSavecases; screen shuffle testplaylistGroupIdpreselect, shared rerun picker, searchTitle+searchQuery)applyCollectionTypeChange,pickers.tsxapplyCollectionTypeChangesuite + invariant test (F2)playbackOrderOptions,applyPlaybackOrderChangemarathonShuffleGroups(dual-purpose column)shufflePlaylistItemsVisibletestplayoutModeOptions,multipleModeOptions,normalizeForSavefillWithGroupModeEligible?fillerKind=, watermark/graphics multi-selects → id arrays, audio/subtitle language selects via/api/languages, audio title, subtitleModeScheduleFormVerification: adversarial review fork (5 findings fixed in-PR with failing-first tests: cross-schedule draft clobber, stale-order/state divergence, inspector state leak, in-flight-save edit loss, create-switch guard bypass) + live E2E on a seeded scratch instance (18/20 pass; found+fixed: watermark-save 500 — write-path projection NRE, lazy
Mapmasked it in tests; lineup order lost on reload — missingOrderBy(Index)). Final: 1035 dotnet + 579 web tests, CI green, merged.Files changed: see PR #229 (47+ files). Deferred/follow-ups: #230 (popstate guard gap + shuffle-toggle draft normalization), #238 (inert TopBar primaryAction on non-schedules screens — pre-existing). Docs updated: api-conventions (§7 write-path-projection convention + regen artifacts), spa-conventions (§8 navigation guard), blazor-route-parity (schedules cluster → PARITY-OK w/ evidence pointer), decisions.md (draft/Save architecture, copy deviation, EnforceProperties preserved lossiness, flat DTO).