API write-auth: decide a global default-deny model for all /api/* mutating endpoints #43
Closed
opened 2026-06-27 15:43:53 +02:00 by timothy
·
2 comments
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#43
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Surfaced by the adversarial review of #34 (#2a). Deferred from #2a with reason.
#2a added
ApiKeyAuthorizationFilter(Api:WriteKey+X-Api-Key) applied at the ChannelController class level — so all channel writes (incl.ResetPlayout) are covered. But the control is opt-in per controller, not global. So whenApi:WriteKeyis set, every other pre-existing mutating/api/*endpoint remains open:MaintenanceController(empty_trash, clean_artwork)FFmpegProfileController(create/update/delete)SmartCollectionController(CRUD)LibrariesController(scan, scan-show)SessionController(DELETE session)ScriptedScheduleController(~30 POSTs)Decision needed: move to a default-deny global model (e.g. a global MVC filter, or
[Authorize]-style convention) covering ALL/api/*mutations, with a designed exemption forScannerController(internal guid-scoped callbacks — the scanner process does not sendX-Api-Key) and any other legitimately-internal endpoints.Why deferred from #2a: a naive global filter would break the scanner callbacks and reaches into controllers owned by later slices. Better to decide the model deliberately. As each slice (#35 Collections, #37 Playouts) retrofits its controller it will adopt the class-level filter in the meantime; this issue tracks converting to global default-deny.
Relates to #2 (tracker) and #38 (#2e standardization). Reference:
docs/rest-api.md§3.5.Starting implementation in isolated worktree
/private/tmp/ersatztv-issue43on branchfeature/43-api-write-auth-default-deny.Approach: convert write auth from opt-in controller attributes to a global MVC authorization filter for mutating
/api/*requests whenApi:WriteKeyis configured. Reads remain open, no-key configured preserves current LAN-open behavior, and scanner callbacks under/api/scan/{scanId}remain explicitly exempt because the scanner process does not sendX-Api-Key. I’ll add failing security coverage first, then implement the filter/registration cleanup.Done
What was done: Implemented the global default-deny write-auth model for mutating
/api/*endpoints.ApiKeyAuthorizationFilteris now registered globally in MVC, enforcesApi:WriteKey/X-Api-Keyonly for mutating/api/*requests, leaves reads/non-API routes/unset-key LAN behavior open, and supports explicit exemptions.ScannerControlleris marked with[SkipApiKeyAuthorization]for internal scanner callbacks. Redundant per-controller[ServiceFilter(typeof(ApiKeyAuthorizationFilter))]attributes were removed and security coverage was consolidated into global filter/controller tests.Root cause: The previous API-key control was introduced incrementally as opt-in controller attributes during REST API slices. That left any existing or future mutating
/api/*controller open unless its author remembered to add the filter, and a naive global filter was deferred because scanner callbacks needed a deliberate exemption.Files changed:
ErsatzTV/Filters/ApiKeyAuthorizationFilter.cs,ErsatzTV/Filters/SkipApiKeyAuthorizationAttribute.cs,ErsatzTV/Startup.cs, API controllers underErsatzTV/Controllers/Api/, controller/filter tests underErsatzTV.Tests/, anddocs/rest-api.md.Verification: Red confirmed via missing
SkipApiKeyAuthorizationAttributecompile failure. C# LSP diagnostics clean on changed filter/security files. Focused controller/filter tests passed: 85/85. Full local solution test passed:TZ=UTC dotnet test ErsatzTV.sln -v normal=> 254/254, with only knownScriban.SignedNU1903 warnings. PR CI passed build/test and EF migration integrity; PR-only image push skipped as expected.Deferred: CORS tightening remains the existing backlog item if write APIs are exposed beyond LAN.
Follow-up issues: None.
Docs updated:
docs/rest-api.md§3.5 now documents global API-key write auth and the explicit scanner exemption.Merged in PR #54: #54