feat(api): default-deny mutating API writes #54

Merged
timothy merged 1 commits from feature/43-api-write-auth-default-deny into main 2026-06-30 18:55:32 +02:00
Owner

Summary

  • Register ApiKeyAuthorizationFilter globally for MVC so configured Api:WriteKey protects all mutating /api/* requests by default.
  • Keep reads, non-API routes, and unset-key LAN behavior open.
  • Add explicit [SkipApiKeyAuthorization] for scanner callbacks under /api/scan/{scanId}/....
  • Remove redundant per-controller opt-in API key attributes and consolidate security coverage in one global API controller test.
  • Update docs/rest-api.md auth notes.

Refs #43

Verification

  • Red confirmed: focused tests initially failed because SkipApiKeyAuthorizationAttribute did not exist.
  • C# LSP diagnostics: clean on changed filter/security files.
  • TZ=UTC dotnet test ErsatzTV.Tests/ErsatzTV.Tests.csproj --filter "FullyQualifiedName~ApiKeyAuthorizationFilterTests|FullyQualifiedName~ApiControllerSecurityTests|FullyQualifiedName~ControllerTests" -v minimal passed: 85/85.
  • TZ=UTC dotnet test ErsatzTV.sln -v normal passed: 254/254, with known Scriban.Signed NU1903 warnings.
## Summary - Register `ApiKeyAuthorizationFilter` globally for MVC so configured `Api:WriteKey` protects all mutating `/api/*` requests by default. - Keep reads, non-API routes, and unset-key LAN behavior open. - Add explicit `[SkipApiKeyAuthorization]` for scanner callbacks under `/api/scan/{scanId}/...`. - Remove redundant per-controller opt-in API key attributes and consolidate security coverage in one global API controller test. - Update `docs/rest-api.md` auth notes. Refs #43 ## Verification - Red confirmed: focused tests initially failed because `SkipApiKeyAuthorizationAttribute` did not exist. - C# LSP diagnostics: clean on changed filter/security files. - `TZ=UTC dotnet test ErsatzTV.Tests/ErsatzTV.Tests.csproj --filter "FullyQualifiedName~ApiKeyAuthorizationFilterTests|FullyQualifiedName~ApiControllerSecurityTests|FullyQualifiedName~ControllerTests" -v minimal` passed: 85/85. - `TZ=UTC dotnet test ErsatzTV.sln -v normal` passed: 254/254, with known `Scriban.Signed` NU1903 warnings.
timothy added 1 commit 2026-06-30 18:49:50 +02:00
feat(api): default-deny mutating API writes
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 4m36s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 5m37s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
527332a3ac
Refs #43
timothy scheduled this pull request to auto merge when all checks succeed 2026-06-30 18:51:47 +02:00
timothy merged commit f25cfdb593 into main 2026-06-30 18:55:32 +02:00
timothy deleted branch feature/43-api-write-auth-default-deny 2026-06-30 18:55:32 +02:00
Sign in to join this conversation.