Watermark MiddleCenter renders bottom-right — missing switch arm in OverlayWatermarkFilter #503
Closed
opened 2026-07-20 20:16:16 +02:00 by timothy
·
4 comments
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#503
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Symptom
A watermark configured with
WatermarkLocation.MiddleCenterrenders in the bottom-right corner, not centered.Root cause
ErsatzTV.FFmpeg/Filter/OverlayWatermarkFilter.cs:39-49mapsWatermarkLocationto an ffmpeg overlay position with aswitchthat has no arm forMiddleCenter:BottomRightis itself served by that_ =>default, so the missing arm is invisible: both values produce identical output and nothing looks obviously broken.MiddleCenteris a real member of the enum (ErsatzTV.FFmpeg/State/WatermarkState.cs).Why it hasn't bitten
WatermarksScreen.tsx:34deliberately does not offerMiddleCenterin its location picker (there is an explicit comment saying so, inherited from the Blazor editor), so the value is not reachable through the current UI. It is reachable through the REST API, a hand-edited database, or an imported/legacy row.Suggested fix
Add the explicit arm —
x=(W-w)/2:y=(H-h)/2— and make the_ =>default either explicitlyBottomRightor a thrown/logged unsupported case, so the next added enum value fails loudly instead of silently rendering bottom-right. Check the accelerated overlay paths (Cuda/OverlayWatermarkCudaFilter.cs,Qsv/OverlayWatermarkQsvFilter.cs) for the same gap.Provenance
Found during independent review of the #67
<BugPreview>component, which rendersMiddleCenteras genuinely centered — i.e. the SPA preview and the FFmpeg output disagree for this value. #67 keeps the semantically-correct centered preview and does not encode this defect; see the comment inweb/src/components/bugPreview.tsx.Done-when
MiddleCenterrenders centered in the software overlay path🔗 Session bundle — watermark rendering: #503, #510
Watermark rendering correctness in the FFmpeg/graphics path: #503 (MiddleCenter renders bottom-right — missing switch arm in OverlayWatermarkFilter) and #510 (WatermarkSelector deco path has a different missing-logo policy than the three precedence levels). Same WatermarkSelector/overlay surface.
When you claim any member, check this cluster for co-workable siblings and sweep the disjoint set in one session (per docs/handoffs/chicorytv-issue-queue.md → bundles).
Claiming — swept into this session alongside #484/#491 as a small, fully disjoint slice (
ErsatzTV.FFmpeg/Filter/*, no overlap with the scanner work).Implementation done locally (branch
fix/503-watermark-middlecenter, not yet pushed — batching with #484/#491).Findings while implementing
OverlayWatermarkCudaFilterandOverlayWatermarkQsvFilterboth derive fromOverlayWatermarkFilterand override onlyFilter/NextState, neverPosition— so the single base-class switch covers all three overlay paths and there was nothing extra to patch in the accelerated files. Verified by grepping the wholeErsatzTV.FFmpegproject forWatermarkLocationswitches: exactly one.Worth recording for future enum-exhaustiveness audits: there is a second
WatermarkLocationswitch outside this project,ErsatzTV.Infrastructure/Streaming/Graphics/GraphicsElement.cs(CalculatePosition, the SkiaSharp graphics-engine renderer from #67). It already has a correctMiddleCenterarm, so it was never affected — but note it applies the margin as an offset even when centered, unlike the ffmpeg path's pure center. That is a deliberate difference between the two renderers, not a bug.Default arm — log, don't throw. Every sibling filter in
ErsatzTV.FFmpeg/Filter/falls back to a safe default (string.Empty,"hwupload",None) rather than throwing, and this runs on the playback hot path where an exception would kill a stream. So the default now logs a warning and falls back to bottom-right. Note the original was already a switch expression with a catch-all_ =>, so the compiler's unhandled-enum diagnostic was never active here — this commit doesn't regress that, but it also can't rely on it, which is why box 3 is closed by a test instead.Independent review: cold review-only pass, verdict MERGEABLE. A different model family was preferred per
process.independent-review-rubricbut the Codex CLI is not installed in this environment, so the rubric's stated fallback (a fresh agent with no implementation role) was used — recording the exemption rather than leaving it silent. It confirmed all 9 position expressions against ffmpegoverlaysemantics, confirmed the inheritance claim, and surfaced two gaps, both now fixed in a follow-up commit:ExpectedPositionswas a hardcoded 9-element table, so a future 10th enum member would have passed every test and silently rendered bottom-right — reintroducing this very bug. Now asserted againstEnum.GetValues<WatermarkLocation>(). Negative control proven: removingMiddleCenterfrom the table makes the guard fail with the intended diagnostic.SourceContentMargins()was exercised by no test at all. Now covered with a pillarboxed 1440x1080-in-1920x1080 case.ErsatzTV.FFmpeg.Tests: 64 passed, 0 failed (was 34 pre-change). BOM check clean,dotnet format whitespace --folderclean.Done-when
MiddleCenterrenders centered in the software overlay pathPosition, so no separate gapClosing record
Outcome: Shipped in PR #611 (merged).
WatermarkLocation.MiddleCenternow maps tox=(W-w)/2:y=(H-h)/2across the software, CUDA and QSV overlay paths;BottomRightpromoted to an explicit arm; thedefaultarm logs a warning instead of silently absorbing unmapped values.Root cause: The
switchhad no arm forMiddleCenter, so it fell through a_ =>default — and that same default servedBottomRight. Two enum values producing byte-identical output is what made the gap invisible: nothing looked broken, and no test could distinguish "handled" from "fell through". The deeper cause is that the mapping's completeness was never asserted anywhere; the original was a switch expression with a catch-all, so the compiler's unhandled-enum diagnostic was never active either.Decisions/conventions changed: none.
Reusable knowledge: Three things worth carrying forward.
OverlayWatermarkCudaFilterandOverlayWatermarkQsvFilterinheritPositionfromOverlayWatermarkFilterand override onlyFilter/NextState— one base switch covers all three overlay paths, so a position fix does not need touching the accelerated files.WatermarkLocationswitch outsideErsatzTV.FFmpeg:ErsatzTV.Infrastructure/Streaming/Graphics/GraphicsElement.cs(CalculatePosition, the SkiaSharp renderer from #67). It was already correct, but note it applies the margin as an offset even when centered, unlike the ffmpeg path's pure center — a deliberate difference between the two renderers, not a bug. Any future enum-exhaustiveness audit must cover both.ErsatzTV.FFmpeg/Filter/falls back to a safe default rather than throwing on an unrecognized enum — these run on the playback hot path, where an exception kills a stream. Follow that pattern, and close the "silent absorption" hole with a test rather than an exception.Verification:
ErsatzTV.FFmpeg.Tests64 passed / 0 failed (34 before). Exact-string assertions for all 9 locations across all three overlay filters, plus an exhaustiveness guard asserting the expected-position table coversEnum.GetValues<WatermarkLocation>()— negative control proven: removingMiddleCenterfrom the table fails it with the intended diagnostic. Also closed a pre-existing gap whereSourceContentMargins()was exercised by no test at all. Full CI green. No live-E2E: pure ffmpeg-argument-construction leaf, no API write path, no server state, no UI.Deferred: none.
Docs updated: none required — no route, endpoint, SPA screen, or convention changed. The fix is internal to filter-argument construction.