Harden the /iptv ?access_token= transport: redact from request logs + no-store on tokened manifests
#559
Closed
opened 2026-07-22 17:32:08 +02:00 by timothy
·
3 comments
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#559
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Split out of the #552 security review (deferred hardening).
Problem
The
/iptv/*?access_token=credential transport has two pre-existing weaknesses. They predate #552 — Jellyfin and the M3U playlist already passaccess_tokenin/iptvURLs — but #552 (short-lived browser tokens) makes them slightly more relevant, and the review flagged them:Token can reach request logs.
Startup.csconfiguresUseSerilogRequestLoggingwithIncludeQueryInRequestPath = trueand{RequestPath}in the message template./iptvrequests log at Debug (suppressed under default min-level), but theex != nullandStatusCode > 499branches log at Error regardless of path — so a 5xx on an/iptv/...?access_token=<jwt>request writes the full token to the log under default settings. Anyone with log access can replay the (globally-scoped) token until expiry.Tokened dynamic manifests lack
Cache-Control: no-store. The multi-variant playlist (IptvController.GetMultiVariantPlaylist, ~:305) and the variant playlist embed theaccess_tokenin their bodies/URLs but set no cache headers, so a browser or intermediary could cache the token-bearing manifest.Why deferred from #552
Both are properties of the shared
?access_token=transport (all/iptvclients, not just the browser), and the fixes are cross-cutting changes to request-logging and manifest-serving behavior with their own review/test surface. #552 already bounds the exposure by making browser tokens 60-min (vs the old hardcoded 1-dayGenerateToken) and clamping the configurable lifetime to 24h.Suggested shape
access_tokenfrom the loggedRequestPath— e.g. setIncludeQueryInRequestPath = falseand enrich a scrubbed request path (query minusaccess_token), or a Serilog destructuring/enricher that masks it. Verify with a live 5xx on a tokened/iptvURL. Apply the same thought to any reverse-proxy access logs (ops note).Cache-Control: private, no-storeon token-bearing dynamic/iptvmanifests.Done-when
/iptv/...?access_token=request does not write the token to the logno-storedocs/decisions/api-auth-security.mdupdated (fold into / supersede the "deferred hardening" note undersecurity.iptv-browser-token)🔗 Session bundle — access_token transport hardening: #421, #559
Both harden the
access_token-in-URL surface (from the #376/#552 arc): #421 (M3U token not quote-safe in the url-tvg="..." attribute) and #559 (redact the /iptv?access_token=from request logs + no-store on tokened manifests). Security-adjacent, same token transport.When you claim any member, check this cluster for co-workable siblings and sweep the disjoint set in one session (per docs/handoffs/chicorytv-issue-queue.md → bundles).
Claiming this as part of the access_token transport hardening bundle (#421 + #559) in one session — both harden the
access_token-in-URL surface. Working in a worktree offorigin/main.Closing record
Outcome: Merged in #574 (squash). (1) Serilog request log redacts
access_token(IncludeQueryInRequestPath = false+RequestLogScrubber→RequestPathScrubbed=***). (2)Cache-Control: private, no-storeonchannels.m3u,xmltv.xml, the.m3u8HLS manifests, and their token-bearing 302 Locations.Root cause:
UseSerilogRequestLogginglogged the full query at Error on any 5xx/iptvrequest → token replay from logs; token-bearing dynamic manifests set no cache headers → cache replay. Both pre-date #552 (Jellyfin/M3U already passaccess_token).Decisions/conventions changed:
security.iptv-access-token-transport(shared with #421); resolves the deferred-hardening note undersecurity.iptv-browser-token.Reusable knowledge: Serilog appends its own
RequestPathAFTER enriched props, so an enricher must use a DISTINCT name (RequestPathScrubbed) to survive. Residual: ASP.NET'sMicrosoft.AspNetCore.Hosting"Request starting" line also carries the raw query but is suppressed only by the"Microsoft":"Warning"appsettings override (NOT reachable via the runtime logging-settings UI —HttpLevelSwitchcovers onlySerilog.AspNetCore.RequestLoggingMiddleware); that override is load-bearing.Verification:
RequestLogScrubberTests+IptvControllerCacheHeaderTests; 2-round cold review; CI green; live-E2E confirmedHTTP GET /iptv/channels.m3u?mode=segmenter&access_token=*** responded 200with the raw token absent from logs, andno-storeon m3u/xmltv/m3u8.Deferred: category-agnostic log scrub filter — only if the
Microsoft:Warningoverride is ever relaxed (documented, no issue filed).Docs updated:
docs/decisions/api-auth-security.md.