E2E briefs: scope process cleanup by PID, never a pattern-wide pkill #586
Closed
opened 2026-07-25 11:20:51 +02:00 by timothy
·
2 comments
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#586
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Follow-up to the 2026-07-25 incident on #445 (see comment).
What happened
A delegated agent running the #440 live-E2E found a
dotnet ErsatzTV.dllalready listening on the default port 8409 that wasn't its own (mismatchedapi.key). It correctly moved to port 8420 for its own run — then during cleanup ran a broadpkill -f "dotnet ErsatzTV.dll", which would have killed the parallel #445/#533 session's instance too.No damage this time, confirmed by the affected session:
scripts/e2e-ui.showns its instance lifecycle and kills its server via an EXIT/INT/TERM trap, so a free 8409 was the expected post-run state, and all four determinism runs plus the guard's negative control had printed explicit3 passedsummaries before the sweep. Nothing was truncated.Why it's still worth fixing
The near-miss is the point. A mid-run kill of an E2E harness doesn't fail loudly — it truncates output into plausible-looking-but-wrong data, which is the failure mode that survives review (cf.
docs/decisions/workflow-process.mdon the #406 peak-anon incident, same shape: reaping a shared-host resource you didn't create).Port separation is not sufficient mitigation, and this is the reusable fact from the affected session: their CI step uses 8410 while local runs use 8409, so a pattern-wide
pkill -f "dotnet ErsatzTV.dll"hits either regardless. Scope by PID, not by pattern or port.Root cause is a delegation gap, not agent error: the brief specified a fresh config dir (per
testing.e2e-local-fresh-config-dir) but said nothing about process cleanup, so the agent invented a reasonable-looking pattern kill.Proposed
testing.e2e-cleanup-scope-by-pidor similar): an E2E harness/agent may only kill PIDs it started — capture the PID at launch and trap on EXIT/INT/TERM, asscripts/e2e-ui.shalready does. Neverpkill -fa pattern that can match another session's process.docs/e2e-local.mdso the constraint reaches the brief-writer, and consider adding it to the delegation guidance so future E2E briefs inherit it.scripts/e2e-local.shshould adopt the same trap-based lifecyclee2e-ui.shhas, and/or bind a session-unique port by default.Done-when
testing.e2e-cleanup-scope-by-piddocs/e2e-local.mdstates the constraint where a brief-writer will see it — plus a lore bullet indocs/handoffs/chicorytv-issue-queue.md, which is what a session actually reads at startupscripts/e2e-local.shreviewed againste2e-ui.sh's trap-based lifecycle (adopt or record why not) — recorded why not: it hands a running instance back to its caller (both callers useOUT="$(e2e-local.sh …)"), so an EXIT trap would kill the server the instant the launcher returned. It instead gained anlsofpre-flight and a working port escape hatch.c8e79f49PR: #598
Claiming — worked as part of a CI/repo-hygiene session bundle with #594 and #485 (disjoint file sets, one PR).
Closing record
Outcome: Shipped in PR #598 (merged). New decision record
testing.e2e-cleanup-scope-by-pid; a teardown warning indocs/e2e-local.mdwritten at brief-writers; a lore bullet indocs/handoffs/chicorytv-issue-queue.md.scripts/e2e-local.shgained anlsofpre-flight that names a foreign listener's PID instead of reaping it, a numeric-port guard, and anETV_STREAMING_PORTdefault. Swept with #594 and #485.Root cause: A delegation gap, not agent error. The brief specified a fresh config dir (
testing.e2e-local-fresh-config-dir) but said nothing about process cleanup, so the agent invented a plausible-lookingpkill -fpattern. An omitted rule isn't an unenforced rule — it's a rule replaced by whatever default the agent reaches for.Decisions/conventions changed: Added
testing.e2e-cleanup-scope-by-pid. Documented a live tension withtesting.playwright-mcp-download-and-recovery, which prescribes the same shared-host reap — deferred to #596 rather than line-edited, since reversing a record is a supersede-and-relocate operation.Reusable knowledge: Three things worth carrying forward.
ETV_UI_PORT=<other>alone does not move the app off 8409.Program.csbinds a second listener andSystemEnvironment.csdefaultsStreamingPortto 8409 independently of the UI port. The obvious escape hatch was a dead end that led straight back to the confusion behind the pattern kill — verified by negative control (direct DLL launch at 8420 binds*:8420and*:8409). Throughe2e-local.shthis is now fixed; launching the DLL by hand still needs both vars.functional-e2eexportsETV_UI_PORT=8409— the same port as local runs. 8410 is theersatztv-testcontainer on jazz. There was even less port separation than the incident assumed.e2e-local.shmust NOT adopte2e-ui.sh's trap — the contracts are inverse. It hands a running instance back to its caller, and both callers useOUT="$(e2e-local.sh …)", so anEXITtrap would fire when the command substitution returns and kill the server before anyone could use it. Launcher vs lifecycle-owner: only the owner traps.Verification: Local boot with a negative control — old remedy binds 8420+8409, fixed script binds only 8420, CI shape (8409) boots,
GET /→ 302, cleankill "$PID", port freed. Pre-flight tested across six scenarios (busy UI port, busy streaming port, non-numeric, empty, free-port control). CI green:Build & test,EF migration integrity,api-docs,format, allPR Gates.functional-e2einitially failed on infra (ReferenceError: __dirnameinsideactions/cache, before any PR code ran); reran green on identical code withpassed: 45 failed: 0, log confirming the modified script actually booted the app. Two-round cold-context adversarial review — round 1 BLOCKED on a real Blocker (the port dead end), round 2 MERGEABLE @c8e79f49.Deferred: #596 — PID-scope the Playwright-MCP stall recovery. It flags an honest open question: if MCP servers are externally indistinguishable across sessions, a safe PID-scoped recovery may not exist and the rule becomes "restart via the client, never the shell."
Docs updated:
docs/e2e-local.md,docs/decisions/workflow-process.md(+ regenerateddocs/decisions/README.md),docs/handoffs/chicorytv-issue-queue.md.