Auto-Tune DetailPanel SPA: wire per-source weight steppers + exclude/add-untagged to the #425 backend #440
Closed
opened 2026-07-18 04:31:22 +02:00 by timothy
·
2 comments
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#440
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Follow-up to #425 (backend) + #386 (DetailPanel SPA). #425 shipped the backend for per-source rotation weights + query corrections:
POST /api/v1/channels/auto-tunenow accepts an optional per-channelsources: [{sourceId, weight, excluded}](seeAutoTuneSourceWeightRequest;sourceId= a show/movie id fromGET /api/v1/channels/auto-tune/members). #386 shipped the DetailPanel but deliberately deferred the weight steppers and correction controls to #425's slice; #425 delivered only the backend (it was scoped backend-only), so the SPA controls are still unbuilt.Scope
#425hint), add a per-source weight stepper (1..1000, default 1 = fair-share) and an exclude toggle per member row.sourcesentry).sourcesarray into the per-channel draft thatAutoTuneScreensends toPOST /api/v1/channels/auto-tune.#425hint once wired.Notes
docs/decisions.md2026-07-18 (#425).sourcesarray is a harmless no-op.Done-when
sourcesClaiming — Claude Code session 2026-07-25. Session lead of a two-issue
frontendbundle with #436 (disjoint SPA slices, parallel worktrees).Closing record
Outcome: Shipped via PR #589 (merged, head
22e89fb9). The Auto-Tune DetailPanel's Content-sources pane is now writable: per-source weight steppers (1..1000), an include/exclude toggle per member row, an axis-aware library typeahead for add-untagged, an "N customised" tag, and the read-only#425hint removed. The resultingsources: [{sourceId, weight, excluded}]array is threaded into the per-channel draft and sent toPOST /api/v1/channels/auto-tune.Root cause: n/a (feature). The gap existed because #386 deferred these controls to #425's slice and #425 was scoped backend-only, so neither issue owned the SPA half — worth noting as a pattern: a deferral that names a sibling issue rather than a deliverable can leave work owned by nobody.
Decisions/conventions changed: None. This is the SPA wiring of the already-recorded
sched.autotune-per-source-weights;docs/spa-conventions.md§11 gained a bullet recording the per-source correction-row convention, but no new or reversed decision.Reusable knowledge:
sourcesRequest()againstCreateAutoTunedChannelsHandler.cs:203(sources.Any(s => s.Weight != 1 || s.Excluded || !baseIds.Contains(s.SourceId))). They match, and the client is a strict refinement: it clamps before testing while the server tests rawWeightbeforeNormalizeWeight, so a typed0/-3can never reach the wire and needlessly flip the channel into MultiCollection shape. No unit test with a mocked server can establish this — it requires reading the handler.undefinedwhen nothing is customised keeps an untouched channel on the single-SmartCollection fair-share path; sending an all-default array would be a harmless no-op server-side but is noise on the wire and blurs the Edited/dirty-guard signal.LUCENE_WILD_SPECIALinAutoTuneScreen.tsxis byte-identical toWILD_SPECIALinbuilder/rules/compile.ts— copied becauseescapeWildis not exported. Two copies drift. Tracked in #590.Membersempty, remainder query excludes everything). Nothing crashes and #415's health object flags it after creation, but there is no warning at the point of the mistake. Tracked in #590.Verification:
npm test988/988 (14/14 in the screen's own suite), lint clean,npm run buildok,tsc --noEmitclean. Live-E2E passed with concrete evidence: fresh config dir, seeded 2-show library, driven headless through the real SPA — added "Show Beta" via the new typeahead, weight 3, "Edited" badge appeared, Create. Captured POST body carriedsources:[{"sourceId":9,"weight":3,"excluded":false}]; server built a system-owned MultiCollection (show_title:"Show Alpha"w1,show_title:"Show Beta"w3, remainder w1); built playout of 106,576 items split 26,644 / 79,932 = exactly 3.000:1. Scope limit stated honestly: happy path only — exclusions, multiple customised sources, and out-of-range input are covered by unit tests, not live. Two independent review rounds (full adversarial pass + re-verification of the fix delta); CI green on22e89fb9.Deferred: #590 — export the shared Lucene escaper instead of duplicating it, warn on exclude-all, and handle >50-source axes (beyond the 50-row preview, a typeahead pick of an existing member gets a cosmetic "Added" label and one redundant server-no-op'd wire row; only the first 50 sources are editable).
Incident (unrelated to the change, same session): the E2E agent found a foreign ErsatzTV on port 8409, correctly moved to 8420, but cleaned up with a pattern-wide
pkill -f "dotnet ErsatzTV.dll"that could have killed a parallel session's server. No damage — that session's harness traps its own PID and its runs had already printed explicit pass summaries. Root cause was my delegation brief (fresh config dir specified, process cleanup unspecified). Port separation is not mitigation; scope by PID. Tracked in #586.Docs updated:
docs/spa-conventions.md§11 (per-source correction-row convention). Two text defects found in review were fixed in-PR at22e89fb9: a code comment that stated the opposite of the code, and doc wording implying a sharedWEIGHT_MIN/WEIGHT_MAXmodule that does not exist.