Closed
opened 2026-07-18 01:50:37 +02:00 by timothy
·
3 comments
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#436
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Follow-up to #176 (PR #433). The Kodi model ships one level of group nesting (covers
type:movie AND (genre:Horror OR genre:Thriller)). If a real query needs deeper nesting, extend the model, compiler, parser (theallowNestedcap inparse.ts), and the round-trip property test. YAGNI until then.Done-when
🔗 Session bundle — rule builder (#176 follow-ups): #434, #435, #436, #437, #438
All frontend RuleBuilder follow-ups deferred from #176: facet-value typeahead (#434), relative-date operators (#435), deeper nesting (#436), inline adoption in ChannelBuilder & Auto-Tune (#437), input validation & polish (#438). One SPA component, one session.
When you claim any member, check this cluster for co-workable siblings and sweep the disjoint set in one session (per docs/handoffs/chicorytv-issue-queue.md → bundles).
Claiming — Claude Code session 2026-07-25, bundled with #440 (shared
frontendlabel, disjoint slices).Note on this issue's own YAGNI gate: the rule-builder cluster (#434/#435/#437/#438) has fully landed, and #437 put the RuleBuilder inline in Channel Builder, which broadens authoring exposure. Picking this up as the last open member of that cluster; confirmed with the operator before claiming.
Closing record
Outcome: Shipped via PR #584 (merged,
6cf99718). The rule builder now supports arbitrary-depth group nesting under a shared capMAX_GROUP_DEPTH = 5, replacing the one-level "Kodi" model. Scope turned out smaller than the issue anticipated:compile.tsandvalidation.tswere already recursive and are untouched — the one-level restriction lived only inparse.ts'sallowNestedflag and theRuleBuilder.tsx"Add group" gate.Root cause: n/a (feature, not a bug) — but see Reusable knowledge for a latent bug found en route.
Decisions/conventions changed: Added
spa.rulebuilder-nesting(2026-07-25), supersedingspa.smartcollection-rule-builder@2026-07-18. The predecessor was relocated verbatim, heading unchanged to the newdocs/decisions/archive/spa.mdwith a reciprocalsuperseded-by.Reusable knowledge:
parse.tspreviously treated any part matchingstartsWith('(') && endsWith(')')as one wrapped group, so(genre:"a")(genre:"b")parsed into a garbage single-rule tree with valuea")(genre:"b— a lossy accept that violates the exact-inverse invariant. Opening such a hand-typed saved query in the builder and re-saving would have silently corrupted it.isParenWrapped()(quote/escape-aware: the leading(must be the one closed by the trailing)) returnsnullinstead, falling back to raw-text editing. Differential fuzzing over 15,000 compiled old-model queries found 0 divergences otherwise, so this is a pure narrowing.MAX_GROUP_DEPTH; review verified it by simulating regressions (generator capped at 1 → FAILS; capped at 4 → FAILS).MAX_GROUP_DEPTHis read by the parser, the UI gate, and the property-test generator. A second hardcoded depth anywhere would let the builder author a tree its own parser rejects, stranding the user's query into raw-text mode on reload.Verification:
npm test990/990, lint clean,npm run buildok,tsc --noEmitclean. Independent adversarial review (cold brief, different model family): 20,000 generated trees × 10 seeds at nesting probability 0.5 with the corpus verifiably reaching depth 5 → zero round-trip failures; differential old-vs-new fuzz over 15,000 queries → 0 divergences; cap boundaries confirmed empirically from both directions (5-deep round-trips, 6-deep →null→ raw-text fallback, no crash or truncation). CI green on6cf99718(Build & push imagecorrectlyskipped— docs/SPA-only change, #416's docs-only detect).Deferred: none.
Docs updated:
docs/spa-conventions.md§12 (nesting model rewritten),docs/decisions.md(new record),docs/decisions/archive/spa.md(new file, predecessor relocated),docs/decisions/README.md(regenerated).