Rerun-collection picker in SchedulesScreen silently truncates at 100 (asks for pageSize 1000, server clamps to 100) #634
Closed
opened 2026-07-25 23:42:51 +02:00 by timothy
·
2 comments
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#634
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Split out of #616. The off-by-one there (
pageNum: 1, which skipped the whole first page) is fixed; this is the remaining, smaller defect of the same class in the same call.web/src/screens/SchedulesScreen.tsxloads the rerun-collection picker withgetRerunCollections({ pageNum: 0, pageSize: 1000 }).RerunCollectionControllerclampspageSizeto 100 (Math.Clamp(pageSize, 1, MaxPageSize)), so the request is served 100 rows regardless. ThepageSize: 1000clearly encodes an intent of "give me all of them".So with more than 100 rerun collections, the picker silently omits the rest — no error, no truncation indicator, and a schedule item simply cannot be pointed at a rerun collection that exists. Same silent-short-set shape as #616, just gated on a larger library.
Not urgent (it needs >100 rerun collections to bite) and deliberately left out of the #616 PR to keep that diff to the confirmed defects.
Fix
Page to completeness against
totalCount, the wayCollectionsScreen.enterReorderalready does for collection items — fetch page 0, then keep requesting whileloaded < totalCount. Prefer reusing that pattern over raising the server cap;api.search-allitems-pagingset the precedent that the client pages to completeness rather than the server returning unbounded lists.Worth checking the other
Promise.allpicker loads inloadPickerDatafor the same assumption while you are there — several fetch a list with no paging at all.Done-when
totalCountabove one page and assert the picker sees all of them)loadPickerDataare checked for the same silent-truncation assumptionClaiming — bundled with #633 this session (both split out of #616's paging cluster; disjoint file sets, so they run as parallel slices).
Closing record
Outcome: Shipped in PR #645 (merged as
5f3623b3).SchedulesScreen's rerun-collection picker now pages to completeness againsttotalCountvialoadAllRerunCollections()instead of issuing onepageSize: 1000request the server clamps to 100.Root cause: A client asking for a page size larger than the endpoint's cap, and treating the single response as the whole list.
RerunCollectionControllerclamps toMaxPageSize = 100, so thepageSize: 1000encoded an intent ("give me all of them") the API never promised to honour. Past 100 rerun collections the extras vanished with no error and no truncation indicator — a schedule item simply could not be pointed at a rerun collection that existed.Decisions/conventions changed: None. This upholds existing
api.paging-zero-basedandapi.search-allitems-paging(the client pages to completeness; the server stays bounded) rather than changing either. The server cap was deliberately not raised.Reusable knowledge:
pageNum=0. True while exactly one request was ever issued — but legitimate paging walks 1, 2, …, so the assertion described something correct code does not do. It passed only because the fixture'stotalCountfits one page; raising that default would have failed the #616 test with a misleading "requested page 1" signal, sending the next reader after a defect that isn't there. When a fix changes how many calls a code path makes, re-read the tests that assert on all of them.RerunCollectionsScreen.tsx:136, which means this fix lets a schedule reference rerun collection #120 while the screen that creates and edits it still cannot show it.Verification:
npx vitest run src/screens/SchedulesScreen.test.tsx27 passed; full web suite 997 passed;tsc -band eslint clean; full CI green on headf9380eb4. Mutation-verified: forcing the loop to stop after page 0 reddens the new test (expected 1 to be 2). The new test pins the exact 150-element option set withtoEqual, not a non-empty check. The independent reviewer separately mutation-verified the narrowed #616 guard — reintroducing the original #616 defect still fails that test with its own message. No live-E2E: read-only SPA load path, no write path or server state touched.Deferred: The seven sibling truncating call sites → #644 (
priority: medium). Two review nits declined with reasons: the concurrent-insert duplicate-row window (inherent to offset paging, identical in the mirroredCollectionsScreen.enterReorderprecedent) and raising the server cap (rejected onapi.search-allitems-paginggrounds).Docs updated: None required — no convention, route, endpoint or decision changed. The
api.paging-zero-basedcontract this upholds is documented by the sibling issue #633.timothy referenced this issue2026-07-26 22:11:56 +02:00
timothy referenced this issue2026-07-26 22:11:57 +02:00
timothy referenced this issue2026-07-26 22:12:00 +02:00
timothy referenced this issue2026-07-26 22:12:00 +02:00
timothy referenced this issue2026-07-26 22:12:02 +02:00
timothy referenced this issue2026-07-26 22:12:03 +02:00