Seven more SPA list loads silently truncate at the server cap (same class as #634, one screen over) #644
Closed
opened 2026-07-26 11:16:48 +02:00 by timothy
·
2 comments
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#644
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Found by the cold review of the #634 PR, and confirmed by grep. #634 fixed one call site; the same defect shape survives at seven more, all in
web/src/screens/.Each asks for a
pageSizefar above what the endpoint actually clamps to, takesresult.pageas if it were the whole list, and has no paging UI — so past the cap the rows simply vanish. No error, no truncation indicator.api.paging-zero-basedis explicit that the offset derives from the effective (capped) size, so the over-largepageSizebuys nothing at all.RerunCollectionsScreen.tsx:136/api/v1/rerun-collectionsRerunCollectionsScreen.tsx:105/api/v1/multi-collectionsRerunCollectionsScreen.tsx:111/api/v1/library/browseMultiCollectionsScreen.tsx:40/api/v1/multi-collectionsPlaylistsScreen.tsx:152/api/v1/multi-collectionsPlaylistsScreen.tsx:158/api/v1/library/browseFillerPresetsScreen.tsx:489/api/v1/library/browseWhy this is worth its own issue
RerunCollectionsScreen.tsx:136is the sharp one: #634 made the schedule picker able to reference rerun collection #120, while the screen that creates and edits rerun collections still cannot show it. Shipping one without the other leaves a state a user can reach but not manage.Fix
Same pattern #634 used: page to completeness against
totalCount, mirroringCollectionsScreen.enterReorder. Do not raise the server caps —api.search-allitems-pagingset the precedent that the client pages and the server stays bounded.Worth extracting the loop once rather than writing it a seventh time; #634's
loadAllRerunCollectionsis a reasonable starting shape but is currently local toSchedulesScreen.Done-when
library/browsepickers, tracked to #651)getMultiCollectionsandgetLibraryBrowseItemsloaders, pinning the exact expected set (not a non-empty check)pageSize:above an endpoint's cap inweb/srcScope amendment (2026-07-26, after the cold review)
The original box "returns the complete list regardless of count" is withdrawn for three of the
seven sites, because doing it would have been worse than the bug.
RerunCollectionsScreen.tsx:111,PlaylistsScreen.tsx:158andFillerPresetsScreen.tsx:489aregetLibraryBrowseItemspickers whosemediaTypecan beEpisode/Song/Image/Movie/MusicVideo. Paging those to completeness on a large library means ~200 serial requests on mount,each more expensive than the last (
LuceneSearchIndex.Searchcollectsskip + limitsortedtop-docs), feeding tens of thousands of
<option>nodes into a native<select>.The defect this issue actually names is silent truncation. So those three keep a bounded load
and gain a visible truncation hint; making them genuinely usable needs a searchable source, which
is #651. The four bounded, admin-created lists do page to completeness as planned.
Also filed from this review: #650 (two more at-cap truncations the over-cap grep could not see).
Claiming — picked up as the top-ranked eligible backlog issue by
scripts/select-queue.sh(prio-medium, no open blockers).Closing record
Outcome: Merged as PR #656.
web/src/api/paging.ts(loadAllPages) is the single pagingimplementation; #634's loop in
SchedulesScreenis now a delegate, so no copy survives. The sevencall sites are split into two classes rather than all paged to completeness — see Root cause.
Root cause: Two distinct causes, and only the first is what the issue described.
The reported defect. Each site asked for a
pageSizefar above the endpoint's clamp(
MaxPageSize = 100, confirmed by readingRerunCollectionController,MultiCollectionControllerand
LibraryBrowseController— not taken from the issue), then treatedresult.pageas the wholelist with no paging UI. The inflated
pageSizebought nothing, becauseapi.paging-zero-basedderives the offset from the effective (capped) size.
Why the prescribed fix was wrong for three of them. The issue's "page all seven to completeness"
instruction did not account for what those three pickers are over.
RerunCollectionsScreen:111,PlaylistsScreen:158andFillerPresetsScreen:489callgetLibraryBrowseItemswith amediaTypethat can be
Episode/Song/Image/Movie/MusicVideo— the largest tables in an install — andfeed a native
<select>. Paging those to completeness on a 20k-episode library means ~200 serialrequests on mount, each more expensive than the last (
LuceneSearchIndex.SearchcomputeshitsLimit = skip + limitand collects that many sorted top-docs, then runs a second search for thepage map), rendering tens of thousands of
<option>nodes. That is worse than the truncation.The defect the issue actually names is silent truncation. So those three keep a bounded page and
gained a visible truncation hint; the first Done-when box was amended rather than ticked as written.
Decisions/conventions changed: added
spa.list-completeness-vs-bounded-pickers— page tocompleteness only for lists bounded by construction; a picker over a media library stays bounded and
shows its truncation.
Reusable knowledge:
pageSize:above an endpoint's cap. Two more truncations request exactly the cap and weretherefore structurally invisible to it (#650) —
TraktListsScreenrenders "101 lists" above 100rows;
ChannelBuilder.loadCollectionsreturnstotalCount: merged.length, socanLoadMorecannever fire. The defect is "treating one page as the whole list", not "an inflated number".
helper's empty-page
breakreturned a partial list indistinguishable from a complete one — and itis reachable in normal operation, since
HydrateMediaItemsdrops Lucene hits whose DB rowsvanished and the handler's own comment admits
totalCountcan be stale. Now{ items, complete }.rendered "Showing the first 47 of 47 — use search to narrow", pointing at a search box that does not
exist for that picker. Split into a
hint: 'truncated' | 'incomplete' | 'none'discriminator.activeRef("still mounted") never answered "still current"; the window widened from one RTT to N, so a stale
loop could resurrect deleted rows. Needed
seqRef+AbortController.Verification: 107 test files / 1019 vitest tests,
npm run lintclean,npm run build(
tsc -b && vite build) clean,decisions-validate: OK. Full CI green ondaedf003(Build & test,EF migration integrity, Functional E2E, Formatting, API docs in sync, script tests, decisions
lifecycle). Three cold adversarial review rounds; the round-2 reviewer ran a negative control on the
generic-typing fix, reverting the conditional rest-tuple and confirming
tscthen reportsTS2578: Unused '@ts-expect-error' directive— proving that guard is load-bearing, not decorative.Deferred:
library/browsepickers need a searchable source; a bounded 100-row window isusable only by accident. The
queryparam already exists and two other call sites use it.AbortSignalstops the loop issuing further pages; it is not threaded into the domain APIloaders, so an already-in-flight request still completes. Threading it would touch every module in
web/src/api/. The docs say "stops issuing further page requests", which is accurate.Docs updated:
docs/spa-conventions.md(§3b, rewritten for the Class A/B split and thehintdiscriminator),
docs/decisions/records/spa/list-completeness-vs-bounded-pickers.md(new),docs/decisions/README.md(regenerated).