CollectionsScreen AddItemsDialog windows the whole media-library type on an empty query, with no truncation surfaced (§3b deviation) #685
Closed
opened 2026-07-27 19:01:09 +02:00 by timothy
·
2 comments
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#685
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Found while reconciling the #650
pageSizeregistry in #684. Not fixed there — #684 records ithonestly as a deviation rather than mislabelling it compliant. This issue is the fix.
The defect
AddItemsDialog.runSearch(web/src/screens/CollectionsScreen.tsx:225) is reachable with an emptyquery by two paths:
:311)selectKindFiltercallsrunSearch(filter)immediately (
:247,:333)getLibraryBrowseItemsomitsquerywhen falsy (web/src/api/libraryBrowse.ts:21,if (params.query)), so an empty query degrades the request into an unfiltered browse of the wholetype, first 50 rows — for each of
DEFAULT_SEARCH_KINDSwhen the filter isall. That is exactlythe bounded-window picker shape
docs/spa-conventions.md§3b forbids for media-library typespost-#651.
Nothing surfaces the truncation:
runSearchnever readsresult.totalCount, and the render(
:346-372) has no hint. Separately,merged.slice(0, 50)(:239) silently drops up to 100 of 150fetched rows even for a real query.
Scenario: open "Add items" on a 20k-episode library, click the "Episodes" chip, and the
alphabetically-first 50 episodes are presented as the answer with no indication anything is missing.
Why it was invisible
It requests
pageSize: 50— under the cap — so neither #644's inflated-pageSizegrep nor #650'sat-cap check could see it. The #650 registry classified it
class-b("bounded page withtotalCountsurfaced"), which was already false: no hint has ever rendered here.
Fix direction
Per §3b, media-library types resolve by SEARCH: render
SearchPickeroversearchLibraryPickerOptions(spa.library-pickers-resolve-by-search), gated onLIBRARY_PICKER_MIN_QUERY, so a kind-chip click issues zero requests. NoteADDABLE_TYPESincludes collection-family types, which §3b excludes from search (the handler LIKE-matches
queryfor those) — those keep the bounded page and must gain a real truncation hint.
Once fixed, flip the registry entry in
web/src/api/pageSizeCallSites.guard.test.tsfromdeviationto its true class and drop the deviation note.Done-when
merged.slice(0, 50)drop is either removed or surfacedCollection-family types (excluded from search by §3b) surface a real truncation hint— no subject on this screen; see note belowdeviation; guard greenNote on box 4 (ticked as not-applicable, not as done): this issue's body states that
ADDABLE_TYPESincludes collection-family types. It does not. All tenADDABLE_TYPE_LISTentries(
Movie,TelevisionShow,TelevisionSeason,Artist,Episode,MusicVideo,Song,OtherVideo,Image,RemoteStream) are §3b Class B media-library types, andMEDIA_KIND_FILTERSoffers no collection-family kind — so there is no collection-family picker hereto give a truncation hint to. Verified in code before the fix was designed, and confirmed
independently during review. Nothing was skipped.
The media truncation the box was reaching for IS surfaced: each kind is capped at
LIBRARY_PICKER_RESULTS, andAddItemsDialognow sums the per-kindtotalCountand rendersShowing N of M matches — narrow your search.Claiming this — Claude Code session, 2026-08-05. Working the §3b SearchPicker conversion for AddItemsDialog per the fix direction in the body.
Closing record
Outcome: Fixed and merged — PR #741 (5 commits, merged to
main).AddItemsDialognow resolves by search: no request belowLIBRARY_PICKER_MIN_QUERYfrom either entry path, one bounded request per kind per settled query, raw text compiled viatitleContainsQuery,merged.slice(0, 50)removed, and the per-kind cap surfaced asShowing N of M matches. Results carry aResults for "<query>"label keyed to the settled query.Root cause: Two independent causes, both invisible to the checks that should have caught them.
(1)
getLibraryBrowseItemsomitsquerywhen falsy (if (params.query)), so an empty query silently becomes no filter rather than no results — a browse of the whole type.runSearchnever required a query, andselectKindFiltercalled it immediately on a chip click.(2) It requested
pageSize: 50, under the 100 cap, so neither #644's inflated-pageSizegrep nor #650's at-cap check could see it. The #650 registry then classified itclass-b("bounded page withtotalCountsurfaced"), which was already false — no hint had ever rendered here. A registry entry vouching for behaviour that does not exist is the deeper cause: it converted an unexamined call site into a documented-as-safe one.Decisions/conventions changed: No new
key:.docs/spa-conventions.md§3b extended: (a)SearchPickeris the single-select shape, not the rule — a multi-select picker satisfies §3b by taking the constraints via a shared helper; (b) the parent paragraph's "there is no truncation, so there is no truncation hint" corrected, since it contradicted the new hint two lines below; (c) a gate's home is the shared helper, not the screen.Reusable knowledge:
runSearch— the genuine single sink both entry paths route through, so it read as correct — while the helper also gated. The two masked each other: with both present, deleting either left the whole suite green, so the boundary test pinned nothing. "It's the single sink" is not evidence it is the only guard.searchLibraryBrowseItemsto make the bound structural shipped with zero tests, so deleting its clamp left 1119/1119 green while the registry note claimed callers "cannot skip the bound". Review round 2 BLOCKED on exactly this — the previous round's finding relocated, not removed.MediaKindFilterwas derived fromADDABLE_TYPE_LISTand the note claimed type-system enforcement — butDEFAULT_SEARCH_KINDS, theallfan-out, was a second ingress and still typed as the whole union. One unenforced ingress is enough to overstate a hint that sums pre-filter counts against post-filter rows.<p aria-live>mounted together with its content announces nothing — most screen readers only announce mutations to a region that already existed.role="alert"is the opposite: it is the one live-region role reliably announced on insertion. The two are correct for opposite reasons.ADDABLE_TYPEScontains no collection-family types (all ten are Class B media types), and the prescribedSearchPickeris single-select and cannot serve this multi-select dialog.Verification:
npm run typecheckclean (nevernpx tsc --noEmit— solution-style config checks zero files),npm run lintclean, 1199/1199 web tests green locally on currentorigin/main. CI on head7be4265: 11/12 green, 1 skipped (image push, not run on PRs);Build & test (.NET)ran ~11 min, so the web suite genuinely executed rather than taking the docs-only fast path. Every new test verified by mutating its single clause and confirming it reddens. Four independent adversarial review rounds (cold brief, isolated worktree, different context each time); round 2 returned BLOCKED, rounds 4 and 5 confirmed no new defects with all severity bands empty. No live-E2E: pure-SPA change, no API or server-state effect.Deferred: #740 —
AddItemsDialog.runSearchhas noseqRefstale-response guard, noAbortSignal, and nouseIsMountedRef(). Pre-existing, not introduced here (the pre-fixrunSearchwas equally async and equally unguarded from both paths), and confirmed as such by review. Also declined with reasons, all NIT-level: theNaNpageSizeedge (copied faithfully from the sibling helper — diverging would be worse), the clamp test's unpinned lower bound (same), and the registry's same-identity substitution gap (already disclosed in that file's header). One further nit noted and left:erroris shared between search and add failures, so a failed add also suppresses a search-derived empty state — same class, no new regression.Docs updated:
docs/spa-conventions.md(§3b, as above) and theweb/src/api/pageSizeCallSites.guard.test.tsregistry — theCollectionsScreen.tsxdeviationentry retired and replaced by asearch-boundedentry onapi/libraryBrowse.ts, which zeroed the registry's deviation list and required its anti-vacuity assertion to be deliberately retired per that assertion's own instruction, with a bidirectional replacement that still has teeth.