main is red: the #650 pageSize call-site guard keys its registry on line:column, so any merge that shifts a line breaks it #684
Closed
opened 2026-07-27 18:48:28 +02:00 by timothy
·
1 comment
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#684
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Symptom
Build & test (.NET)fails onmainat1d76a088c(run 1387, API run id 1656) inweb/src/api/pageSizeCallSites.guard.test.ts, with 4 UNREGISTERED and 5 STALE entries.This is not confined to that historical run —
mainis red right now. Reproduced locally on aclean
origin/main(ac0f65c74). The later greenmainruns (1393, 1388) do not contradict it:their
Build & testcompleted in ~47s, i.e. the docs-only fast path, so the web suite never ran.The last
mainpush that actually exercised it is the one that failed.Root cause
Corrected after review — the first version of this issue misattributed it. The guard's REGISTRY
pins every
pageSizecall site by absoluteline:column(#650 follow-up F5/M-6), making it afunction of every other file in the repo. The guard was born red:
fad6805b9) movedAutoTuneScreen.tsxup ten lines andFillerPresetsScreen.tsxdownseventy-two, and merged before the guard's own PR (#675) did (
git merge-base --is-ancestor fad6805b9 d751f5e01succeeds). The registry, authored against a pre-#651 base, was stale theinstant it landed — and two of its entries named sites #651 had deleted outright.
d751f5e01), so nothing reported thered. It first surfaced on the next push, #676's merge — which touches no
web/srcfile and isnot the cause.
ci.cancelled-is-not-a-verdict, paying out.That is one ordering accident, not a recurring pattern. The exposure is general anyway: every PR
is green against its own base, so the breakage exists only in the merge result and lands on
mainafter review and after the merge gate.
Two secondary staleness items found on the way:
spa.list-completeness-vs-bounded-pickers, which #651 superseded andmoved to
archive/— a stale breadcrumb.class-blabel ("bounded page withtotalCountsurfaced") was applied to sites thatrender no hint and never did, so the registry claimed evidence that does not exist.
Fix
Key the registry on
(file, kind, value)and drop the position. A new site, a removed site and achanged value all still fail; only moving an unchanged site stops failing. The MULTISET comparison
is preserved. The SCANNER's positional identity (
pageSizeSiteId) is untouched — its test assertsreal AST positions against fixed inline fixtures, the opposite case, with no churn.
Adds a
search-boundedclass for the #651 shape, and adeviationclass so the registry refuses tolaunder a live defect into a compliant-looking label (#685 filed for the
CollectionsScreen§3b violation found while reconciling).
Done-when
origin/mainis this fix — so themerge result is green by construction (the original wording, "main is green after merge", was
circular: unsatisfiable before the merge it was meant to gate)
removed registry entry FAILS, changed value FAILS, third duplicate occurrence FAILS,
deviation without a tracking issue FAILS, non-deviation carrying one FAILS, report dropping
positions FAILS, pure line move PASSES
scripts/tests338 +npm run typecheck+ eslint cleanReview-verdict: MERGEABLE @ 6894511. Rounds 1 and 2 both returned BLOCKED and both were acted on.689451161) — combined statesuccess.Build & test (.NET)took21m38s, i.e. a real full run, not the ~47s docs-only fast path that made
mainlook greenwhile this was broken.
Closing record
Outcome: Fixed and merged as
aa1f504e0(PR #686).mainwas red on the #650pageSizecall-site guard; the guard now passes on merged
main, verified by running it against a cleancheckout rather than trusting the merge API. Registry identity moved from absolute
line:columnto(file, kind, value), so an unrelated line shift can no longer redmain.Root cause: The registry keyed each site on its source position, making it a function of every
other file in the repo. The guard was born red: #651 moved
AutoTuneScreen.tsxup ten lines andFillerPresetsScreen.tsxdown seventy-two, and merged before the guard's own PR (#675) did, so theregistry — authored against a pre-#651 base — was stale on arrival, with two entries naming sites
#651 had deleted. A cancelled CI run is what let it land: the guard's own merge run (id 1655 on
d751f5e01) was cancelled, so nothing reported the red, which first surfaced on the next push.#676's merge, which I initially blamed, touches no
web/srcfile and is not the cause.Decisions/conventions changed: Added
testing.enumerating-guard-identity-not-position— a guardwhose input is the whole repository must not encode anything the whole repository can change without
meaning to. Also establishes that a registry must not launder a defect into a compliant-looking
label (the
deviationclass, whose entries must name a tracking issue via a structural field).Reusable knowledge:
ci.cancelled-is-not-a-verdictcost a known-goodmainhere — the cancelled run was silently treated as "nothing to see".mainruns after the breakage took ~47s(docs-only path) and never ran the web suite, so
mainlooked fine while broken. Check theduration before reading a green as coverage.
branch that never touches it, and CI cannot see it coming — each PR is green against its own base.
#\d+regex over prose is not an issue reference check. The first version of thedeviation test passed with the tracking reference deleted, because the note legitimately cited
two historical issues. Use a structural field.
matched nothing and "passed", proving exactly nothing.
Verification: 8 mutations, each confirmed applied before its result was read — 7 must-fail cases
all red, the pure line move green. Full web suite 1184/1184,
scripts/tests338/338, typecheck +eslint clean. CI green on head
689451161withBuild & test (.NET)at 21m38s (a real run, not thefast path). Guard re-run against merged
mainpost-merge.Deferred: #685 —
CollectionsScreen'sAddItemsDialogdegrades to an unfiltered whole-type50-row window on an empty query and surfaces no truncation. Found while reconciling the registry;
deliberately not fixed here, and recorded as a
deviationrather than mislabelled compliant.Docs updated:
docs/decisions/records/testing/enumerating-guard-identity-not-position.md(new),docs/decisions/README.md(regenerated catalog). No route/endpoint/SPA-screen change, soblazor-route-parity.md,api-conventions.mdandspa-conventions.mdneeded no edit — the §3bdeviation this surfaced is tracked in #685 rather than changing the convention.
Process note: Review was same-family (cold brief, worktree-isolated, 3 rounds), not
cross-family — the Codex quota is exhausted until Aug 1. Rounds 1 and 2 both returned BLOCKED, and
both blockers were mine: a misattributed merge in the record, and a false exhaustiveness claim I
introduced by writing a comment and the registry it describes in the same pass.