Extend the dropped-step guard to docker-build.yml's required jobs, where a dropped step is fail-OPEN #756
Closed
opened 2026-08-06 21:30:32 +02:00 by timothy
·
2 comments
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#756
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Split out of #751, which fixed the silent-green class only in
.gitea/workflows/review-verdict.yml. Raised by cold review of that fix.The asymmetry
A step the runner declines to interpolate is dropped, and the job concludes
success(#751,ci.workflow-run-body-no-expressions). What that costs depends on which required check the job writes:review-verdict.yml/set-verdict-statusreview-verdict/h10is absent → merge blockeddocker-build.yml/test(Build & test (.NET))docker-build.yml/migrations(EF migration integrity)Those three are the required contexts on
main. #751 guarded the one where the failure mode is safe and left the two where it is dangerous — because that is where the live bug was, not because the others were checked and found fine.This repo has already been bitten by a required check going green without running the suite (#684, the docs-only fast path). That was a different mechanism with the same shape and the same cost.
Currently latent, which is exactly when it is cheap
Neither
testnormigrationshas an expression delimiter in arun:body today (build,api-docsandformatdo, so the file is not delimiter-free and the class is reachable by an ordinary edit). Latent, not absent.Proposed
Extend the start-marker pattern to the two required
docker-build.ymljobs: each writes a marker as its first act, and a trailingif: always()step fails the job when it is missing. Notes from doing it in #751:RUNNER_TEMPis/tmpon these runners, not a private per-job dir, so key the marker onGITHUB_RUN_ID/GITHUB_RUN_ATTEMPT— otherwise a stale marker makes the guard pass on a dropped run.exit 1substring is satisfiable by dead code.smalllane used in #751 — re-measure that a later step still runs after a drop there rather than assuming it transfers.Also worth considering, since it is the cheaper and more general half: a repo-wide check that no
run:body in a job writing a required context contains an expression delimiter. #751 applied that absolutely toreview-verdict.ymlonly.Done-when
docker-build.ymljobs fail when a step is dropped, verified BEHAVIOURALLY (guard body executed with and without the marker)smalllane measurement in #751ci.workflow-run-body-no-expressionsupdated: itsrule:currently states this is NOT yet a repo-wide property and points heredocs/ci-cd.mdupdatedClaiming this (Claude Code orchestrator session, 2026-08-10). Checked for prior work first: no open PR references #756,
git ls-remote --heads origin '*756*'is empty, no prior comments. Will extend the #751 start-marker guard totest+migrationsindocker-build.yml, re-measuring the drop behaviour on the build lane rather than assuming it transfers fromsmall.Closing record
Outcome: Shipped in PR #768 (squashed to
884ac8a7e). Both requireddocker-build.ymljobs now fail when a step is dropped, via per-STEP execution markers (scripts/ci-step-ran.sh) plus a trailing guard; and the raw${{opener is banned intest,migrationsandbuild.Root cause: #751 fixed the silent-green class only where it was fail-CLOSED (
review-verdict.yml, an absent required status blocks the merge). The same runner behaviour indocker-build.yml'stest/migrationsis fail-OPEN — a required check reports green having done no work — and was left because that is where the live bug was, not because these were checked.Decisions/conventions changed: Added
ci.required-job-step-execution-markers. Updatedci.workflow-run-body-no-expressions, whoserule:named this issue as its open residual and separately asserted thatbuildinterpolates legitimately and "a drop there fails no gate" — both now false.Reusable knowledge:
false) hid a one-token fail-open in the central predicate — mutate= "true"to-nand all 30 tests stayed green while the guard reported "All 2 expected step(s) executed" on every ordinary run. And a positive control that passed whether or not the mechanism worked. A green suite was never the signal; the surviving mutation was.Decisions-Edit: yesand git parsed none of them.Refs #756has no colon, so it is not a trailer, and one bad line voids the whole block. It would have surfaced as a reddecisions lifecycle— the one red this repo is standing-instructed to dismiss as a known flake. Verify withgit log --format='%(trailers:key=Decisions-Edit,valueonly)', never by reading the message.Marker identity:line answered it in one run.$( )helper's STDOUT is its return value. Printing a notice insidemarker_pathembedded it in the path.if: always(). With a dozen steps, a genuine early failure skips the rest, soalways()cries wolf on every red build. Defaultsuccess()works because guard-skipped implies job-red.Verification: 510 tests; 30 mutations killed across two harnesses;
decisions-validateclean. Measured live on the build lane in BOTH directions — probe #765 (test: step dropped, guard caught it, the only failure in the job, so the pre-change outcome would have been green;migrationsuntouched:All 6 expected step(s) executed, green) and probe #766 (a failingcontinue-on-errorstep does NOT skip the guard:All 12 expected step(s) executed, green). Both probe PRs closed unmerged, branches deleted. Five cold review rounds across two model families (Codex GPT-5.x, Claude Opus).Deferred: #767 — the
builddelimiter ban is enforced only byscript-tests, which ison: pull_requestand not a required context, so it is review-time rather than fail-closed on the tag/release path. Not closed here becauseSmoke'sif:carries a publish-ref condition the guard's always/gated buckets do not model. An earlier draft also claimed measuring it would require cutting a real release tag; that was wrong and is retracted on #767 —buildruns on every push tomain.Docs updated:
docs/ci-cd.md(new "Dropped-step guard on the required jobs" section, plus corrections to the #751 section),docs/decisions/records/ci/required-job-step-execution-markers.md(new),docs/decisions/records/ci/workflow-run-body-no-expressions.md,docs/decisions/README.md(regenerated).