Two more list loads truncate at the cap — but at-cap, so #644's over-cap grep could not see them #650
Closed
opened 2026-07-26 20:49:10 +02:00 by timothy
·
2 comments
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#650
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Found by the cold review of the #644 PR, both confirmed by reading the code. Same defect class as #634/#644 — "took
result.pageas the whole list with no paging UI" — but these request exactly the server cap rather than exceeding it, so #644's completeness grep (pageSize:above an endpoint's cap) structurally could not find them.That is the reusable lesson: the grep guard keys on the symptom (an inflated
pageSize), not the defect (treating one page as the whole list). An at-cap request is just as truncating.The two sites
1.
web/src/screens/TraktListsScreen.tsx:297— the screen contradicts itself on screengetTraktLists({ pageSize: 100 });TraktController.cs:24clamps atMaxPageSize = 100. It then doessetLists(paged.page ?? [])andsetTotalCount(paged.totalCount ?? 0), and line 500 renders{totalCount} list{s}.So with 101 Trakt lists the screen displays the text "101 lists" above a table containing 100 rows. There is no paging UI. The truncation is not merely silent, it is visibly self-contradictory, which at least makes it diagnosable.
2.
web/src/builder/ChannelBuilder.tsx:513-521—canLoadMorecan never fireloadCollectionsfans outgetLibraryBrowseItems({ query, mediaType, pageSize: 100 })per kind, then returns{ page: merged, totalCount: merged.length }. Reporting the truncated page length as the total means anycanLoadMore-style comparison ismerged.length >= merged.length— permanently false.The sibling
loadLibraryItemsimmediately below it carries the comment "preserves real paging (each kind keeps its own pageNum/totalCount, summed across kinds) so canLoadMore stays meaningful for large libraries" — so the correct pattern already exists in the same file, three lines away.loadCollectionssimply never got it.Fix
Sum the real per-kind
totalCounts inloadCollections(mirrorloadLibraryItems). For Trakt, either page to completeness via the sharedloadAllPageshelper added in #644 (the list is small and admin-created, so this is the safe class) or show the truncation explicitly.Do not simply raise the caps —
api.search-allitems-pagingis that the client pages and the server stays bounded.Done-when
TraktListsScreencan no longer display atotalCountlarger than the rows it rendersloadCollectionsreports a real total, andcanLoadMoredemonstrably fires past 100 merged itemsResolution notes (PR #675)
There was no guard to extend. #644's box 4 was a manual grep, not codified. So box 3 was satisfied by building one — and deliberately not as another value-pattern match, since that repeats the mistake this issue names.
web/src/api/pageSizeScan.tswalks the TypeScript AST, keying identity on exactline:columnwith multiset comparison against a registry. Comments, strings, template interpolation, JSX containers, destructuring, type literals,as/satisfies, and quoted/computed keys become node kinds rather than lexer edge cases. An interim hand-rolled scanner treated the//in'https://…'as a comment and reported zero sites for that whole file — the dangerous failure direction, and the reason the AST rewrite was worth it.A third at-cap site turned up that this issue didn't name:
ChannelBuilder.tsx'sSeasonsDialog(TelevisionSeason). Judged correctly Class B — no show has 100 seasons — so it keeps one bounded page, but its previously-unreadtotalCountnow drives a truncation hint.Deferred to #665: cross-page sort order and an overclaimed
totalCountpermitting no-op "Load more" — both pre-existing in the siblingloadLibraryItemspath, made newly reachable here.timothy referenced this issue2026-07-26 22:11:57 +02:00
timothy referenced this issue2026-07-26 22:12:00 +02:00
timothy referenced this issue2026-07-26 22:12:00 +02:00
timothy referenced this issue2026-07-26 22:12:02 +02:00
timothy referenced this issue2026-07-26 22:12:03 +02:00
Claiming — worked as part of a three-issue
frontendbundle this session: #650 + #651 + #578 (all downstream of #644's cold review; #578 folds in because #651 puts us in the same combobox/SearchPickercode).#650 runs in its own worktree (TraktListsScreen + ChannelBuilder.loadCollections + extending the #644 completeness guard to the at-cap shape), disjoint from #651's picker work.
Closing record
Outcome: Merged as PR #675.
TraktListsScreenpages to completeness vialoadAllPages(checkingcomplete, aborting on unmount, with a distinct incomplete state);ChannelBuilder.loadCollectionssums the real per-kindtotalCountinstead of reporting the truncated page length, socanLoadMorecan fire. A third at-cap site the issue didn't name —SeasonsDialog— was judged correctly Class B but now surfaces its previously-unreadtotalCount.Root cause: #644's guard keyed on the symptom (an inflated
pageSize) rather than the defect (treating one page as the whole list), so an at-cap request was structurally invisible to it. Compounding that, there was no codified guard to extend — #644's box 4 was a manual grep.Decisions/conventions changed: None reversed. The new guard is a mechanism, not a convention change.
Reusable knowledge:
??context, JSX containers and same-line duplicates. Rewriting on the TypeScript AST closed all of them at once, because they become node kinds rather than edge cases. The dangerous one:stripCommentstreated the//in'https://…'as a comment and reported zero sites for that whole file.npx tsc --noEmitchecks ZERO files here — the root tsconfig is solution-style ("files": []+references). It was used for four review rounds and hid six real type errors. The gate isnpm run typecheck(tsc -b).Verification:
npm run lintclean ·npm run typecheckclean ·npx vitest run110 files / 1078 tests. Four cold cross-family review rounds (read-only sandbox); round 4 found no runtime defect, round 5 MERGEABLE. Verified independently of the implementer: planted at-cap defects (duplicate in a registered file, shorthand, two same-line ternary branches, a URL-string file,as const/satisfies/quoted/computed keys, a.mtsfile) — all caught at distinct line:columns; and removing the single-flight guard fails the hook-level test withexpected [ +0, 1 ] to deeply equal [ +0 ].Deferred: #665 — cross-page sort order, and an overclaimed
totalCountpermitting no-op "Load more". Both pre-existing in the siblingloadLibraryItemspath, made newly reachable here.Docs updated: None required — no route, endpoint, convention or decision changed. The guard's contract and its documented residual gaps live in
web/src/api/pageSizeScan.tsandpageSizeCallSites.guard.test.ts.