pr-changed-files.sh paging can drop a path when the base branch advances mid-enumeration
#707
Closed
opened 2026-07-29 20:36:55 +02:00 by timothy
·
1 comment
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#707
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Found by cross-family adversarial review of PR #705 (#698). Not introduced there; the base-ref binding that PR adds does not address it.
/pulls/{n}/filesis paged by offset, and Gitea recomputes the diff against the live base branch for each page independently, then applies that page's offset. So ifmainadvances between page requests, the underlying result set can shrink or shift and a path can move into an offset range that was already consumed.Concrete scenario:
mainthat already contains 20 of those changes, so they drop out of the PR's diff.The result is a complete-looking docs-only list that omits a code file. The existing guards do not catch it:
.base.refbinding added in #705 passes — the base branch never changed, it only advanced;Why
.base.refis the right comparator anywayWorth stating so this isn't "fixed" by breaking something else:
post-review-verdict.shandpr-changed-files.shdeliberately compare the base branch name, never its tip sha (ci.exemption-provenance, #632). Comparing tips would invalidate on every unrelated merge tomain— a self-inflicted deadlock.The fix here is narrower: capture
.base.shabefore and after the enumeration and fail closed if it moved during it. That rejects only the actual race window, not a base that advanced before the run started. It is a different question from "is this PR still targeting the branch I was told about", which is what.base.refanswers.Done-when
maininterleaved between pages).base.shaacross the paging round-trips only, with the.base.refcomparator left intact and a test pinning that both exist for different reasonsci.shared-pr-file-enumerationupdatedRelated
#698 / PR #705, #649 (the shared enumeration), #632 (base-ref vs base-sha comparator).
Closing record
Outcome: Fixed and merged in PR #723 (merge
aa79ec59c), bundled with #706/#711 because all three touch the same two files.Root cause:
scripts/pr-changed-files.shbound.base.ref(branch NAME) and.head.shaacross the enumeration window but never.base.sha./pulls/{n}/filesdiffs each offset-paged page against the base's LIVE tip, so an ordinary advance ofmainmid-paging can drop rows and shift later ones into already-consumed offset ranges — producing a complete-looking docs-only list that omits a code file, with every existing guard silent.Decisions/conventions changed:
ci.shared-pr-file-enumerationupdated — the script now owns base-TIP binding as well as base-REF binding, and the record states why they answer different questions.Reusable knowledge: The ref check and the tip check are NOT interchangeable and both are needed. Comparing tips for the retarget question would self-deadlock (
mainadvances on every unrelated merge); comparing names for the advance question is blind. An advance BEFORE the window is deliberately not an error — pinned by a positive control, because a guard that failed on that would take every open PR down with it.Verification: 411 script tests green (local + CI
Script tests90s, a real run). Every new guard mutation-checked individually — each neutered in turn, each producing the intended red while its positive control stayed green. Required CI contexts green onfe3d292:Build & test (.NET)(535s, full run),EF migration integrity,review-verdict/h10. Centerpiece test is the exact window (base ref unchanged, tip advanced). The full-suite run also caught a regression a scoped run missed: this guard broke 9 tests intest_merge_consent_exemption.pywhose shim served no.base.sha— all positive controls, failing closed. The shim now models the field, and its comment records this as a standing property (it serves what the SHARED enumeration reads, so each new binding must be modelled there too).Deferred: None. Accepted cost stated in the record: a PR whose enumeration loses the race against a
mainmerge gets no exemption until its next event — a seconds-wide window at this repo's merge frequency.Docs updated:
docs/decisions/records/ci/shared-pr-file-enumeration.md.