review-verdict/h10 writes are not serialized — a stale run can overwrite a fresher verdict (ABA retarget + human-rejection race)
#706
Closed
opened 2026-07-29 20:36:01 +02:00 by timothy
·
2 comments
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#706
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Found by cross-family adversarial review of PR #705 (#698). Not introduced by that PR — it is the residual that PR narrows but cannot close, and #705's decision record now says so explicitly rather than claiming otherwise.
The common root cause: the gate's classification is read-then-write with no serialization and no compare-and-set. A commit status POST is last-writer-wins, and nothing orders concurrent workflow runs.
Race 1 — the retarget ABA
main./pulls/{n}/filessees a docs-only diff.main; A's post-enumeration re-read seesmainagain, so both of A's base checks pass.successbefore B postspending— an already-scheduled auto-merge can fire in that green window.successpermanently, with no further event left to correct it.#705 added
editedtotypes:and re-derivation of machine-written successes. That gives detection, not atomicity — it does not order the writes. My first draft of the record claimed this made the residual "non-durable"; that was wrong and is retracted in the record.Race 2 — a human rejection can be overwritten
failure(BLOCKED) viascripts/post-review-verdict.sh.success.The latest
review-verdict/h10is now green despite an explicit human rejection. #705's provenance check does not help: it runs before the human status exists. The existing tests preload a status before the step executes, so none of them exercise this window.Why this is not simply "fix the ordering"
Gitea's status API has no conditional write (no ETag / If-Match / expected-previous-state), so a plain re-read-before-POST only narrows the window again. Candidate directions, none yet evaluated:
successat all, onlypending/failure, and move exemption-granting to a separately-issued credential — changes the trust model rather than the timing.concurrencygroup per PR. Note the existing header comment inreview-verdict.ymlexplains why this workflow deliberately has no cancelling concurrency group (a cancelled run leaves an exempt PR statusless forever); a non-cancelling group may be viable.Done-when
h10)ci.exemption-provenanceresidual updated to the resolved stateRelated
#698 / PR #705 (the change that surfaced and documented this), #697 (credentials that can write the status), #663 (status is repo-global per sha), #622 (why the status is per-sha at all).
Claiming this (Claude Code session, 2026-08-03). Four-way claim check clear: no open PR references #706, no remote branch names it, no prior comments, fresh
git fetch origin mainat9dc360c9f.Plan: reproduce both races on scratch PRs with probe-named contexts (never a real
review-verdict/h10), then choose a direction. Will surface bundle-able ci-cd/security siblings (#697, #707, #711) separately rather than folding them in silently.Closing record
Outcome: Fixed and merged in PR #723 (merge
aa79ec59c). Race 1 is fenced; race 2 is narrowed, repaired after the fact, and the repair is durable.Root cause: The gate's classification was read-then-write with no serialization and no compare-and-set. Confirmed live rather than reasoned:
pull_request_targetruns for one PR genuinely overlap and the OLDER can finish LAST (probe PR #722 — run 7520 completed 20s after run 7521 started).Decisions/conventions changed: Added
ci.verdict-write-retarget-fence. Narrowedci.exemption-provenance(its #706 residual is now resolved, not merely tracked) andrelease.verdict-status-check/ci.shared-pr-file-enumerationfor the sibling fixes.Reusable knowledge — three things worth carrying:
pull_request_targetruns on Gitea 1.25.4 — with the group active, runs 7528/7529 still overlapped and 7528 ended 36s after 7529 began.concurrency:key at all cancelled the same way — Gitea auto-cancels supersededpushruns by itself, and that does not extend topull_request_target. Without the control, a no-op would have shipped as a solution.main → S → mainreadsmainat both ends, so every name-based check passes. The timeline'schange_target_branchCOUNT cannot alias (verified on PR #703: exactly 2 events; PR #717: 0). Abstaining is safe only because every retarget firesedited, which guarantees a successor run —updated_atwas rejected as the key precisely because it moves for comments/labels, which queue nothing.Verification: 411 script tests green (local + CI
Script tests90s, a real run). Every new guard mutation-checked individually — each neutered in turn, each producing the intended red while its positive control stayed green. Required CI contexts green onfe3d292:Build & test (.NET)(535s, full run),EF migration integrity,review-verdict/h10. Both races reproduced live on scratch PRs with probe-only contexts — race 1 as above; race 2 on probe PR #724, where the per-POST history shows a humanfailure(id 2, creatortimothy) then a machinesuccess(id 3, creatornull), leaving the combined status branch protection reads as SUCCESS over an explicit human BLOCKED. All probe PRs closed, all probe branches deleted, no realreview-verdict/h10ever written by a probe.Deferred: Four residuals recorded in the decision record, none failing toward silent success — the sub-round-trip window (no compare-and-set exists on Gitea's status API), the repair being itself a read-then-write, the absent vocabulary tripwire if
change_target_branchis ever renamed, and permanent exemption denial for a timeline over the 20-page cap. A human re-posting a BASE-MISMATCHED verdict after a repair buries the sentinel — that needs a user credential, so it is #697's.Docs updated:
docs/decisions/records/ci/verdict-write-retarget-fence.md(new),ci/exemption-provenance.md,ci/shared-pr-file-enumeration.md,release/verdict-status-check.md,docs/decisions/README.md(regenerated),docs/ci-cd.md→ Review-verdict gate,CLAUDE.md.Review: Independent cold adversarial review (worktree-isolated, review-only brief), six rounds, five real defects, all fixed: mark ordered after the re-read (blind multi-round-trip window); repair undone by the next event; sentinel self-clobbering via the generic description; a stale overlapping run overwriting a mid-run sentinel (
ex_repairwas dead state after the re-read — the one path failing toward SUCCESS); the same clobber via the pending path; and the post-write filter blind to sentinel rows. Final verdict MERGEABLE @fe3d292.